spec/lita/handlers/deploygate_spec.rb in lita-deploygate-0.1.0 vs spec/lita/handlers/deploygate_spec.rb in lita-deploygate-0.1.1

@@ -15,127 +15,110 @@
 
   let(:members_remove) do
     File.read('spec/files/members_remove.json')
   end
 
-  it { routes_command('deploygate add username abc123').to(:add) }
-  it { routes_command('deploygate add [e-mail] abc123').to(:add) }
-  it { routes_command('deploygate remove username abc123').to(:remove) }
-  it { routes_command('deploygate remove [e-mail] abc123').to(:remove) }
-  it { routes_command('deploygate list abc123').to(:list) }
-  it { routes_command('dg add username abc123').to(:add) }
-  it { routes_command('dg remove username abc123').to(:remove) }
-  it { routes_command('dg list abc123').to(:list) }
-
-  describe '.default_config' do
-    it 'sets user_name to nil' do
-      expect(Lita.config.handlers.deploygate.user_name).to be_nil
-    end
-
-    it 'sets api_key to nil' do
-      expect(Lita.config.handlers.deploygate.api_key).to be_nil
-    end
-
-    it 'sets app_names to nil' do
-      expect(Lita.config.handlers.deploygate.app_names).to be_nil
-    end
+  def grab_request(method, status, body)
+    response = double('Faraday::Response', status: status, body: body)
+    expect_any_instance_of(Faraday::Connection).to \
+      receive(method.to_sym).and_return(response)
   end
 
-  describe 'without valid config' do
-    it 'errors out on any command' do
-      Lita.config.handlers.deploygate.app_names = { 'abc123' => 'path/to/places' }
-      expect { send_command('dg list abc123') }.to raise_error('Missing config')
+  %w(deploygate dg).each do |name|
+    it do
+      is_expected.to route_command("#{name} add username abc123").to(:add)
+      is_expected.to route_command("#{name} add [e-mail] abc123")
+        .to(:add)
+      is_expected.to route_command("#{name} remove username abc123").to(:remove)
+      is_expected.to route_command("#{name} remove [e-mail] abc123")
+        .to(:remove)
+      is_expected.to route_command("#{name} list abc123").to(:list)
     end
   end
 
   describe 'with valid config' do
     before do
       Lita.config.handlers.deploygate.user_name = 'foo'
       Lita.config.handlers.deploygate.api_key = 'bar'
-      Lita.config.handlers.deploygate.app_names = { 'abc123' => 'path/to/places' }
+      Lita.config.handlers.deploygate.app_names = { 'abc123' =>
+                                                    'path/to/places' }
     end
 
     describe '#add' do
       it 'shows an ack when a username is added' do
-        response = double('Faraday::Response', status: 200, body: members_add)
-        expect_any_instance_of(Faraday::Connection).to receive(:post).once.and_return(response)
+        grab_request('post', 200, members_add)
         send_command('deploygate add username abc123')
         expect(replies.last).to eq('abc123: username added')
       end
 
       it 'shows an ack when an email is added' do
-        response = double('Faraday::Response', status: 200, body: members_add)
-        expect_any_instance_of(Faraday::Connection).to receive(:post).once.and_return(response)
+        grab_request('post', 200, members_add)
         send_command('deploygate add [e-mail] abc123')
         expect(replies.last).to eq('abc123: [e-mail] added')
       end
 
-      it 'shows a warning if the short name does not exist when adding someone' do
+      it 'shows a warning if the app name does not exist' do
         send_command('deploygate add username doesnotexist')
         expect(replies.last).to eq('doesnotexist: unknown application name')
       end
 
-      it 'shows an error if there was an issue adding someone' do
-        response = double('Faraday::Response', status: 500, body: nil)
-        expect_any_instance_of(Faraday::Connection).to receive(:post).once.and_return(response)
+      it 'shows an error if there was an issue with the request' do
+        grab_request('post', 500, nil)
         send_command('deploygate add username abc123')
-        expect(replies.last).to eq('There was an error making the request to DeployGate')
+        expect(replies.last).to eq('There was an error making the request ' \
+                                   'to DeployGate')
       end
     end
 
     describe '#remove' do
       it 'shows an ack when a username is removed' do
-        response = double('Faraday::Response', status: 200, body: members_remove)
-        expect_any_instance_of(Faraday::Connection).to receive(:delete).once.and_return(response)
+        grab_request('delete', 200, members_remove)
         send_command('deploygate remove username abc123')
         expect(replies.last).to eq('abc123: username removed')
       end
 
       it 'shows an ack when an email is removed' do
-        response = double('Faraday::Response', status: 200, body: members_remove)
-        expect_any_instance_of(Faraday::Connection).to receive(:delete).once.and_return(response)
+        grab_request('delete', 200, members_remove)
         send_command('deploygate remove [e-mail] abc123')
         expect(replies.last).to eq('abc123: [e-mail] removed')
       end
 
-      it 'shows a warning if the short name does not exist when removing someone' do
+      it 'shows a warning if the app name does not exist' do
         send_command('deploygate remove username doesnotexist')
         expect(replies.last).to eq('doesnotexist: unknown application name')
       end
 
-      it 'shows an error if there was an issue removing someone' do
-        response = double('Faraday::Response', status: 500, body: nil)
-        expect_any_instance_of(Faraday::Connection).to receive(:delete).once.and_return(response)
+      it 'shows an error if there was an issue with the request' do
+        grab_request('delete', 500, nil)
         send_command('deploygate remove username abc123')
-        expect(replies.last).to eq('There was an error making the request to DeployGate')
+        expect(replies.last).to eq('There was an error making the request ' \
+                                   'to DeployGate')
       end
     end
 
     describe '#list' do
       it 'shows a list of users when there are any' do
-        response = double('Faraday::Response', status: 200, body: members_full)
-        expect_any_instance_of(Faraday::Connection).to receive(:get).once.and_return(response)
+        grab_request('get', 200, members_full)
         send_command('deploygate list abc123')
         expect(replies.last).to eq('abc123: username, role: 1')
       end
 
       it 'shows an empty list of users when there arent any' do
-        response = double('Faraday::Response', status: 200, body: members_empty)
-        expect_any_instance_of(Faraday::Connection).to receive(:get).once.and_return(response)
+        grab_request('get', 200, members_empty)
         send_command('deploygate list abc123')
         expect(replies.last).to eq('abc123: No users')
       end
 
-      it 'shows a warning if the short name does not exist when listing' do
+      it 'shows a warning if the app name does not exist' do
         send_command('deploygate list doesnotexist')
         expect(replies.last).to eq('doesnotexist: unknown application name')
       end
 
-      it 'shows an error if there was an issue listing users' do
-        response = double('Faraday::Response', status: 500, body: nil)
-        expect_any_instance_of(Faraday::Connection).to receive(:get).once.and_return(response)
+      it 'shows an error if there was an issue with the request' do
+        grab_request('get', 500, nil)
         send_command('deploygate list abc123')
-        expect(replies.last).to eq('There was an error making the request to DeployGate')
+        expect(replies.last).to eq('There was an error making the request ' \
+                                   'to DeployGate')
       end
     end
   end
 end