ext/libuv/test/test-poll.c in libuv-2.0.6 vs ext/libuv/test/test-poll.c in libuv-2.0.8

@@ -19,11 +19,13 @@
  * IN THE SOFTWARE.
  */
 
 #include <errno.h>
 
-#ifndef _WIN32
+#ifdef _WIN32
+# include <fcntl.h>
+#else
 # include <sys/socket.h>
 # include <unistd.h>
 #endif
 
 #include "uv.h"
@@ -47,11 +49,11 @@
   uv_timer_t timer_handle;
   uv_os_sock_t sock;
   size_t read, sent;
   int is_server_connection;
   int open_handles;
-  int got_fin, sent_fin;
+  int got_fin, sent_fin, got_disconnect;
   unsigned int events, delayed_events;
 } connection_context_t;
 
 typedef struct server_context_s {
   uv_poll_t poll_handle;
@@ -68,11 +70,13 @@
 static int closed_connections = 0;
 
 static int valid_writable_wakeups = 0;
 static int spurious_writable_wakeups = 0;
 
+static int disconnects = 0;
 
+
 static int got_eagain(void) {
 #ifdef _WIN32
   return WSAGetLastError() == WSAEWOULDBLOCK;
 #else
   return errno == EAGAIN
@@ -138,10 +142,11 @@
   context->open_handles = 0;
   context->events = 0;
   context->delayed_events = 0;
   context->got_fin = 0;
   context->sent_fin = 0;
+  context->got_disconnect = 0;
 
   r = uv_poll_init_socket(uv_default_loop(), &context->poll_handle, sock);
   context->open_handles++;
   context->poll_handle.data = context;
   ASSERT(r == 0);
@@ -371,11 +376,17 @@
       context->sent_fin = 1;
       new_events &= ~UV_WRITABLE;
     }
   }
 
-  if (context->got_fin && context->sent_fin) {
+  if (events & UV_DISCONNECT) {
+    context->got_disconnect = 1;
+    ++disconnects;
+    new_events &= ~UV_DISCONNECT;
+  }
+
+  if (context->got_fin && context->sent_fin && context->got_disconnect) {
     /* Sent and received FIN. Close and destroy context. */
     close_socket(context->sock);
     destroy_connection_context(context);
     context->events = 0;
 
@@ -459,13 +470,13 @@
 #else
   ASSERT(sock >= 0);
 #endif
 
   connection_context = create_connection_context(sock, 1);
-  connection_context->events = UV_READABLE | UV_WRITABLE;
+  connection_context->events = UV_READABLE | UV_WRITABLE | UV_DISCONNECT;
   r = uv_poll_start(&connection_context->poll_handle,
-                    UV_READABLE | UV_WRITABLE,
+                    UV_READABLE | UV_WRITABLE | UV_DISCONNECT,
                     connection_poll_cb);
   ASSERT(r == 0);
 
   if (++server_context->connections == NUM_CLIENTS) {
     close_socket(server_context->sock);
@@ -503,13 +514,13 @@
   ASSERT(0 == uv_ip4_addr("0.0.0.0", 0, &addr));
 
   sock = create_bound_socket(addr);
   context = create_connection_context(sock, 0);
 
-  context->events = UV_READABLE | UV_WRITABLE;
+  context->events = UV_READABLE | UV_WRITABLE | UV_DISCONNECT;
   r = uv_poll_start(&context->poll_handle,
-                    UV_READABLE | UV_WRITABLE,
+                    UV_READABLE | UV_WRITABLE | UV_DISCONNECT,
                     connection_poll_cb);
   ASSERT(r == 0);
 
   r = connect(sock, (struct sockaddr*) &server_addr, sizeof server_addr);
   ASSERT(r == 0 || got_eagain());
@@ -539,10 +550,11 @@
   ASSERT(spurious_writable_wakeups == 0 ||
          (valid_writable_wakeups + spurious_writable_wakeups) /
          spurious_writable_wakeups > 20);
 
   ASSERT(closed_connections == NUM_CLIENTS * 2);
+  ASSERT(disconnects == NUM_CLIENTS * 2);
 
   MAKE_VALGRIND_HAPPY();
 }
 
 
@@ -554,7 +566,33 @@
 
 
 TEST_IMPL(poll_unidirectional) {
   test_mode = UNIDIRECTIONAL;
   start_poll_test();
+  return 0;
+}
+
+
+/* Windows won't let you open a directory so we open a file instead.
+ * OS X lets you poll a file so open the $PWD instead.  Both fail
+ * on Linux so it doesn't matter which one we pick.  Both succeed
+ * on FreeBSD, Solaris and AIX so skip the test on those platforms.
+ */
+TEST_IMPL(poll_bad_fdtype) {
+#if !defined(__DragonFly__) && !defined(__FreeBSD__) && !defined(__sun) && \
+    !defined(_AIX)
+  uv_poll_t poll_handle;
+  int fd;
+
+#if defined(_WIN32)
+  fd = open("test/fixtures/empty_file", O_RDONLY);
+#else
+  fd = open(".", O_RDONLY);
+#endif
+  ASSERT(fd != -1);
+  ASSERT(0 != uv_poll_init(uv_default_loop(), &poll_handle, fd));
+  ASSERT(0 == close(fd));
+#endif
+
+  MAKE_VALGRIND_HAPPY();
   return 0;
 }