lhm_spec.rb in lhm-2.2.0

- old
+ new

@@ -6,70 +6,70 @@
 describe Lhm do
   include IntegrationHelper
 
   before(:each) { connect_master! }
 
-  describe "changes" do
+  describe 'changes' do
     before(:each) do
       table_create(:users)
       table_create(:tracks)
       table_create(:permissions)
     end
 
-    describe "when providing a subset of data to copy" do
+    describe 'when providing a subset of data to copy' do
 
       before do
-        execute("insert into tracks set id = 13, public = 0")
+        execute('insert into tracks set id = 13, public = 0')
         11.times { |n| execute("insert into tracks set id = #{n + 1}, public = 1") }
         11.times { |n| execute("insert into permissions set track_id = #{n + 1}") }
 
         Lhm.change_table(:permissions, :atomic_switch => false) do |t|
-          t.filter("inner join tracks on tracks.`id` = permissions.`track_id` and tracks.`public` = 1")
+          t.filter('inner join tracks on tracks.`id` = permissions.`track_id` and tracks.`public` = 1')
         end
       end
 
-      describe "when no additional data is inserted into the table" do
+      describe 'when no additional data is inserted into the table' do
 
-        it "migrates the existing data" do
+        it 'migrates the existing data' do
           slave do
             count_all(:permissions).must_equal(11)
           end
         end
       end
 
-      describe "when additional data is inserted" do
+      describe 'when additional data is inserted' do
 
         before do
-          execute("insert into tracks set id = 14, public = 0")
-          execute("insert into tracks set id = 15, public = 1")
-          execute("insert into permissions set track_id = 14")
-          execute("insert into permissions set track_id = 15")
+          execute('insert into tracks set id = 14, public = 0')
+          execute('insert into tracks set id = 15, public = 1')
+          execute('insert into permissions set track_id = 14')
+          execute('insert into permissions set track_id = 15')
         end
 
-        it "migrates all data" do
+        it 'migrates all data' do
           slave do
             count_all(:permissions).must_equal(13)
           end
         end
       end
     end
 
-    it "should add a column" do
+    it 'should add a column' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.add_column(:logins, "INT(12) DEFAULT '0'")
       end
 
       slave do
-        table_read(:users).columns["logins"].must_equal({
-          :type => "int(12)",
-          :is_nullable => "YES",
+        table_read(:users).columns['logins'].must_equal({
+          :type => 'int(12)',
+          :is_nullable => 'YES',
           :column_default => '0'
         })
       end
     end
 
-    it "should copy all rows" do
+    it 'should copy all rows' do
       23.times { |n| execute("insert into users set reference = '#{ n }'") }
 
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.add_column(:logins, "INT(12) DEFAULT '0'")
       end
@@ -77,135 +77,185 @@
       slave do
         count_all(:users).must_equal(23)
       end
     end
 
-    it "should remove a column" do
+    it 'should remove a column' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.remove_column(:comment)
       end
 
       slave do
-        table_read(:users).columns["comment"].must_equal nil
+        table_read(:users).columns['comment'].must_equal nil
       end
     end
 
-    it "should add an index" do
+    it 'should add an index' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.add_index([:comment, :created_at])
       end
 
       slave do
         index_on_columns?(:users, [:comment, :created_at]).must_equal(true)
       end
     end
 
-    it "should add an index with a custom name" do
+    it 'should add an index with a custom name' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.add_index([:comment, :created_at], :my_index_name)
       end
 
       slave do
         index?(:users, :my_index_name).must_equal(true)
       end
     end
 
-    it "should add an index on a column with a reserved name" do
+    it 'should add an index on a column with a reserved name' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.add_index(:group)
       end
 
       slave do
         index_on_columns?(:users, :group).must_equal(true)
       end
     end
 
-    it "should add a unqiue index" do
+    it 'should add a unqiue index' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.add_unique_index(:comment)
       end
 
       slave do
         index_on_columns?(:users, :comment, :unique).must_equal(true)
       end
     end
 
-    it "should remove an index" do
+    it 'should remove an index' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.remove_index([:username, :created_at])
       end
 
       slave do
         index_on_columns?(:users, [:username, :created_at]).must_equal(false)
       end
     end
 
-    it "should remove an index with a custom name" do
+    it 'should remove an index with a custom name' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.remove_index([:username, :group])
       end
 
       slave do
         index?(:users, :index_with_a_custom_name).must_equal(false)
       end
     end
 
-    it "should remove an index with a custom name by name" do
+    it 'should remove an index with a custom name by name' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.remove_index(:irrelevant_column_name, :index_with_a_custom_name)
       end
 
       slave do
         index?(:users, :index_with_a_custom_name).must_equal(false)
       end
     end
 
-    it "should apply a ddl statement" do
+    it 'should apply a ddl statement' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
-        t.ddl("alter table %s add column flag tinyint(1)" % t.name)
+        t.ddl('alter table %s add column flag tinyint(1)' % t.name)
       end
 
       slave do
-        table_read(:users).columns["flag"].must_equal({
-          :type => "tinyint(1)",
-          :is_nullable => "YES",
+        table_read(:users).columns['flag'].must_equal({
+          :type => 'tinyint(1)',
+          :is_nullable => 'YES',
           :column_default => nil
         })
       end
     end
 
-    it "should change a column" do
+    it 'should change a column' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.change_column(:comment, "varchar(20) DEFAULT 'none' NOT NULL")
       end
 
       slave do
-        table_read(:users).columns["comment"].must_equal({
-          :type => "varchar(20)",
-          :is_nullable => "NO",
-          :column_default => "none"
+        table_read(:users).columns['comment'].must_equal({
+          :type => 'varchar(20)',
+          :is_nullable => 'NO',
+          :column_default => 'none'
         })
       end
     end
 
-    it "should change the last column in a table" do
+    it 'should change the last column in a table' do
       table_create(:small_table)
 
       Lhm.change_table(:small_table, :atomic_switch => false) do |t|
-        t.change_column(:id, "int(5)")
+        t.change_column(:id, 'int(5)')
       end
 
       slave do
-        table_read(:small_table).columns["id"].must_equal({
-          :type => "int(5)",
-          :is_nullable => "NO",
-          :column_default => "0"
+        table_read(:small_table).columns['id'].must_equal({
+          :type => 'int(5)',
+          :is_nullable => 'NO',
+          :column_default => '0'
         })
       end
     end
 
-    it "works when mysql reserved words are used" do
+    it 'should rename a column' do
+      table_create(:users)
+
+      execute("INSERT INTO users (username) VALUES ('a user')")
+      Lhm.change_table(:users, :atomic_switch => false) do |t|
+        t.rename_column(:username, :login)
+      end
+
+      slave do
+        table_data = table_read(:users)
+        table_data.columns['username'].must_equal(nil)
+        table_read(:users).columns['login'].must_equal({
+          :type => 'varchar(255)',
+          :is_nullable => 'YES',
+          :column_default => nil
+        })
+
+        # DM & AR versions of select_one return different structures. The
+        # real test is whether the data was copied
+        result = select_one('SELECT login from users')
+        result = result['login'] if result.respond_to?(:has_key?)
+        result.must_equal('a user')
+      end
+    end
+
+    it 'should rename a column with a default' do
+      table_create(:users)
+
+      execute("INSERT INTO users (username) VALUES ('a user')")
+      Lhm.change_table(:users, :atomic_switch => false) do |t|
+        t.rename_column(:group, :fnord)
+      end
+
+      slave do
+        table_data = table_read(:users)
+        table_data.columns['group'].must_equal(nil)
+        table_read(:users).columns['fnord'].must_equal({
+          :type => 'varchar(255)',
+          :is_nullable => 'YES',
+          :column_default => 'Superfriends'
+        })
+
+        # DM & AR versions of select_one return different structures. The
+        # real test is whether the data was copied
+        result = select_one('SELECT `fnord` from users')
+        result = result['fnord'] if result.respond_to?(:has_key?)
+        result.must_equal('Superfriends')
+      end
+    end
+
+    it 'works when mysql reserved words are used' do
       table_create(:lines)
       execute("insert into `lines` set id = 1, `between` = 'foo'")
       execute("insert into `lines` set id = 2, `between` = 'bar'")
 
       Lhm.change_table(:lines) do |t|
@@ -223,12 +273,12 @@
         index_on_columns?(:lines, ['by']).must_equal false
         count_all(:lines).must_equal(2)
       end
     end
 
-    describe "parallel" do
-      it "should perserve inserts during migration" do
+    describe 'parallel' do
+      it 'should perserve inserts during migration' do
         50.times { |n| execute("insert into users set reference = '#{ n }'") }
 
         insert = Thread.new do
           10.times do |n|
             connect_master!
@@ -248,10 +298,10 @@
         slave do
           count_all(:users).must_equal(60)
         end
       end
 
-      it "should perserve deletes during migration" do
+      it 'should perserve deletes during migration' do
         50.times { |n| execute("insert into users set reference = '#{ n }'") }
 
         delete = Thread.new do
           10.times do |n|
             execute("delete from users where id = '#{ n + 1 }'")