.rubocop_todo.yml in landrush-0.19.0 vs .rubocop_todo.yml in landrush-1.0.0

- old
+ new

@@ -1,270 +1,139 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2016-01-23 20:53:15 +0100 using RuboCop version 0.36.0. +# on 2016-01-18 12:44:48 +0100 using RuboCop version 0.36.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 1 -Lint/DuplicateMethods: - Exclude: - - 'lib/landrush/resolver_config.rb' -# Offense count: 1 -Lint/ParenthesesAsGroupedExpression: - Exclude: - - 'test/landrush/cap/linux/read_host_visible_ip_address_test.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: IgnoreEmptyBlocks. -Lint/UnusedBlockArgument: - Exclude: - - 'lib/landrush/action/teardown.rb' - # Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods. Lint/UnusedMethodArgument: Exclude: - 'lib/landrush/action/common.rb' - 'lib/landrush/config.rb' - 'test/support/fake_ui.rb' -# Offense count: 7 +# Offense count: 8 Metrics/AbcSize: - Max: 38 + Max: 36 + Exclude: + - 'lib/landrush/command.rb' # Offense count: 1 +# Configuration parameters: CountComments. +Metrics/ClassLength: + Max: 250 + +# Offense count: 2 Metrics/CyclomaticComplexity: Max: 12 -# Offense count: 52 +# Offense count: 57 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes. # URISchemes: http, https Metrics/LineLength: Max: 157 -# Offense count: 6 +# Offense count: 9 # Configuration parameters: CountComments. Metrics/MethodLength: - Max: 29 + Max: 30 # Offense count: 1 Metrics/PerceivedComplexity: Max: 14 # Offense count: 1 # Cop supports --auto-correct. -Performance/RedundantBlockCall: - Exclude: - - 'test/test_helper.rb' - -# Offense count: 1 -# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: prefer_alias, prefer_alias_method Style/Alias: - Exclude: - - 'test/test_helper.rb' + EnforcedStyle: prefer_alias_method -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: with_first_parameter, with_fixed_indentation -Style/AlignParameters: - Exclude: - - 'Gemfile' - # Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: always, conditionals -Style/AndOr: - Exclude: - - 'lib/landrush/action/common.rb' - - 'lib/landrush/action/redirect_dns.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: percent_q, bare_percent Style/BarePercentLiterals: Exclude: - 'lib/landrush/cap/linux/add_iptables_rule.rb' - 'lib/landrush/cap/linux/read_host_visible_ip_address.rb' -# Offense count: 9 +# Offense count: 2 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods. -# SupportedStyles: line_count_based, semantic, braces_for_chaining -# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object -# FunctionalMethods: let, let!, subject, watch -# IgnoredMethods: lambda, proc, it -Style/BlockDelimiters: - Exclude: - - 'lib/landrush/action/common.rb' - - 'lib/landrush/cap/debian/install_iptables.rb' - - 'lib/landrush/cap/redhat/install_iptables.rb' - - 'lib/landrush/plugin.rb' - - 'test/landrush/cap/linux/read_host_visible_ip_address_test.rb' - - 'test/landrush/store_test.rb' +# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth. +# SupportedStyles: case, end +Style/CaseIndentation: + Enabled: false -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: braces, no_braces, context_dependent -Style/BracesAroundHashParameters: +Style/ConditionalAssignment: Exclude: - 'lib/landrush/server.rb' -# Offense count: 8 -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: nested, compact -Style/ClassAndModuleChildren: - Exclude: - - 'test/support/clear_dependent_vms.rb' - - 'test/support/fake_resolver_config.rb' - - 'test/support/fake_working_dir.rb' - - 'test/support/test_server_daemon.rb' - - 'test/test_helper.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Style/ColonMethodCall: - Exclude: - - 'lib/landrush/server.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Style/DeprecatedHashMethods: - Exclude: - - 'lib/landrush/store.rb' - -# Offense count: 22 +# Offense count: 21 Style/Documentation: Enabled: false -# Offense count: 1 +# Offense count: 2 Style/DoubleNegation: Exclude: - 'lib/landrush/config.rb' + - 'lib/landrush/server.rb' -# Offense count: 1 -# Cop supports --auto-correct. -Style/EmptyLines: - Exclude: - - 'test/landrush/resolver_config_test.rb' - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: empty_lines, no_empty_lines -Style/EmptyLinesAroundBlockBody: - Exclude: - - 'test/landrush/resolver_config_test.rb' - - 'test/landrush/server_test.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: empty_lines, no_empty_lines -Style/EmptyLinesAroundClassBody: - Exclude: - - 'lib/landrush/command.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: empty_lines, no_empty_lines -Style/EmptyLinesAroundModuleBody: - Exclude: - - 'test/landrush/cap/linux/read_host_visible_ip_address_test.rb' - -# Offense count: 3 +# Offense count: 4 # Configuration parameters: MinBodyLength. Style/GuardClause: Exclude: - 'lib/landrush/action/teardown.rb' + - 'lib/landrush/server.rb' - 'test/support/fake_resolver_config.rb' - 'test/support/test_server_daemon.rb' # Offense count: 13 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues. # SupportedStyles: ruby19, ruby19_no_mixed_keys, hash_rockets Style/HashSyntax: Enabled: false -# Offense count: 4 +# Offense count: 9 # Cop supports --auto-correct. # Configuration parameters: MaxLineLength. Style/IfUnlessModifier: Exclude: - 'lib/landrush/action/common.rb' - 'lib/landrush/config.rb' + - 'lib/landrush/server.rb' - 'test/support/fake_resolver_config.rb' - 'test/support/test_server_daemon.rb' # Offense count: 4 # Cop supports --auto-correct. # Configuration parameters: SupportedStyles, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_brackets Style/IndentArray: EnforcedStyle: consistent -# Offense count: 4 -# Cop supports --auto-correct. -Style/Lambda: - Exclude: - - 'lib/landrush/plugin.rb' - - 'test/landrush/action/setup_test.rb' - - 'test/landrush/action/teardown_test.rb' # Offense count: 5 # Cop supports --auto-correct. Style/MutableConstant: Exclude: - 'issues/vbox/Vagrantfile' - - 'lib/landrush/action/common.rb' - - 'lib/landrush/command.rb' - - 'lib/landrush/config.rb' - - 'lib/landrush/version.rb' -# Offense count: 3 -# Cop supports --auto-correct. -Style/NegatedIf: - Exclude: - - 'lib/landrush/action/setup.rb' - # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles. # SupportedStyles: skip_modifier_ifs, always Style/Next: Exclude: - 'lib/landrush/action/setup.rb' -# Offense count: 1 -# Cop supports --auto-correct. -Style/Not: - Exclude: - - 'lib/landrush/action/setup.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -Style/NumericLiterals: - MinDigits: 6 - -# Offense count: 2 -# Cop supports --auto-correct. -Style/ParallelAssignment: - Exclude: - - 'test/support/test_server_daemon.rb' - # Offense count: 4 # Cop supports --auto-correct. # Configuration parameters: PreferredDelimiters. Style/PercentLiteralDelimiters: Exclude: @@ -279,84 +148,28 @@ # SupportedStyles: lower_case_q, upper_case_q Style/PercentQLiterals: Exclude: - 'lib/landrush/cap/linux/read_host_visible_ip_address.rb' -# Offense count: 13 -# Cop supports --auto-correct. -Style/Proc: - Exclude: - - 'test/landrush/action/setup_test.rb' - - 'test/landrush/action/teardown_test.rb' -# Offense count: 2 +# Offense count: 7 # Cop supports --auto-correct. -Style/RedundantParentheses: - Exclude: - - 'lib/landrush/store.rb' - - 'test/landrush/cap/linux/read_host_visible_ip_address_test.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -Style/RedundantSelf: - Exclude: - - 'lib/landrush/dependent_vms.rb' - - 'lib/landrush/server.rb' - -# Offense count: 2 -# Cop supports --auto-correct. Style/RescueModifier: Exclude: - 'lib/landrush/server.rb' - 'lib/landrush/store.rb' + - 'test/landrush/server_test.rb' -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: AllowAsExpressionSeparator. -Style/Semicolon: - Exclude: - - 'lib/landrush/resolver_config.rb' - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: only_raise, only_fail, semantic -Style/SignalException: - Exclude: - - 'lib/landrush/action/common.rb' - - 'lib/landrush/cap/linux/read_host_visible_ip_address.rb' - - 'lib/landrush/command.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -Style/SpaceAfterComma: - Exclude: - - 'lib/landrush/command.rb' - - 'test/test_helper.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Style/SpaceAfterMethodName: - Exclude: - - 'lib/landrush/server.rb' - # Offense count: 6 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: space, no_space Style/SpaceAroundEqualsInParameterDefault: Enabled: false -# Offense count: 2 +# Offense count: 4 # Cop supports --auto-correct. -# Configuration parameters: AllowForAlignment. -Style/SpaceAroundOperators: - Exclude: - - 'test/landrush/server_test.rb' - -# Offense count: 2 -# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. # SupportedStyles: space, no_space Style/SpaceInsideBlockBraces: Enabled: false @@ -365,18 +178,18 @@ # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles. # SupportedStyles: space, no_space Style/SpaceInsideHashLiteralBraces: Enabled: false -# Offense count: 2 +# Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: use_perl_names, use_english_names Style/SpecialGlobalVars: Enabled: false -# Offense count: 61 +# Offense count: 62 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes Style/StringLiterals: Enabled: false @@ -387,57 +200,17 @@ # IgnoredMethods: respond_to Style/SymbolProc: Exclude: - 'lib/landrush/cap/linux/read_host_visible_ip_address.rb' -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: final_newline, final_blank_line -Style/TrailingBlankLines: - Exclude: - - 'lib/landrush/cap/linux/add_iptables_rule.rb' - - 'lib/landrush/cap/linux/redirect_dns.rb' - - 'test/landrush/action/teardown_test.rb' - - 'test/support/fake_working_dir.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles. -# SupportedStyles: comma, consistent_comma, no_comma -Style/TrailingCommaInArguments: - Exclude: - - 'test/landrush/cap/linux/redirect_dns_test.rb' - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles. -# SupportedStyles: comma, consistent_comma, no_comma -Style/TrailingCommaInLiteral: - Exclude: - - 'lib/landrush/action/common.rb' - - 'test/landrush/cap/linux/configured_dns_servers_test.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Style/TrailingWhitespace: - Exclude: - - 'examples/Vagrantfile' - # Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist. # Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym Style/TrivialAccessors: Exclude: - 'lib/landrush/config.rb' - 'lib/landrush/server.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -Style/UnneededInterpolation: - Exclude: - - 'lib/landrush/command.rb' # Offense count: 3 # Cop supports --auto-correct. Style/UnneededPercentQ: Exclude: