plugins_manager_spec.rb in kpm-0.9.0

- old
+ new

@@ -13,142 +13,142 @@
     @plugin_dir = Pathname.new(@plugins_dir).join('ruby').join('killbill-stripe')
     FileUtils.mkdir_p(@plugin_dir)
     FileUtils.mkdir_p(@plugin_dir.join('1.0.0'))
     FileUtils.mkdir_p(@plugin_dir.join('2.0.0'))
 
-    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_false
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_falsey
   end
 
   after(:each) do
     FileUtils.remove_entry_secure @plugins_dir
   end
 
   it 'creates a plugin identifier entry with no coordinate' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('foo', 'foo_name', 'type', nil)
-    identifiers.size.should eq 1
-    identifiers['foo']['plugin_name'].should eq 'foo_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
   end
 
   it 'creates a plugin identifier entry with coordinates' do
     # Verifies file gets created if does not exist
     coordinate_map = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map)
-    identifiers.size.should eq 1
-    identifiers['bar']['plugin_name'].should eq 'bar_name'
-    identifiers['bar']['group_id'].should eq 'group'
-    identifiers['bar']['artifact_id'].should eq 'artifact'
-    identifiers['bar']['packaging'].should eq 'packaging'
-    identifiers['bar']['classifier'].should.nil?
-    identifiers['bar']['version'].should eq 'version'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['bar']['group_id']).to eq 'group'
+    expect(identifiers['bar']['artifact_id']).to eq 'artifact'
+    expect(identifiers['bar']['packaging']).to eq 'packaging'
+    expect(identifiers['bar']['classifier']).to be_nil
+    expect(identifiers['bar']['version']).to eq 'version'
   end
 
   it 'creates plugin identifier with multiple entries' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('foo', 'foo_name', 'type', nil)
-    identifiers.size.should eq 1
-    identifiers['foo']['plugin_name'].should eq 'foo_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
 
     # Verify file was created from previous entry (prev value was read)
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', nil)
-    identifiers.size.should eq 2
-    identifiers['foo']['plugin_name'].should eq 'foo_name'
-    identifiers['bar']['plugin_name'].should eq 'bar_name'
+    expect(identifiers.size).to eq 2
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
 
     # Verify file was created from previous entry (prev value was read)
     identifiers = @manager.add_plugin_identifier_key('zoe', 'zoe_name', 'type', nil)
-    identifiers.size.should eq 3
-    identifiers['bar']['plugin_name'].should eq 'bar_name'
-    identifiers['foo']['plugin_name'].should eq 'foo_name'
-    identifiers['zoe']['plugin_name'].should eq 'zoe_name'
+    expect(identifiers.size).to eq 3
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
+    expect(identifiers['zoe']['plugin_name']).to eq 'zoe_name'
   end
 
   it 'creates plugin identifiers with duplicate entries' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('kewl', 'kewl_name', 'type', nil)
-    identifiers.size.should eq 1
-    identifiers['kewl']['plugin_name'].should eq 'kewl_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['kewl']['plugin_name']).to eq 'kewl_name'
 
     # Add with a different plugin_name
     identifiers = @manager.add_plugin_identifier_key('kewl', 'kewl_name2', 'type', nil)
-    identifiers.size.should eq 1
-    identifiers['kewl']['plugin_name'].should eq 'kewl_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['kewl']['plugin_name']).to eq 'kewl_name'
   end
 
   it 'creates plugin identifiers and remove entry' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('lol', 'lol_name', 'type', nil)
-    identifiers.size.should eq 1
-    identifiers['lol']['plugin_name'].should eq 'lol_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['lol']['plugin_name']).to eq 'lol_name'
 
     # Remove wrong entry, nothing happens
     identifiers = @manager.remove_plugin_identifier_key('lol2')
-    identifiers.size.should eq 1
-    identifiers['lol']['plugin_name'].should eq 'lol_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['lol']['plugin_name']).to eq 'lol_name'
 
     # Remove correct entry
     identifiers = @manager.remove_plugin_identifier_key('lol')
-    identifiers.size.should eq 0
+    expect(identifiers.size).to eq 0
 
     # Add same entry again
     identifiers = @manager.add_plugin_identifier_key('lol', 'lol_name', 'type', nil)
-    identifiers.size.should eq 1
-    identifiers['lol']['plugin_name'].should eq 'lol_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['lol']['plugin_name']).to eq 'lol_name'
   end
 
   it 'creates plugin identifiers and validate entry' do
     # Verifies file gets created if does not exist
     coordinate_map = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
 
     identifiers = @manager.add_plugin_identifier_key('yoyo', 'yoyo_name', 'type', coordinate_map)
-    identifiers.size.should eq 1
-    identifiers['yoyo']['plugin_name'].should eq 'yoyo_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['yoyo']['plugin_name']).to eq 'yoyo_name'
 
-    @manager.validate_plugin_identifier_key('yoyo', coordinate_map).should eq true
+    expect(@manager.validate_plugin_identifier_key('yoyo', coordinate_map)).to eq true
 
     # Negative validation
     invalid_coordinate_map = { group_id: 'group1', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
 
-    @manager.validate_plugin_identifier_key('yoyo', invalid_coordinate_map).should eq false
+    expect(@manager.validate_plugin_identifier_key('yoyo', invalid_coordinate_map)).to eq false
   end
 
   it 'creates a plugin identifier entry with a new version' do
     # Verifies file gets created if does not exist
 
     coordinate_map1 = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version1' }
 
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map1)
-    identifiers.size.should eq 1
-    identifiers['bar']['plugin_name'].should eq 'bar_name'
-    identifiers['bar']['version'].should eq 'version1'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['bar']['version']).to eq 'version1'
 
     coordinate_map2 = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version2' }
 
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map2)
-    identifiers.size.should eq 1
-    identifiers['bar']['plugin_name'].should eq 'bar_name'
-    identifiers['bar']['version'].should eq 'version2'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['bar']['version']).to eq 'version2'
   end
 
   it 'sets a path as active' do
     @manager.set_active(@plugin_dir.join('1.0.0'))
-    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should eq @plugin_dir.join('1.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('1.0.0').to_s
 
     @manager.set_active(@plugin_dir.join('2.0.0'))
-    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should eq @plugin_dir.join('2.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('2.0.0').to_s
   end
 
   it 'sets a plugin version as active' do
     @manager.set_active('killbill-stripe', '2.0.0')
-    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should eq @plugin_dir.join('2.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('2.0.0').to_s
 
     @manager.set_active('killbill-stripe', '1.0.0')
-    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should eq @plugin_dir.join('1.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('1.0.0').to_s
   end
 
   it 'uninstalls a plugin via a path' do
     @manager.uninstall(@plugin_dir.join('1.0.0'))
     check_state('1.0.0', false, true)
@@ -188,21 +188,21 @@
     check_state('1.0.0', true, false)
     check_state('2.0.0', true, false)
   end
 
   it 'guesses the plugin name' do
-    @manager.guess_plugin_name('tripe').should be_nil
+    expect(@manager.guess_plugin_name('tripe')).to be_nil
     # Short name
-    @manager.guess_plugin_name('stripe').should eq 'killbill-stripe'
+    expect(@manager.guess_plugin_name('stripe')).to eq 'killbill-stripe'
     # Artifact id
-    @manager.guess_plugin_name('stripe-plugin').should eq 'killbill-stripe'
+    expect(@manager.guess_plugin_name('stripe-plugin')).to eq 'killbill-stripe'
     # Plugin name (top directory in the .tar.gz)
-    @manager.guess_plugin_name('killbill-stripe').should eq 'killbill-stripe'
+    expect(@manager.guess_plugin_name('killbill-stripe')).to eq 'killbill-stripe'
   end
 
   private
 
   def check_state(version, has_restart, has_disabled)
-    File.exist?(@plugin_dir.join(version).join('tmp').join('restart.txt')).should eq has_restart
-    File.exist?(@plugin_dir.join(version).join('tmp').join('disabled.txt')).should eq has_disabled
+    expect(File.exist?(@plugin_dir.join(version).join('tmp').join('restart.txt'))).to eq has_restart
+    expect(File.exist?(@plugin_dir.join(version).join('tmp').join('disabled.txt'))).to eq has_disabled
   end
 end