plugins_manager_spec.rb in kpm-0.8.0

- old
+ new

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe KPM::PluginsManager do
-
   before(:each) do
     logger = Logger.new(STDOUT)
     logger.level = Logger::INFO
 
     @plugins_dir = Dir.mktmpdir
@@ -12,147 +13,142 @@
     @plugin_dir = Pathname.new(@plugins_dir).join('ruby').join('killbill-stripe')
     FileUtils.mkdir_p(@plugin_dir)
     FileUtils.mkdir_p(@plugin_dir.join('1.0.0'))
     FileUtils.mkdir_p(@plugin_dir.join('2.0.0'))
 
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_false
+    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_false
   end
 
   after(:each) do
     FileUtils.remove_entry_secure @plugins_dir
   end
 
   it 'creates a plugin identifier entry with no coordinate' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('foo', 'foo_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['foo']['plugin_name'].should == 'foo_name'
+    identifiers.size.should eq 1
+    identifiers['foo']['plugin_name'].should eq 'foo_name'
   end
 
   it 'creates a plugin identifier entry with coordinates' do
     # Verifies file gets created if does not exist
-    coordinate_map = {:group_id => 'group', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version'}
+    coordinate_map = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map)
-    identifiers.size.should == 1
-    identifiers['bar']['plugin_name'].should == 'bar_name'
-    identifiers['bar']['group_id'].should == 'group'
-    identifiers['bar']['artifact_id'].should == 'artifact'
-    identifiers['bar']['packaging'].should == 'packaging'
-    identifiers['bar']['classifier'].should == nil
-    identifiers['bar']['version'].should == 'version'
+    identifiers.size.should eq 1
+    identifiers['bar']['plugin_name'].should eq 'bar_name'
+    identifiers['bar']['group_id'].should eq 'group'
+    identifiers['bar']['artifact_id'].should eq 'artifact'
+    identifiers['bar']['packaging'].should eq 'packaging'
+    identifiers['bar']['classifier'].should.nil?
+    identifiers['bar']['version'].should eq 'version'
   end
 
-
   it 'creates plugin identifier with multiple entries' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('foo', 'foo_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['foo']['plugin_name'].should == 'foo_name'
+    identifiers.size.should eq 1
+    identifiers['foo']['plugin_name'].should eq 'foo_name'
 
     # Verify file was created from previous entry (prev value was read)
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', nil)
-    identifiers.size.should == 2
-    identifiers['foo']['plugin_name'].should == 'foo_name'
-    identifiers['bar']['plugin_name'].should == 'bar_name'
+    identifiers.size.should eq 2
+    identifiers['foo']['plugin_name'].should eq 'foo_name'
+    identifiers['bar']['plugin_name'].should eq 'bar_name'
 
-
     # Verify file was created from previous entry (prev value was read)
     identifiers = @manager.add_plugin_identifier_key('zoe', 'zoe_name', 'type', nil)
-    identifiers.size.should == 3
-    identifiers['bar']['plugin_name'].should == 'bar_name'
-    identifiers['foo']['plugin_name'].should == 'foo_name'
-    identifiers['zoe']['plugin_name'].should == 'zoe_name'
+    identifiers.size.should eq 3
+    identifiers['bar']['plugin_name'].should eq 'bar_name'
+    identifiers['foo']['plugin_name'].should eq 'foo_name'
+    identifiers['zoe']['plugin_name'].should eq 'zoe_name'
   end
 
   it 'creates plugin identifiers with duplicate entries' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('kewl', 'kewl_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['kewl']['plugin_name'].should == 'kewl_name'
+    identifiers.size.should eq 1
+    identifiers['kewl']['plugin_name'].should eq 'kewl_name'
 
     # Add with a different plugin_name
     identifiers = @manager.add_plugin_identifier_key('kewl', 'kewl_name2', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['kewl']['plugin_name'].should == 'kewl_name'
+    identifiers.size.should eq 1
+    identifiers['kewl']['plugin_name'].should eq 'kewl_name'
   end
 
-
   it 'creates plugin identifiers and remove entry' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('lol', 'lol_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['lol']['plugin_name'].should == 'lol_name'
+    identifiers.size.should eq 1
+    identifiers['lol']['plugin_name'].should eq 'lol_name'
 
     # Remove wrong entry, nothing happens
     identifiers = @manager.remove_plugin_identifier_key('lol2')
-    identifiers.size.should == 1
-    identifiers['lol']['plugin_name'].should == 'lol_name'
+    identifiers.size.should eq 1
+    identifiers['lol']['plugin_name'].should eq 'lol_name'
 
     # Remove correct entry
     identifiers = @manager.remove_plugin_identifier_key('lol')
-    identifiers.size.should == 0
+    identifiers.size.should eq 0
 
     # Add same entry again
     identifiers = @manager.add_plugin_identifier_key('lol', 'lol_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['lol']['plugin_name'].should == 'lol_name'
+    identifiers.size.should eq 1
+    identifiers['lol']['plugin_name'].should eq 'lol_name'
   end
 
   it 'creates plugin identifiers and validate entry' do
     # Verifies file gets created if does not exist
-    coordinate_map = {:group_id => 'group', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version'}
+    coordinate_map = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
 
-    identifiers = @manager.add_plugin_identifier_key('yoyo', 'yoyo_name', 'type',  coordinate_map)
-    identifiers.size.should == 1
-    identifiers['yoyo']['plugin_name'].should == 'yoyo_name'
+    identifiers = @manager.add_plugin_identifier_key('yoyo', 'yoyo_name', 'type', coordinate_map)
+    identifiers.size.should eq 1
+    identifiers['yoyo']['plugin_name'].should eq 'yoyo_name'
 
-    @manager.validate_plugin_identifier_key('yoyo', coordinate_map).should == true
+    @manager.validate_plugin_identifier_key('yoyo', coordinate_map).should eq true
 
     # Negative validation
-    invalid_coordinate_map = {:group_id => 'group1', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version'}
+    invalid_coordinate_map = { group_id: 'group1', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
 
-    @manager.validate_plugin_identifier_key('yoyo', invalid_coordinate_map).should == false
+    @manager.validate_plugin_identifier_key('yoyo', invalid_coordinate_map).should eq false
   end
 
-
   it 'creates a plugin identifier entry with a new version' do
     # Verifies file gets created if does not exist
 
-    coordinate_map1 = {:group_id => 'group', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version1'}
+    coordinate_map1 = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version1' }
 
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map1)
-    identifiers.size.should == 1
-    identifiers['bar']['plugin_name'].should == 'bar_name'
-    identifiers['bar']['version'].should == 'version1'
+    identifiers.size.should eq 1
+    identifiers['bar']['plugin_name'].should eq 'bar_name'
+    identifiers['bar']['version'].should eq 'version1'
 
-    coordinate_map2 = {:group_id => 'group', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version2'}
+    coordinate_map2 = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version2' }
 
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map2)
-    identifiers.size.should == 1
-    identifiers['bar']['plugin_name'].should == 'bar_name'
-    identifiers['bar']['version'].should == 'version2'
-
+    identifiers.size.should eq 1
+    identifiers['bar']['plugin_name'].should eq 'bar_name'
+    identifiers['bar']['version'].should eq 'version2'
   end
 
   it 'sets a path as active' do
     @manager.set_active(@plugin_dir.join('1.0.0'))
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should == @plugin_dir.join('1.0.0').to_s
+    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_true
+    File.readlink(@plugin_dir.join('SET_DEFAULT')).should eq @plugin_dir.join('1.0.0').to_s
 
     @manager.set_active(@plugin_dir.join('2.0.0'))
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should == @plugin_dir.join('2.0.0').to_s
+    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_true
+    File.readlink(@plugin_dir.join('SET_DEFAULT')).should eq @plugin_dir.join('2.0.0').to_s
   end
 
   it 'sets a plugin version as active' do
     @manager.set_active('killbill-stripe', '2.0.0')
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should == @plugin_dir.join('2.0.0').to_s
+    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_true
+    File.readlink(@plugin_dir.join('SET_DEFAULT')).should eq @plugin_dir.join('2.0.0').to_s
 
     @manager.set_active('killbill-stripe', '1.0.0')
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should == @plugin_dir.join('1.0.0').to_s
+    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_true
+    File.readlink(@plugin_dir.join('SET_DEFAULT')).should eq @plugin_dir.join('1.0.0').to_s
   end
 
   it 'uninstalls a plugin via a path' do
     @manager.uninstall(@plugin_dir.join('1.0.0'))
     check_state('1.0.0', false, true)
@@ -194,19 +190,19 @@
   end
 
   it 'guesses the plugin name' do
     @manager.guess_plugin_name('tripe').should be_nil
     # Short name
-    @manager.guess_plugin_name('stripe').should == 'killbill-stripe'
+    @manager.guess_plugin_name('stripe').should eq 'killbill-stripe'
     # Artifact id
-    @manager.guess_plugin_name('stripe-plugin').should == 'killbill-stripe'
+    @manager.guess_plugin_name('stripe-plugin').should eq 'killbill-stripe'
     # Plugin name (top directory in the .tar.gz)
-    @manager.guess_plugin_name('killbill-stripe').should == 'killbill-stripe'
+    @manager.guess_plugin_name('killbill-stripe').should eq 'killbill-stripe'
   end
 
   private
 
   def check_state(version, has_restart, has_disabled)
-    File.exists?(@plugin_dir.join(version).join('tmp').join('restart.txt')).should == has_restart
-    File.exists?(@plugin_dir.join(version).join('tmp').join('disabled.txt')).should == has_disabled
+    File.exist?(@plugin_dir.join(version).join('tmp').join('restart.txt')).should eq has_restart
+    File.exist?(@plugin_dir.join(version).join('tmp').join('disabled.txt')).should eq has_disabled
   end
 end