spec/kpm/remote/base_artifact_spec.rb in kpm-0.7.2 vs spec/kpm/remote/base_artifact_spec.rb in kpm-0.8.0

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe KPM::BaseArtifact do
-
   before(:all) do
     @logger       = Logger.new(STDOUT)
     @logger.level = Logger::INFO
   end
 
@@ -24,23 +25,23 @@
       test_download dir, nil, false, true
     end
   end
 
   it 'should be able to handle download errors' do
-    nexus_down = {:url => 'https://does.not.exist'}
+    nexus_down = { url: 'https://does.not.exist' }
     Dir.mktmpdir do |dir|
       sha1_file = "#{dir}/sha1.yml"
       test_download dir, 'foo-oss.pom.xml', false, false, sha1_file
       # Verify we skip the second time
       test_download dir, 'foo-oss.pom.xml', true, false, sha1_file
       # Verify the download is skipped gracefully when Nexus isn't reachable
       test_download dir, 'foo-oss.pom.xml', true, false, sha1_file, nexus_down
       # Verify the download fails when Nexus isn't reachable and force_download is set
-      expect { test_download dir, 'foo-oss.pom.xml', nil, true, sha1_file, nexus_down }.to raise_error(SocketError)
+      expect { test_download dir, 'foo-oss.pom.xml', nil, true, sha1_file, nexus_down }.to raise_error
       # Verify the download fails when Nexus isn't reachable and the Nexus cache is empty
-      KPM::Sha1Checker.from_file(sha1_file).cache_artifact_info('org.kill-bill.billing:killbill-oss-parent:pom:LATEST', nil)
-      expect { test_download dir, 'foo-oss.pom.xml', nil, false, sha1_file, nexus_down }.to raise_error(SocketError)
+      KPM::Sha1Checker.from_file(sha1_file).cache_artifact_info('org.kill-bill.billing:killbill-oss-parent:pom:0.143.33', nil)
+      expect { test_download dir, 'foo-oss.pom.xml', nil, false, sha1_file, nexus_down }.to raise_error
     end
   end
 
   it 'should be able to download and verify generic .tar.gz artifacts' do
     # The artifact is not small unfortunately (23.7M)
@@ -53,15 +54,15 @@
     Dir.mktmpdir do |dir|
       info = KPM::BaseArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, dir)
       info[:file_name].should be_nil
 
       files_in_dir = Dir[info[:file_path] + '/*']
-      files_in_dir.size.should == 20
+      files_in_dir.size.should eq 20
 
       File.file?(info[:file_path] + '/killbill-osgi-bundles-jruby-0.11.3.jar').should be_true
 
-      info[:bundle_dir].should == info[:file_path]
+      info[:bundle_dir].should eq info[:file_path]
     end
   end
 
   it 'should be able to download and remove previous version artifacts' do
     group_id    = 'org.kill-bill.billing'
@@ -77,20 +78,17 @@
       File.file?(first_take[:file_path] + '/killbill-platform-osgi-bundles-jruby-0.36.2.jar').should be_true
 
       second_take = KPM::BaseArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, second_bundle_version, dir)
       File.file?(first_take[:file_path] + '/killbill-platform-osgi-bundles-jruby-0.36.2.jar').should be_false
       File.file?(second_take[:file_path] + '/killbill-platform-osgi-bundles-jruby-0.36.10.jar').should be_true
-
     end
   end
 
-  def test_download(dir, filename=nil, verify_is_skipped=false, force_download=false, sha1_file=nil, overrides={})
+  def test_download(dir, filename = nil, verify_is_skipped = false, force_download = false, sha1_file = nil, overrides = {})
     path = filename.nil? ? dir : dir + '/' + filename
 
-    info = KPM::BaseArtifact.pull(@logger, 'org.kill-bill.billing', 'killbill-oss-parent', 'pom', nil, 'LATEST', path, sha1_file, force_download, true, overrides, true)
-    info[:file_name].should == (filename.nil? ? "killbill-oss-parent-#{info[:version]}.pom" : filename)
-    info[:skipped].should == verify_is_skipped
-    if !info[:skipped]
-      info[:size].should == File.size(info[:file_path])
-    end
+    info = KPM::BaseArtifact.pull(@logger, 'org.kill-bill.billing', 'killbill-oss-parent', 'pom', nil, '0.143.33', path, sha1_file, force_download, true, overrides, true)
+    info[:file_name].should eq(filename.nil? ? "killbill-oss-parent-#{info[:version]}.pom" : filename)
+    info[:skipped].should eq verify_is_skipped
+    info[:size].should eq File.size(info[:file_path]) unless info[:skipped]
   end
 end