spec/knapsack/distributors/report_distributor_spec.rb in knapsack-3.0.0 vs spec/knapsack/distributors/report_distributor_spec.rb in knapsack-3.1.0

@@ -116,11 +116,11 @@
         'i_spec.rb' => 3.0,
         'f_spec.rb' => 3.5,
         'c_spec.rb' => 2.0,
         'd_spec.rb' => 2.5,
         'a_spec.rb' => 1.0,
-        'b_spec.rb' => 1.5,
+        'b_spec.rb' => 1.5
       }
     end
     let(:custom_args) { { ci_node_total: 3 } }
 
     before do
@@ -132,55 +132,131 @@
 
       it do
         expect(distributor.node_tests[0]).to eql({
           :node_index => 0,
           :time_left => -0.5,
+          :weight => 9.0,
           :test_files_with_time => [
             ["g_spec.rb", 9.0]
           ]
         })
       end
 
       it do
         expect(distributor.node_tests[1]).to eql({
           :node_index => 1,
-          :time_left => 0.0,
+          :time_left => 0.5,
+          :weight => 8.0,
           :test_files_with_time => [
             ["f_spec.rb", 3.5],
             ["d_spec.rb", 2.5],
-            ["b_spec.rb", 1.5],
-            ["a_spec.rb", 1.0]
+            ["c_spec.rb", 2.0]
           ]
         })
       end
 
       it do
         expect(distributor.node_tests[2]).to eql({
           :node_index => 2,
-          :time_left => 0.5,
+          :time_left => 0.0,
+          :weight => 8.5,
           :test_files_with_time => [
-            ["i_spec.rb", 3.0],
             ["h_spec.rb", 3.0],
-            ["c_spec.rb", 2.0]
+            ["i_spec.rb", 3.0],
+            ["b_spec.rb", 1.5],
+            ["a_spec.rb", 1.0]
           ]
         })
       end
     end
 
     describe '#tests_for_node' do
       context 'when node exists' do
         it do
           expect(distributor.tests_for_node(1)).to eql([
-            'f_spec.rb',
-            'd_spec.rb',
-            'b_spec.rb',
-            'a_spec.rb'
+            "f_spec.rb",
+            "d_spec.rb",
+            "c_spec.rb"
           ])
         end
       end
 
       context "when node doesn't exist" do
         it { expect(distributor.tests_for_node(42)).to be_nil }
+      end
+    end
+  end
+
+  describe 'algorithmic efficiency' do
+    subject(:node_weights) do
+      distro = distributor
+      distro.assign_test_files_to_node
+      distro.node_tests.map { |node| node[:weight] }
+    end
+
+    before do
+      allow(distributor).to receive(:all_tests).and_return(report.keys)
+    end
+
+    let(:custom_args) { { ci_node_total: 3 } }
+
+    context 'with the most simple example' do
+      let(:report) do
+        {
+          'a_spec.rb' => 1.0,
+          'b_spec.rb' => 1.0,
+          'c_spec.rb' => 1.0,
+          'd_spec.rb' => 1.0,
+          'e_spec.rb' => 1.0,
+          'f_spec.rb' => 1.0,
+          'g_spec.rb' => 1.0,
+          'h_spec.rb' => 1.0,
+          'i_spec.rb' => 1.0
+        }
+      end
+
+      it 'assigns all nodes equally' do
+        expect(node_weights.uniq).to contain_exactly 3.0
+      end
+    end
+
+    context 'with a medium difficulty example' do
+      let(:report) do
+        {
+          'a_spec.rb' => 1.0,
+          'b_spec.rb' => 2.0,
+          'c_spec.rb' => 3.0,
+          'd_spec.rb' => 1.0,
+          'e_spec.rb' => 2.0,
+          'f_spec.rb' => 3.0,
+          'g_spec.rb' => 1.0,
+          'h_spec.rb' => 2.0,
+          'i_spec.rb' => 3.0
+        }
+      end
+
+      it 'assigns all nodes equally' do
+        expect(node_weights.uniq).to contain_exactly 6.0
+      end
+    end
+
+    context 'with a difficult example' do
+      let(:report) do
+        {
+          'a_spec.rb' => 2.0,
+          'b_spec.rb' => 2.0,
+          'c_spec.rb' => 3.0,
+          'd_spec.rb' => 1.0,
+          'e_spec.rb' => 1.0,
+          'f_spec.rb' => 1.0,
+          'g_spec.rb' => 9.0,
+          'h_spec.rb' => 1.0,
+          'i_spec.rb' => 10.0
+        }
+      end
+
+      it 'assigns all nodes equally' do
+        expect(node_weights.uniq).to contain_exactly 10.0
       end
     end
   end
 end