lib/khalti/request_helper.rb in khalti-0.1.5 vs lib/khalti/request_helper.rb in khalti-0.2.0

@@ -1,48 +1,55 @@
+# frozen_string_literal: true
+
 module Khalti
+  # Handles API calls
   module RequestHelper
-    SECRET_KEY = ENV['KHALTI_SECRET_KEY']
-    def self.get(path)
-      self.validate_secret_key
-      uri = URI.parse(path)
-      req = Net::HTTP::Get.new(uri)
-      req['authorization'] = "Key #{SECRET_KEY}"
-      res = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) {|http|
-        http.request(req)
-      }
-      case res
-        when Net::HTTPSuccess
-          self.validate_content_type(res['content-type'])
-          JSON.parse res.body
-        else
-          raise Errors::KhaltiError.new(res.message)
+    class << self
+      SECRET_KEY = ENV['KHALTI_SECRET_KEY']
+      def get(path)
+        validate_secret_key
+        uri = URI.parse(path)
+        req = Net::HTTP::Get.new(uri)
+        req['authorization'] = "Key #{SECRET_KEY}"
+        res = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
+          http.request(req)
+        end
+        extract_response(res)
       end
-    end
 
-    def self.post(path, params)
-      self.validate_secret_key
-      uri = URI.parse(path)
-      req = Net::HTTP::Post.new(uri)
-      req['authorization'] = "Key #{SECRET_KEY}"
-      req.set_form_data(params)
-      res = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) {|http|
-        http.request(req)
-      }
-      case res
+      def post(path, params)
+        validate_secret_key
+        uri = URI.parse(path)
+        req = Net::HTTP::Post.new(uri)
+        req['authorization'] = "Key #{SECRET_KEY}"
+        req.set_form_data(params)
+        res = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
+          http.request(req)
+        end
+        extract_response(res)
+      end
+
+      private
+
+      def validate_secret_key
+        return unless SECRET_KEY.nil? || SECRET_KEY.strip.empty?
+        raise Errors::BlankError, 'Ensure KHALTI_SECRET_KEY is not blank.'
+      end
+
+      def validate_content_type(content_type)
+        return if content_type == 'application/json'
+        raise Errors::InvalidResponseError,
+              'Content-type is not application/json.'
+      end
+
+      def extract_response(res)
+        case res
         when Net::HTTPSuccess
-          self.validate_content_type(res['content-type'])
+          validate_content_type(res['content-type'])
           JSON.parse res.body
         else
-          raise Errors::KhaltiError.new(res.message)
+          raise Errors::KhaltiError, res.message
+        end
       end
-    end
-
-    private
-    def self.validate_secret_key
-      raise Errors::BlankError.new('Ensure KHALTI_SECRET_KEY is not blank.') if SECRET_KEY.nil? || SECRET_KEY.strip.empty?
-    end
-
-    def self.validate_content_type(content_type)
-      Errors::InvalidResponseError.new('Content-type is not application/json.') unless content_type ==='application/json'
     end
   end
 end