masking_smells.feature in kevinrutherford-reek-1.1.3.14

- old
+ new

@@ -54,11 +54,11 @@
         (masked) Dirty#a/block has the variable name 'x' (Uncommunicative Name)
         Dirty#a/block/block is nested (Nested Iterators)
 
       """
 
-  Scenario: switch off one smell and show hide them in the report
+  Scenario: switch off one smell and hide them in the report
     When I run reek --no-show-all spec/samples/masked/dirty.rb
     Then it fails with exit status 2
     And it reports:
       """
       spec/samples/masked/dirty.rb -- 3 warnings (+3 masked):
@@ -77,7 +77,35 @@
         Dirty has the variable name '@s' (Uncommunicative Name)
         Dirty#a calls @s.title twice (Duplication)
         Dirty#a calls puts(@s.title) twice (Duplication)
         Dirty#a has the name 'a' (Uncommunicative Name)
         Dirty#a/block/block is nested (Nested Iterators)
+
+      """
+
+  @overrides
+  Scenario: lower overrides upper
+    When I run reek spec/samples/overrides
+    Then it fails with exit status 2
+    And it reports:
+      """
+      spec/samples/overrides/masked/dirty.rb -- 2 warnings (+4 masked):
+        Dirty#a calls @s.title twice (Duplication)
+        Dirty#a calls puts(@s.title) twice (Duplication)
+
+      """
+
+  @overrides
+  Scenario: all show up masked even when overridden
+    When I run reek --show-all spec/samples/overrides
+    Then it fails with exit status 2
+    And it reports:
+      """
+      spec/samples/overrides/masked/dirty.rb -- 2 warnings (+4 masked):
+        (masked) Dirty has the variable name '@s' (Uncommunicative Name)
+        Dirty#a calls @s.title twice (Duplication)
+        Dirty#a calls puts(@s.title) twice (Duplication)
+        (masked) Dirty#a has the name 'a' (Uncommunicative Name)
+        (masked) Dirty#a/block has the variable name 'x' (Uncommunicative Name)
+        (masked) Dirty#a/block/block is nested (Nested Iterators)
 
       """