spec/plugins/pre_commit/checks/checkstyle_spec.rb in java-checkstyle-0.0.2 vs spec/plugins/pre_commit/checks/checkstyle_spec.rb in java-checkstyle-1.0.0

- old
+ new

@@ -8,46 +8,43 @@ it "succeds if nothing changed" do expect(check.call([])).to be_nil end it "succeeds for good code" do - files = [fixture_file('good.java')] + files = [fixture_file('Good.java')] expect(check.call(files)).to be_nil end it "should fail for bad formatted code" do file = fixture_file("bad.java") result = check.call([file]) - + expect(result).to include "File errors: #{file}" expect(result).to include "line: 1: error:" - expect(result).to include "line: 1:1 error:" - expect(result).to include "line: 2:3 error:" - expect(result).to include "line: 2:27 error:" + expect(result).to include "line: 1:7 error:" end - it "should accept multiple fails" do # given file = fixture_file("bad.java") file2 = fixture_file("bad2.java") - - # when - result = check.call([file, file2]) - + + # when + result = check.call([file, file2]) + # then expect(result).to include "File errors: #{file}" expect(result).to include "File errors: #{file2}" end it "should accept custom checkstyle" do # given - files = [fixture_file('good.java')] + files = [fixture_file('bad.java')] custom_config = double(PreCommit::Configuration, - get: fixture_file('google_checks.xml')) + get: fixture_file('sun_checks.xml')) # when check.config = custom_config # then - expect(check.call(files)).to be_nil + expect(check.call(files)).to_not be_nil end end