lib/inch/evaluation/proxy/method_object.rb in inch-0.4.6 vs lib/inch/evaluation/proxy/method_object.rb in inch-0.4.7

- old
+ new

@@ -27,21 +27,28 @@ def relevant_method_roles { Role::Method::Constructor => nil, Role::Method::Getter => nil, Role::Method::Setter => nil, - Role::Method::Overridden => object.overridden? ? object.overridden_method.score : nil, + Role::Method::Overridden => + if object.overridden? + object.overridden_method.score + else + nil + end, Role::Method::WithManyLines => nil, Role::Method::WithBangName => nil, Role::Method::WithQuestioningName => nil, Role::Method::HasAlias => nil, Role::Method::WithReturnType => score_for(:return_type), Role::Method::WithoutReturnType => score_for(:return_type), - Role::Method::WithReturnDescription => score_for(:return_description), - Role::Method::WithoutReturnDescription => score_for(:return_description), + Role::Method::WithReturnDescription => + score_for(:return_description), + Role::Method::WithoutReturnDescription => + score_for(:return_description), Role::Method::WithoutParameters => score_for(:parameters), - Role::Method::WithManyParameters => nil, + Role::Method::WithManyParameters => nil } end def relevant_parameter_roles(param, per_param) { @@ -50,10 +57,10 @@ Role::MethodParameter::WithoutMention => per_param * 0.5, Role::MethodParameter::WithType => per_param * 0.5, Role::MethodParameter::WithoutType => per_param * 0.5, Role::MethodParameter::WithBadName => nil, Role::MethodParameter::Block => nil, - Role::MethodParameter::Splat => nil, + Role::MethodParameter::Splat => nil } end def score_for_single_parameter @param_score ||= score_for(:parameters) / object.parameters.size