configuration.rb in i18n-tasks-0.9.7

- old
+ new

@@ -1,32 +1,32 @@
 # frozen_string_literal: true
-module I18n::Tasks::Configuration
+module I18n::Tasks::Configuration # rubocop:disable Metrics/ModuleLength
   DEFAULTS = {
-      base_locale:     'en'.freeze,
-      internal_locale: 'en'.freeze,
-      search:          ::I18n::Tasks::UsedKeys::SEARCH_DEFAULTS,
-      data:            ::I18n::Tasks::Data::DATA_DEFAULTS
-  }
+    base_locale:     'en',
+    internal_locale: 'en',
+    search:          ::I18n::Tasks::UsedKeys::SEARCH_DEFAULTS,
+    data:            ::I18n::Tasks::Data::DATA_DEFAULTS
+  }.freeze
 
   # i18n-tasks config (defaults + config/i18n-tasks.yml)
   # @return [Hash{String => String,Hash,Array}]
   def config
     @config || (self.config = {})
   end
 
   CONFIG_FILES = %w(
-      config/i18n-tasks.yml config/i18n-tasks.yml.erb
-      i18n-tasks.yml i18n-tasks.yml.erb
-  )
+    config/i18n-tasks.yml config/i18n-tasks.yml.erb
+    i18n-tasks.yml i18n-tasks.yml.erb
+  ).freeze
 
   def file_config
     file   = CONFIG_FILES.detect { |f| File.exist?(f) }
     config = file && YAML.load(Erubis::Eruby.new(File.read(file, encoding: 'UTF-8')).result)
     if config.present?
       config.with_indifferent_access.tap do |c|
         if c[:relative_roots]
-          warn_deprecated 'config/i18n-tasks.yml has relative_roots on top level. Please move relative_roots under search.'
+          warn_deprecated 'Please move relative_roots under search in config/i18n-tasks.yml.'
           c[:search][:relative_roots] = c.delete(:relative_roots)
         end
       end
     else
       {}.with_indifferent_access
@@ -42,21 +42,21 @@
   # data config
   #  @return [Hash<adapter: String, options: Hash>]
   def data_config
     @config_sections[:data] ||= begin
       {
-          adapter: data.class.name,
-          config:  data.config
+        adapter: data.class.name,
+        config:  data.config
       }
     end
   end
 
   # translation config
   # @return [Hash{String => String,Hash,Array}]
   def translation_config
     @config_sections[:translation] ||= begin
-      conf           = (config[:translation] || {}).with_indifferent_access
+      conf = (config[:translation] || {}).with_indifferent_access
       conf[:api_key] ||= ENV['GOOGLE_TRANSLATE_API_KEY'] if ENV.key?('GOOGLE_TRANSLATE_API_KEY')
       conf
     end
   end
 
@@ -69,15 +69,25 @@
   def base_locale
     @config_sections[:base_locale] ||= (config[:base_locale] || DEFAULTS[:base_locale]).to_s
   end
 
   def internal_locale
-    @config_sections[:internal_locale] ||= (config[:internal_locale] || DEFAULTS[:internal_locale]).to_s
+    @config_sections[:internal_locale] ||= begin
+      internal_locale = (config[:internal_locale] || DEFAULTS[:internal_locale]).to_s
+      valid_locales = Dir[File.join(I18n::Tasks.gem_path, 'config', 'locales', '*.yml')]
+                      .map { |f| File.basename(f, '.yml') }
+      unless valid_locales.include?(internal_locale)
+        log_warn "invalid internal_locale #{internal_locale.inspect}. "\
+                 "Available internal locales: #{valid_locales * ', '}."
+        internal_locale = DEFAULTS[:internal_locale].to_s
+      end
+      internal_locale
+    end
   end
 
   def ignore_config(type = nil)
-    key                   = type ? "ignore_#{type}" : 'ignore'
+    key = type ? "ignore_#{type}" : 'ignore'
     @config_sections[key] ||= config[key]
   end
 
   IGNORE_TYPES = [nil, :missing, :unused, :eq_base].freeze
   # evaluated configuration (as the app sees it)
@@ -94,27 +104,27 @@
     end
     @config_sections
   end
 
   def config_for_inspect
-    to_hash_from_indifferent(config_sections.reject { |k, v| v.blank? }).tap do |sections|
+    to_hash_from_indifferent(config_sections.reject { |_k, v| v.blank? }).tap do |sections|
       sections.each do |_k, section|
-        section.merge! section.delete('config') if Hash === section && section.key?('config')
+        section.merge! section.delete('config') if section.is_a?(Hash) && section.key?('config')
       end
     end
   end
 
   private
 
-  def to_hash_from_indifferent(v)
-    case v
-      when Hash
-        v.stringify_keys.to_hash.tap do |h|
-          h.each { |k, v| h[k] = to_hash_from_indifferent(v) if Hash === v || Array === v }
-        end
-      when Array
-        v.map { |e| to_hash_from_indifferent e }
-      else
-        v
+  def to_hash_from_indifferent(value)
+    case value
+    when Hash
+      value.stringify_keys.to_hash.tap do |h|
+        h.each { |k, v| h[k] = to_hash_from_indifferent(v) if v.is_a?(Hash) || v.is_a?(Array) }
+      end
+    when Array
+      value.map { |e| to_hash_from_indifferent e }
+    else
+      value
     end
   end
 end