.rubocop.yml in hyrax-3.0.0.pre.rc1 vs .rubocop.yml in hyrax-3.0.0.pre.rc2

- old
+ new

@@ -1,12 +1,13 @@ +inherit_from: + - .rubocop_fixme.yml + inherit_gem: bixby: bixby_default.yml -inherit_from: .rubocop_fixme.yml - AllCops: - TargetRubyVersion: 2.3 + TargetRubyVersion: 2.4 DisplayCopNames: true Exclude: - 'db/**/*' - 'script/**/*' - 'spec/test_app_templates/**/*' @@ -15,10 +16,14 @@ Lint/ImplicitStringConcatenation: Exclude: - 'lib/generators/hyrax/**/*' +Rails/Output: + Exclude: + - 'lib/generators/**/*' + Metrics/BlockLength: ExcludedMethods: ['included'] Exclude: - 'hyrax.gemspec' - 'app/models/concerns/hyrax/content_block_behavior.rb' @@ -30,14 +35,10 @@ - 'lib/generators/hyrax/templates/config/initializers/simple_form_bootstrap.rb' - 'lib/hyrax/rails/routes.rb' - 'lib/tasks/*.rake' - 'spec/**/*.rb' -# Naming/FileName: # https://github.com/bbatsov/rubocop/issues/2973 -# Exclude: -# - 'Gemfile' - Style/AsciiComments: Enabled: false Style/CollectionMethods: PreferredMethods: @@ -45,44 +46,28 @@ collect!: 'map!' inject: 'reduce' detect: 'find' find_all: 'select' -# disable frozen string literal comment. We can't safely introduce this -# system-wide until a major version because it freezes strings that downstream -# users might be mutating. Please use the frozen string literal pragma on new -# files -Style/FrozenStringLiteralComment: - Enabled: false - -Style/MethodMissing: - Exclude: - - 'app/models/concerns/hyrax/file_set/characterization.rb' - -Style/NumericPredicate: - Exclude: - - 'app/controllers/hyrax/file_sets_controller.rb' - Style/SymbolArray: Enabled: false Style/ClassAndModuleChildren: Enabled: false Style/SingleLineBlockParams: Enabled: false -Style/ZeroLengthPredicate: - Exclude: - - 'app/controllers/hyrax/file_sets_controller.rb' - Rails/ApplicationJob: Enabled: false Rails/ApplicationRecord: Enabled: false +Rails/RakeEnvironment: + Enabled: false + # We define custom methods like `find_by_user_key`, # `find_by_created_date`, etc Rails/DynamicFindBy: Enabled: false @@ -118,13 +103,9 @@ # # By default RSpec/MessageSpies has the following: # # Prefer have_received for setting message expectations. Setup form as a spy using allow or instance_spy. # # The default assumes EnforcedStyle is 'have_received'. Most of our specs are 'receive' RSpec/MessageSpies: Enabled: false - -RSpec/InstanceVariable: - Exclude: - - 'spec/services/hyrax/derivative_service_spec.rb' RSpec/ExpectActual: Enabled: false RSpec/LetSetup: