spec/henkei_spec.rb in henkei-2.4.0.1 vs spec/henkei_spec.rb in henkei-2.4.0.2

@@ -18,32 +18,32 @@
     ENV['JAVA_HOME'] = nil
   end
 
   describe '.read' do
     it 'reads text' do
-      text = Henkei.read :text, data
+      text = described_class.read :text, data
 
       expect(text).to include 'The quick brown fox jumped over the lazy cat.'
     end
 
     it 'reads metadata' do
-      metadata = Henkei.read :metadata, data
+      metadata = described_class.read :metadata, data
 
       expect(metadata['Content-Type']).to(
         eq 'application/vnd.openxmlformats-officedocument.wordprocessingml.document'
       )
     end
 
     it 'reads metadata values with colons as strings' do
       data = File.read 'spec/samples/sample-metadata-values-with-colons.doc'
-      metadata = Henkei.read :metadata, data
+      metadata = described_class.read :metadata, data
 
       expect(metadata['dc:title']).to eq 'problem: test'
     end
 
     it 'reads mimetype' do
-      mimetype = Henkei.read :mimetype, data
+      mimetype = described_class.read :mimetype, data
 
       expect(mimetype.content_type).to(
         eq 'application/vnd.openxmlformats-officedocument.wordprocessingml.document'
       )
       expect(mimetype.extensions).to include 'docx'
@@ -51,125 +51,122 @@
 
     context 'when passing in the `pipe-error.png` test file' do
       let(:data) { File.read 'spec/samples/pipe-error.png' }
 
       it 'returns an empty result' do
-        text = Henkei.read :text, data
+        text = described_class.read :text, data
 
         expect(text).to eq ''
       end
 
       unless ci?
         context 'when `include_ocr` is enabled' do
           it 'returns parsed plain text in the image' do
-            text = Henkei.read :text, data, include_ocr: true
+            text = described_class.read :text, data, include_ocr: true
 
             expect(text).to include <<~TEXT
               West Side
 
               Sea Island
-              PP
-
-              Richmond
             TEXT
           end
         end
       end
     end
   end
 
   describe '.new' do
     it 'requires parameters' do
-      expect { Henkei.new }.to raise_error ArgumentError
+      expect { described_class.new }.to raise_error ArgumentError
     end
 
     it 'accepts a root path' do
-      henkei = Henkei.new 'spec/samples/sample.pages'
+      henkei = described_class.new File.join(Henkei::GEM_PATH, 'spec/samples/sample.pages')
 
       expect(henkei).to be_path
       expect(henkei).not_to be_uri
       expect(henkei).not_to be_stream
     end
 
     it 'accepts a relative path' do
-      henkei = Henkei.new 'spec/samples/sample.pages'
+      henkei = described_class.new 'spec/samples/sample.pages'
 
       expect(henkei).to be_path
       expect(henkei).not_to be_uri
       expect(henkei).not_to be_stream
     end
 
     it 'accepts a path with spaces' do
-      henkei = Henkei.new 'spec/samples/sample filename with spaces.pages'
+      henkei = described_class.new 'spec/samples/sample filename with spaces.pages'
 
       expect(henkei).to be_path
       expect(henkei).not_to be_uri
       expect(henkei).not_to be_stream
     end
 
     it 'accepts a URI' do
-      henkei = Henkei.new 'http://svn.apache.org/repos/asf/poi/trunk/test-data/document/sample.docx'
+      henkei = described_class.new 'http://svn.apache.org/repos/asf/poi/trunk/test-data/document/sample.docx'
 
       expect(henkei).to be_uri
       expect(henkei).not_to be_path
       expect(henkei).not_to be_stream
     end
 
     it 'accepts a stream or object that can be read' do
       File.open 'spec/samples/sample.pages', 'r' do |file|
-        henkei = Henkei.new file
+        henkei = described_class.new file
 
         expect(henkei).to be_stream
         expect(henkei).not_to be_path
         expect(henkei).not_to be_uri
       end
     end
 
     it 'refuses a path to a missing file' do
-      expect { Henkei.new 'test/sample/missing.pages' }.to raise_error Errno::ENOENT
+      expect { described_class.new 'test/sample/missing.pages' }.to raise_error Errno::ENOENT
     end
 
     it 'refuses other objects' do
       [nil, 1, 1.1].each do |object|
-        expect { Henkei.new object }.to raise_error TypeError
+        expect { described_class.new object }.to raise_error TypeError
       end
     end
   end
 
   describe '.creation_date' do
-    let(:henkei) { Henkei.new 'spec/samples/sample.pages' }
+    let(:henkei) { described_class.new 'spec/samples/sample.pages' }
 
-    it 'should return Time' do
+    it 'returns a Time' do
       expect(henkei.creation_date).to be_a Time
     end
   end
 
   describe '.java' do
     specify 'with no specified JAVA_HOME' do
-      expect(Henkei.send(:java_path)).to eq 'java'
+      expect(described_class.send(:java_path)).to eq 'java'
     end
 
     specify 'with a specified JAVA_HOME' do
       ENV['JAVA_HOME'] = '/path/to/java/home'
 
-      expect(Henkei.send(:java_path)).to eq '/path/to/java/home/bin/java'
+      expect(described_class.send(:java_path)).to eq '/path/to/java/home/bin/java'
     end
   end
 
-  context 'initialized with a given path' do
-    let(:henkei) { Henkei.new 'spec/samples/sample.pages' }
+  context 'when initialized with a given path' do
+    let(:henkei) { described_class.new 'spec/samples/sample.pages' }
 
     specify '#text reads text' do
       expect(henkei.text).to include 'The quick brown fox jumped over the lazy cat.'
     end
 
     specify '#metadata reads metadata' do
       expect(henkei.metadata['Content-Type']).to eq %w[application/vnd.apple.pages application/vnd.apple.pages]
     end
 
     context 'when passing in the `pipe-error.png` test file' do
-      let(:henkei) { Henkei.new 'spec/samples/pipe-error.png' }
+      let(:henkei) { described_class.new 'spec/samples/pipe-error.png' }
 
       it '#text returns an empty result' do
         expect(henkei.text).to eq ''
       end
 
@@ -187,31 +184,28 @@
           it '#text returns plain text of parsed text in the image' do
             expect(henkei.text(include_ocr: true)).to include <<~TEXT
               West Side
 
               Sea Island
-              PP
-
-              Richmond
             TEXT
           end
 
           it '#html returns HTML of parsed text in the image' do
             expect(henkei.html(include_ocr: true)).to include '<meta name="tiff:ImageWidth" content="792"/>'
 
             html_body = Nokogiri::HTML(henkei.html(include_ocr: true)).at_xpath('//body')
-            ['Anmore', 'Coquitlam', 'West Side', 'Sea Island', 'Richmond', 'Steveston'].each do |location|
+            ['West Side', 'Sea Island', 'Richmond', 'Steveston'].each do |location|
               expect(html_body.text).to include location
             end
           end
         end
       end
     end
   end
 
-  context 'initialized with a given URI' do
-    let(:henkei) { Henkei.new 'http://svn.apache.org/repos/asf/poi/trunk/test-data/document/sample.docx' }
+  context 'when initialized with a given URI' do
+    let(:henkei) { described_class.new 'http://svn.apache.org/repos/asf/poi/trunk/test-data/document/sample.docx' }
 
     specify '#text reads text' do
       expect(henkei.text).to include 'Lorem ipsum dolor sit amet, consectetuer adipiscing elit.'
     end
 
@@ -220,12 +214,12 @@
         eq 'application/vnd.openxmlformats-officedocument.wordprocessingml.document'
       )
     end
   end
 
-  context 'initialized with a given stream' do
-    let(:henkei) { Henkei.new File.open('spec/samples/sample.pages', 'rb') }
+  context 'when initialized with a given stream' do
+    let(:henkei) { described_class.new File.open('spec/samples/sample.pages', 'rb') }
 
     specify '#text reads text' do
       expect(henkei.text).to include 'The quick brown fox jumped over the lazy cat.'
     end
 
@@ -233,10 +227,10 @@
       expect(henkei.metadata['Content-Type']).to eq %w[application/vnd.apple.pages application/vnd.apple.pages]
     end
   end
 
   context 'when source is a remote PDF' do
-    let(:henkei) { Henkei.new 'https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf' }
+    let(:henkei) { described_class.new 'https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf' }
 
     specify '#text reads text' do
       expect(henkei.text).to include 'Dummy PDF file'
     end