spec/features/integration_spec.rb in gush-0.4.1 vs spec/features/integration_spec.rb in gush-1.0.0

@@ -1,15 +1,16 @@
 require 'spec_helper'
+require 'pry'
 
 describe "Workflows" do
   context "when all jobs finish successfuly" do
     it "marks workflow as completed" do
       flow = TestWorkflow.create
-      flow.start!
+      perform_enqueued_jobs do
+        flow.start!
+      end
 
-      Gush::Worker.drain
-
       flow = flow.reload
       expect(flow).to be_finished
       expect(flow).to_not be_failed
     end
   end
@@ -18,43 +19,43 @@
     flow = TestWorkflow.create
     flow.start!
 
     expect(Gush::Worker).to have_jobs(flow.id, jobs_with_id(['Prepare']))
 
-    Gush::Worker.perform_one
+    perform_one
     expect(Gush::Worker).to have_jobs(flow.id, jobs_with_id(["FetchFirstJob", "FetchSecondJob"]))
 
-    Gush::Worker.perform_one
+    perform_one
     expect(Gush::Worker).to have_jobs(flow.id, jobs_with_id(["FetchSecondJob", "PersistFirstJob"]))
 
-    Gush::Worker.perform_one
+    perform_one
     expect(Gush::Worker).to have_jobs(flow.id, jobs_with_id(["PersistFirstJob"]))
 
-    Gush::Worker.perform_one
+    perform_one
     expect(Gush::Worker).to have_jobs(flow.id, jobs_with_id(["NormalizeJob"]))
 
-    Gush::Worker.perform_one
+    perform_one
 
-    expect(Gush::Worker.jobs).to be_empty
+    expect(ActiveJob::Base.queue_adapter.enqueued_jobs).to be_empty
   end
 
   it "passes payloads down the workflow" do
     class UpcaseJob < Gush::Job
-      def work
+      def perform
         output params[:input].upcase
       end
     end
 
     class PrefixJob < Gush::Job
-      def work
+      def perform
         output params[:prefix].capitalize
       end
     end
 
     class PrependJob < Gush::Job
-      def work
-        string = "#{payloads['PrefixJob'].first}: #{payloads['UpcaseJob'].first}"
+      def perform
+        string = "#{payloads.find { |j| j[:class] == 'PrefixJob'}[:output]}: #{payloads.find { |j| j[:class] == 'UpcaseJob'}[:output]}"
         output string
       end
     end
 
     class PayloadWorkflow < Gush::Workflow
@@ -66,32 +67,32 @@
     end
 
     flow = PayloadWorkflow.create
     flow.start!
 
-    Gush::Worker.perform_one
+    perform_one
     expect(flow.reload.find_job("UpcaseJob").output_payload).to eq("SOME TEXT")
 
-    Gush::Worker.perform_one
+    perform_one
     expect(flow.reload.find_job("PrefixJob").output_payload).to eq("A prefix")
 
-    Gush::Worker.perform_one
+    perform_one
     expect(flow.reload.find_job("PrependJob").output_payload).to eq("A prefix: SOME TEXT")
 
 
   end
 
   it "passes payloads from workflow that runs multiple same class jobs with nameized payloads" do
     class RepetitiveJob < Gush::Job
-      def work
+      def perform
         output params[:input]
       end
     end
 
     class SummaryJob < Gush::Job
-      def work
-        output payloads['RepetitiveJob']
+      def perform
+        output payloads.map { |payload| payload[:output] }
       end
     end
 
     class PayloadWorkflow < Gush::Workflow
       def configure
@@ -104,19 +105,57 @@
     end
 
     flow = PayloadWorkflow.create
     flow.start!
 
-    Gush::Worker.perform_one
+    perform_one
     expect(flow.reload.find_job(flow.jobs[0].name).output_payload).to eq('first')
 
-    Gush::Worker.perform_one
+    perform_one
     expect(flow.reload.find_job(flow.jobs[1].name).output_payload).to eq('second')
 
-    Gush::Worker.perform_one
+    perform_one
     expect(flow.reload.find_job(flow.jobs[2].name).output_payload).to eq('third')
 
-    Gush::Worker.perform_one
+    perform_one
     expect(flow.reload.find_job(flow.jobs[3].name).output_payload).to eq(%w(first second third))
+  end
 
+  it "does not execute `configure` on each job for huge workflows" do
+    INTERNAL_SPY = double('spy')
+    INTERNAL_CONFIGURE_SPY = double('configure spy')
+    expect(INTERNAL_SPY).to receive(:some_method).exactly(110).times
+
+    # One time when persisting, second time when reloading in the spec
+    expect(INTERNAL_CONFIGURE_SPY).to receive(:some_method).exactly(2).times
+
+    class SimpleJob < Gush::Job
+      def perform
+        INTERNAL_SPY.some_method
+      end
+    end
+
+    class GiganticWorkflow < Gush::Workflow
+      def configure
+        INTERNAL_CONFIGURE_SPY.some_method
+
+        10.times do
+          main = run(SimpleJob)
+          10.times do
+            run(SimpleJob, after: main)
+          end
+        end
+      end
+    end
+
+    flow = GiganticWorkflow.create
+    flow.start!
+
+    110.times do
+      perform_one
+    end
+
+    flow = flow.reload
+    expect(flow).to be_finished
+    expect(flow).to_not be_failed
   end
 end