lib/gurke/cli.rb in gurke-2.4.2 vs lib/gurke/cli.rb in gurke-3.0.0

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 require 'trollop'
 
 module Gurke
   class CLI
     #
@@ -12,83 +14,89 @@
     rescue Trollop::VersionNeeded
       print_version && exit
     rescue Trollop::HelpNeeded
       print_help && exit
     rescue Trollop::CommandlineError => e
-      $stderr.puts "Error: #{e}"
-      $stderr.puts "Run with `-h' for more information on available arguments."
+      warn "Error: #{e}"
+      warn "Run with `-h' for more information on available arguments."
       exit 255
     end
 
     def call(options, files)
       if File.exist?(Gurke.root.join('gurke.rb'))
         require File.expand_path(Gurke.root.join('gurke.rb'))
       end
 
-      options[:require].each do |r|
-        Dir[r].each{|f| require File.expand_path(f) }
-      end if options[:require].any?
+      if options[:require].any?
+        options[:require].each do |r|
+          Dir[r].each {|f| require File.expand_path(f) }
+        end
+      end
 
       files = expand_files files, options
 
       runner = if options[:drb_server]
-        Runner::DRbServer
-      elsif options[:drb]
-        Runner::DRbClient
-      else
-        Runner::LocalRunner
-      end.new Gurke.config, options
+                 Runner::DRbServer
+               elsif options[:drb]
+                 Runner::DRbClient
+               else
+                 Runner::LocalRunner
+               end.new(Gurke.config, options)
 
       Kernel.exit runner.run files
     end
 
     def print_version
-      $stdout.puts <<-EOF.gsub(/^ {8}/, '')
+      $stdout.puts <<~VSTR
         gurke v#{Gurke::VERSION}
-      EOF
+      VSTR
     end
 
     def print_help
       parser.educate($stdout)
     end
 
-    # rubocop:disable MethodLength
     def parser
       @parser ||= Trollop::Parser.new do
         opt :help, 'Print this help.'
         opt :version, 'Show program version information.'
         opt :backtrace, 'Show full error backtraces.'
         opt :formatter, 'Select a special formatter as reporter', \
-            default: 'default'
+          default: 'compact'
         opt :pattern, 'File pattern matching feature files to be run.',
-            default: 'features/**/*.feature'
-        opt :require, 'Files matching this pattern will be required after'\
+          default: 'features/**/*.feature'
+        opt :require, 'Files matching this pattern will be required after' \
                       'loading environment but before running features.',
-            default: ['features/steps/**/*.rb',
-                      'features/support/steps/**/*.rb'],
-            multi: true
-        opt :tags, 'Only run features and scenarios matching given tag '\
+          default: ['features/steps/**/*.rb',
+                    'features/support/steps/**/*.rb'],
+          multi: true
+        opt :tags, 'Only run features and scenarios matching given tag ' \
                    'filtering expression. TODO: Description.',
-            default: ['~wip'],
-            multi: true
+          default: ['~wip'],
+          multi: true
         opt :drb_server, 'Run gurke DRb server. (experimental)', short: :none
-        opt :drb, 'Run features on already started DRb server. (experimental)', short: :none
+        opt :drb, 'Run features on already started DRb server. (experimental)',
+          short: :none
       end
     end
 
     private
+
     def expand_files(files, options)
       files = Dir[options[:pattern].to_s] if files.empty? && options[:pattern]
-      files.inject([]) do |memo, input|
+      files.each_with_object([]) do |input, memo|
         if File.directory? input
           Dir[input + '/**/*'].each do |file_in_dir|
-            next if options[:pattern] && !File.fnmatch?(options[:pattern], file_in_dir)
+            if options[:pattern] &&
+               !File.fnmatch?(options[:pattern], file_in_dir)
+              next
+            end
+
             memo << File.expand_path(file_in_dir)
           end
         else
           memo << File.expand_path(input)
         end
-        memo
       end
     end
   end
 end