rest_helper_spec.rb in groupdocs-0.2

- old
+ new

@@ -37,10 +37,17 @@
       lambda do
         subject.send(:prepare_request)
       end.should change { subject.options[:method] }.to(:get)
     end
 
+    it 'converts HTTP method to symbol' do
+      subject.options[:method] = 'GET'
+      lambda do
+        subject.send(:prepare_request)
+      end.should change { subject.options[:method] }.to(:get)
+    end
+
     it 'coverts request body to JSON' do
       subject.options[:method] = :POST
       subject.options[:request_body] = { body: 'test' }
       lambda do
         subject.send(:prepare_request)
@@ -86,11 +93,11 @@
       end
     end
 
     it 'raises error if incorrect method has been passed' do
       subject.options[:method] = :TEST
-      -> { subject.send(:send_request) }.should raise_error(GroupDocs::Errors::UnsupportedMethodError)
+      -> { subject.send(:send_request) }.should raise_error(GroupDocs::UnsupportedMethodError)
     end
 
     it 'saves response' do
       mock_api_server('{"status": "Ok"}')
       subject.options[:method] = :get
@@ -130,58 +137,12 @@
   describe '#raise_bad_request_error' do
     let(:json) do
       { status: 'Failed', error_message: 'The source path is not found.' }
     end
 
-    it 'raises error' do
+    it 'raises error with message from response' do
       lambda do
         subject.send(:raise_bad_request_error, json)
-      end.should raise_error(GroupDocs::Errors::BadResponseError)
-    end
-
-    it 'shows "Bad response!" message' do
-      lambda do
-        subject.send(:raise_bad_request_error, json)
-      end.should raise_error(message = /Bad response!/)
-    end
-
-    it 'contains information about request method' do
-      subject.options[:method] = :get
-      lambda do
-        subject.send(:raise_bad_request_error, json)
-      end.should raise_error(message = /Request method: GET/)
-    end
-
-    it 'contains information about request URL' do
-      subject.options[:path] = '/folders'
-      lambda do
-        subject.send(:raise_bad_request_error, json)
-      end.should raise_error(message = %r(Request URL: https?://(.+)/folders))
-    end
-
-    it 'contains information about request body' do
-      subject.options[:request_body] = '{"test": 123}'
-      lambda do
-        subject.send(:raise_bad_request_error, json)
-      end.should raise_error(message = /Request body: {"test": 123}/)
-    end
-
-    it 'contains information about response status' do
-      lambda do
-        subject.send(:raise_bad_request_error, json)
-      end.should raise_error(message = /Status: Failed/)
-    end
-
-    it 'contains information about error message' do
-      lambda do
-        subject.send(:raise_bad_request_error, json)
-      end.should raise_error(message = /Error message: The source path is not found./)
-    end
-
-    it 'contains information about response body' do
-      mock_response('{"status": "Failed", "error_message": "The source path is not found."}')
-      lambda do
-        subject.send(:raise_bad_request_error, json)
-      end.should raise_error(message = /Response body: {"status": "Failed", "error_message": "The source path is not found."}/)
+      end.should raise_error(GroupDocs::BadResponseError, 'The source path is not found.')
     end
   end
 end