spec/grape/validations/validators/allow_blank_spec.rb in grape-0.14.0 vs spec/grape/validations/validators/allow_blank_spec.rb in grape-0.15.0

@@ -118,10 +118,127 @@
           optional :user, type: Hash do
             optional :name, allow_blank: false
           end
         end
         get '/disallow_string_value_in_an_optional_hash_group'
+
+        resources :custom_message do
+          params do
+            requires :name, allow_blank: { value: false, message: 'has no value' }
+          end
+          get
+
+          params do
+            optional :name, allow_blank: { value: false, message: 'has no value' }
+          end
+          get '/disallow_blank_optional_param'
+
+          params do
+            requires :name, allow_blank: true
+          end
+          get '/allow_blank'
+
+          params do
+            requires :val, type: DateTime, allow_blank: true
+          end
+          get '/allow_datetime_blank'
+
+          params do
+            requires :val, type: DateTime, allow_blank: { value: false, message: 'has no value' }
+          end
+          get '/disallow_datetime_blank'
+
+          params do
+            requires :val, type: DateTime
+          end
+          get '/default_allow_datetime_blank'
+
+          params do
+            requires :val, type: Date, allow_blank: true
+          end
+          get '/allow_date_blank'
+
+          params do
+            requires :val, type: Integer, allow_blank: true
+          end
+          get '/allow_integer_blank'
+
+          params do
+            requires :val, type: Float, allow_blank: true
+          end
+          get '/allow_float_blank'
+
+          params do
+            requires :val, type: Fixnum, allow_blank: true
+          end
+          get '/allow_fixnum_blank'
+
+          params do
+            requires :val, type: Symbol, allow_blank: true
+          end
+          get '/allow_symbol_blank'
+
+          params do
+            requires :val, type: Boolean, allow_blank: true
+          end
+          get '/allow_boolean_blank'
+
+          params do
+            requires :val, type: Boolean, allow_blank: { value: false, message: 'has no value' }
+          end
+          get '/disallow_boolean_blank'
+
+          params do
+            optional :user, type: Hash do
+              requires :name, allow_blank: { value: false, message: 'has no value' }
+            end
+          end
+          get '/disallow_blank_required_param_in_an_optional_group'
+
+          params do
+            optional :user, type: Hash do
+              requires :name, type: Date, allow_blank: true
+            end
+          end
+          get '/allow_blank_date_param_in_an_optional_group'
+
+          params do
+            optional :user, type: Hash do
+              optional :name, allow_blank: { value: false, message: 'has no value' }
+              requires :age
+            end
+          end
+          get '/disallow_blank_optional_param_in_an_optional_group'
+
+          params do
+            requires :user, type: Hash do
+              requires :name, allow_blank: { value: false, message: 'has no value' }
+            end
+          end
+          get '/disallow_blank_required_param_in_a_required_group'
+
+          params do
+            requires :user, type: Hash do
+              requires :name, allow_blank: { value: false, message: 'has no value' }
+            end
+          end
+          get '/disallow_string_value_in_a_required_hash_group'
+
+          params do
+            requires :user, type: Hash do
+              optional :name, allow_blank: { value: false, message: 'has no value' }
+            end
+          end
+          get '/disallow_blank_optional_param_in_a_required_group'
+
+          params do
+            optional :user, type: Hash do
+              optional :name, allow_blank: { value: false, message: 'has no value' }
+            end
+          end
+          get '/disallow_string_value_in_an_optional_hash_group'
+        end
       end
     end
   end
 
   def app
@@ -149,9 +266,169 @@
     end
 
     it 'refuses nil' do
       get '/', name: nil
       expect(last_response.status).to eq(400)
+    end
+  end
+
+  context 'custom validation message' do
+    context 'with invalid input' do
+      it 'refuses empty string' do
+        get '/custom_message', name: ''
+        expect(last_response.body).to eq('{"error":"name has no value"}')
+      end
+      it 'refuses empty string for an optional param' do
+        get '/custom_message/disallow_blank_optional_param', name: ''
+        expect(last_response.body).to eq('{"error":"name has no value"}')
+      end
+      it 'refuses only whitespaces' do
+        get '/custom_message', name: '   '
+        expect(last_response.body).to eq('{"error":"name has no value"}')
+
+        get '/custom_message', name: "  \n "
+        expect(last_response.body).to eq('{"error":"name has no value"}')
+
+        get '/custom_message', name: "\n"
+        expect(last_response.body).to eq('{"error":"name has no value"}')
+      end
+
+      it 'refuses nil' do
+        get '/custom_message', name: nil
+        expect(last_response.body).to eq('{"error":"name has no value"}')
+      end
+    end
+
+    context 'with valid input' do
+      it 'accepts valid input' do
+        get '/custom_message', name: 'bob'
+        expect(last_response.status).to eq(200)
+      end
+
+      it 'accepts empty input when allow_blank is false' do
+        get '/custom_message/allow_blank', name: ''
+        expect(last_response.status).to eq(200)
+      end
+
+      it 'accepts empty input' do
+        get '/custom_message/default_allow_datetime_blank', val: ''
+        expect(last_response.status).to eq(200)
+      end
+
+      it 'accepts empty when datetime allow_blank' do
+        get '/custom_message/allow_datetime_blank', val: ''
+        expect(last_response.status).to eq(200)
+      end
+
+      it 'accepts empty when date allow_blank' do
+        get '/custom_message/allow_date_blank', val: ''
+        expect(last_response.status).to eq(200)
+      end
+
+      context 'allow_blank when Numeric' do
+        it 'accepts empty when integer allow_blank' do
+          get '/custom_message/allow_integer_blank', val: ''
+          expect(last_response.status).to eq(200)
+        end
+
+        it 'accepts empty when float allow_blank' do
+          get '/custom_message/allow_float_blank', val: ''
+          expect(last_response.status).to eq(200)
+        end
+
+        it 'accepts empty when fixnum allow_blank' do
+          get '/custom_message/allow_fixnum_blank', val: ''
+          expect(last_response.status).to eq(200)
+        end
+      end
+
+      it 'accepts empty when symbol allow_blank' do
+        get '/custom_message/allow_symbol_blank', val: ''
+        expect(last_response.status).to eq(200)
+      end
+
+      it 'accepts empty when boolean allow_blank' do
+        get '/custom_message/allow_boolean_blank', val: ''
+        expect(last_response.status).to eq(200)
+      end
+
+      it 'accepts false when boolean allow_blank' do
+        get '/custom_message/disallow_boolean_blank', val: false
+        expect(last_response.status).to eq(200)
+      end
+    end
+
+    context 'in an optional group' do
+      context 'as a required param' do
+        it 'accepts a missing group, even with a disallwed blank param' do
+          get '/custom_message/disallow_blank_required_param_in_an_optional_group'
+          expect(last_response.status).to eq(200)
+        end
+
+        it 'accepts a nested missing date value' do
+          get '/custom_message/allow_blank_date_param_in_an_optional_group', user: { name: '' }
+          expect(last_response.status).to eq(200)
+        end
+
+        it 'refuses a blank value in an existing group' do
+          get '/custom_message/disallow_blank_required_param_in_an_optional_group', user: { name: '' }
+          expect(last_response.status).to eq(400)
+          expect(last_response.body).to eq('{"error":"user[name] has no value"}')
+        end
+      end
+
+      context 'as an optional param' do
+        it 'accepts a missing group, even with a disallwed blank param' do
+          get '/custom_message/disallow_blank_optional_param_in_an_optional_group'
+          expect(last_response.status).to eq(200)
+        end
+
+        it 'accepts a nested missing optional value' do
+          get '/custom_message/disallow_blank_optional_param_in_an_optional_group', user: { age: '29' }
+          expect(last_response.status).to eq(200)
+        end
+
+        it 'refuses a blank existing value in an existing scope' do
+          get '/custom_message/disallow_blank_optional_param_in_an_optional_group', user: { age: '29', name: '' }
+          expect(last_response.status).to eq(400)
+          expect(last_response.body).to eq('{"error":"user[name] has no value"}')
+        end
+      end
+    end
+
+    context 'in a required group' do
+      context 'as a required param' do
+        it 'refuses a blank value in a required existing group' do
+          get '/custom_message/disallow_blank_required_param_in_a_required_group', user: { name: '' }
+          expect(last_response.status).to eq(400)
+          expect(last_response.body).to eq('{"error":"user[name] has no value"}')
+        end
+
+        it 'refuses a string value in a required hash group' do
+          get '/custom_message/disallow_string_value_in_a_required_hash_group', user: ''
+          expect(last_response.status).to eq(400)
+          expect(last_response.body).to eq('{"error":"user is invalid, user[name] is missing"}')
+        end
+      end
+
+      context 'as an optional param' do
+        it 'accepts a nested missing value' do
+          get '/custom_message/disallow_blank_optional_param_in_a_required_group', user: { age: '29' }
+          expect(last_response.status).to eq(200)
+        end
+
+        it 'refuses a blank existing value in an existing scope' do
+          get '/custom_message/disallow_blank_optional_param_in_a_required_group', user: { age: '29', name: '' }
+          expect(last_response.status).to eq(400)
+          expect(last_response.body).to eq('{"error":"user[name] has no value"}')
+        end
+
+        it 'refuses a string value in an optional hash group' do
+          get '/custom_message/disallow_string_value_in_an_optional_hash_group', user: ''
+          expect(last_response.status).to eq(400)
+          expect(last_response.body).to eq('{"error":"user is invalid"}')
+        end
+      end
     end
   end
 
   context 'valid input' do
     it 'accepts valid input' do