spec/grape/middleware/versioner/param_spec.rb in grape-0.2.3 vs spec/grape/middleware/versioner/param_spec.rb in grape-0.2.4

- old
+ new

@@ -3,51 +3,51 @@ describe Grape::Middleware::Versioner::Param do let(:app) { lambda{|env| [200, env, env['api.version']]} } subject { Grape::Middleware::Versioner::Param.new(app, @options || {}) } - it 'should set the API version based on the default param (apiver)' do + it 'sets the API version based on the default param (apiver)' do env = Rack::MockRequest.env_for("/awesome", {:params => {"apiver" => "v1"}}) subject.call(env)[1]["api.version"].should == 'v1' end - it 'should cut (only) the version out of the params', :focus => true do + it 'cuts (only) the version out of the params', :focus => true do env = Rack::MockRequest.env_for("/awesome", {:params => {"apiver" => "v1", "other_param" => "5"}}) subject.call(env)[1]['rack.request.query_hash']["apiver"].should be_nil subject.call(env)[1]['rack.request.query_hash']["other_param"].should == "5" end - it 'should provide a nil version if no version is given' do + it 'provides a nil version if no version is given' do env = Rack::MockRequest.env_for("/") subject.call(env).last.should be_nil end context 'with specified parameter name' do before{ @options = {:parameter => ['v']}} - it 'should set the API version based on the custom parameter name' do + it 'sets the API version based on the custom parameter name' do env = Rack::MockRequest.env_for("/awesome", {:params => {"v" => "v1"}}) s = subject.call(env)[1]["api.version"] == "v1" end - it 'should not set the API version based on the default param' do + it 'does not set the API version based on the default param' do env = Rack::MockRequest.env_for("/awesome", {:params => {"apiver" => "v1"}}) s = subject.call(env)[1]["api.version"] == nil end end context 'with specified versions' do before{ @options = {:versions => ['v1', 'v2']}} - it 'should throw an error if a non-allowed version is specified' do + it 'throws an error if a non-allowed version is specified' do env = Rack::MockRequest.env_for("/awesome", {:params => {"apiver" => "v3"}}) catch(:error){subject.call(env)}[:status].should == 404 end - it 'should allow versions that have been specified' do + it 'allows versions that have been specified' do env = Rack::MockRequest.env_for("/awesome", {:params => {"apiver" => "v1"}}) subject.call(env)[1]["api.version"].should == 'v1' end end - it 'should return a 200 when no version is set (matches the first version found)' do + it 'returns a 200 when no version is set (matches the first version found)' do @options = { :versions => ['v1'], :version_options => {:using => :header} } env = Rack::MockRequest.env_for("/awesome", {:params => {}}) \ No newline at end of file