client.rb in google-cloud-app_engine-v1-1.1.0

- old
+ new

@@ -162,14 +162,34 @@
                 endpoint: @config.endpoint,
                 endpoint_template: DEFAULT_ENDPOINT_TEMPLATE,
                 universe_domain: @config.universe_domain,
                 channel_args: @config.channel_args,
                 interceptors: @config.interceptors,
-                channel_pool_config: @config.channel_pool
+                channel_pool_config: @config.channel_pool,
+                logger: @config.logger
               )
+
+              @firewall_stub.stub_logger&.info do |entry|
+                entry.set_system_name
+                entry.set_service
+                entry.message = "Created client for #{entry.service}"
+                entry.set_credentials_fields credentials
+                entry.set "customEndpoint", @config.endpoint if @config.endpoint
+                entry.set "defaultTimeout", @config.timeout if @config.timeout
+                entry.set "quotaProject", @quota_project_id if @quota_project_id
+              end
             end
 
+            ##
+            # The logger used for request/response debug logging.
+            #
+            # @return [Logger]
+            #
+            def logger
+              @firewall_stub.logger
+            end
+
             # Service calls
 
             ##
             # Lists the firewall rules of an application.
             #
@@ -262,11 +282,11 @@
                                      retry_policy: @config.retry_policy
 
               @firewall_stub.call_rpc :list_ingress_rules, request, options: options do |response, operation|
                 response = ::Gapic::PagedEnumerable.new @firewall_stub, :list_ingress_rules, request, response, operation, options
                 yield response, operation if block_given?
-                return response
+                throw :response, response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
             end
 
@@ -355,11 +375,10 @@
                                      metadata:     @config.metadata,
                                      retry_policy: @config.retry_policy
 
               @firewall_stub.call_rpc :batch_update_ingress_rules, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
             end
 
@@ -453,11 +472,10 @@
                                      metadata:     @config.metadata,
                                      retry_policy: @config.retry_policy
 
               @firewall_stub.call_rpc :create_ingress_rule, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
             end
 
@@ -540,11 +558,10 @@
                                      metadata:     @config.metadata,
                                      retry_policy: @config.retry_policy
 
               @firewall_stub.call_rpc :get_ingress_rule, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
             end
 
@@ -631,11 +648,10 @@
                                      metadata:     @config.metadata,
                                      retry_policy: @config.retry_policy
 
               @firewall_stub.call_rpc :update_ingress_rule, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
             end
 
@@ -718,11 +734,10 @@
                                      metadata:     @config.metadata,
                                      retry_policy: @config.retry_policy
 
               @firewall_stub.call_rpc :delete_ingress_rule, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
             end
 
@@ -807,10 +822,15 @@
             # @!attribute [rw] universe_domain
             #   The universe domain within which to make requests. This determines the
             #   default endpoint URL. The default value of nil uses the environment
             #   universe (usually the default "googleapis.com" universe).
             #   @return [::String,nil]
+            # @!attribute [rw] logger
+            #   A custom logger to use for request/response debug logging, or the value
+            #   `:default` (the default) to construct a default logger, or `nil` to
+            #   explicitly disable logging.
+            #   @return [::Logger,:default,nil]
             #
             class Configuration
               extend ::Gapic::Config
 
               # @private
@@ -831,9 +851,10 @@
               config_attr :timeout,       nil, ::Numeric, nil
               config_attr :metadata,      nil, ::Hash, nil
               config_attr :retry_policy,  nil, ::Hash, ::Proc, nil
               config_attr :quota_project, nil, ::String, nil
               config_attr :universe_domain, nil, ::String, nil
+              config_attr :logger, :default, ::Logger, nil, :default
 
               # @private
               def initialize parent_config = nil
                 @parent_config = parent_config unless parent_config.nil?
 