report_definition.rb in gooddata-0.6.52

- old
+ new

@@ -14,11 +14,14 @@
   class ReportDefinition < GoodData::MdObject
     class << self
       # Method intended to get all objects of that type in a specified project
       #
       # @param options [Hash] the options hash
-      # @option options [Boolean] :full if passed true the subclass can decide to pull in full objects. This is desirable from the usability POV but unfortunately has negative impact on performance so it is not the default
+      # @option options [Boolean] :full if passed true the subclass can decide
+      # to pull in full objects. This is desirable from the usability POV
+      # but unfortunately has negative impact on performance so it is not
+      # the default.
       # @return [Array<GoodData::MdObject> | Array<Hash>] Return the appropriate metadata objects or their representation
       def all(options = { :client => GoodData.connection, :project => GoodData.project })
         query('reportDefinition', ReportDefinition, options)
       end
 
@@ -48,11 +51,13 @@
             'uri' => attrib.uri
           }
         }
       end
 
-      # Method creates the list of filter representaion suitable for posting on the api. It can currently recognize 2 types of filters. Variable filters and attribute filters. Method for internal usage
+      # Method creates the list of filter representaion suitable for posting on
+      # the api. It can currently recognize 2 types of filters. Variable filters
+      # and attribute filters. Method for internal usage.
       #
       # @param filters [GoodData::Variable|Array<Array>]
       # @param options [Hash] the options hash
       # @return [Array<Hash>] Returns the structure that is stored internally in the report definition and later psted on the API
       def create_filters_part(filters, options = {})
@@ -241,18 +246,20 @@
 
     def filters
       content['filters'].map { |f| f['expression'] }
     end
 
-    # Method used for replacing values in their state according to mapping. Can be used to replace any values but it is typically used to replace the URIs. Returns a new object of the same type.
+    # Method used for replacing values in their state according to mapping.
+    # Can be used to replace any values but it is typically used to replace
+    # the URIs. Returns a new object of the same type.
     #
     # @param [Array<Array>]Mapping specifying what should be exchanged for what. As mapping should be used output of GoodData::Helpers.prepare_mapping.
     # @return [GoodData::ReportDefinition]
     def replace(mapping)
       x = GoodData::MdObject.replace_quoted(self, mapping)
       x = GoodData::MdObject.replace_bracketed(x, mapping)
       vals = GoodData::MdObject.find_replaceable_values(self, mapping)
-      GoodData::MdObject.replace_quoted(x, vals)
+      x = GoodData::MdObject.replace_quoted(x, vals)
       GoodData::MdObject.replace_bracketed(x, vals)
     end
 
     # Return true if the report definition is a table
     #