lib/good_job/logging.rb in good_job-0.2.0 vs lib/good_job/logging.rb in good_job-0.2.1

@@ -1,59 +1,57 @@
-module GoodJob::Logging
-  extend ActiveSupport::Concern
+module GoodJob
+  module Logging
+    extend ActiveSupport::Concern
 
-  included do
-    cattr_accessor :logger, default: ActiveSupport::TaggedLogging.new(ActiveSupport::Logger.new(STDOUT))
+    included do
+      cattr_accessor :logger, default: ActiveSupport::TaggedLogging.new(ActiveSupport::Logger.new(STDOUT))
 
-    def self.tag_logger(*tags)
-      if logger.respond_to?(:tagged)
-        tags.unshift "GoodJob" unless logger.formatter.current_tags.include?("GoodJob")
-        logger.tagged(*tags) { yield }
-      else
-        yield
+      def self.tag_logger(*tags)
+        if logger.respond_to?(:tagged)
+          tags.unshift "GoodJob" unless logger.formatter.current_tags.include?("GoodJob")
+          logger.tagged(*tags) { yield }
+        else
+          yield
+        end
       end
     end
-  end
 
-  class LogSubscriber < ActiveSupport::LogSubscriber
-    def create(event)
-      good_job = event.payload[:good_job]
+    class LogSubscriber < ActiveSupport::LogSubscriber
+      def create(event)
+        good_job = event.payload[:good_job]
 
-      info do
-        "Created GoodJob resource with id #{good_job.id}"
+        info do
+          "Created GoodJob resource with id #{good_job.id}"
+        end
       end
-    end
 
-    def timer_task_finished(event)
-      result = event.payload[:result]
-      exception = event.payload[:error]
+      def timer_task_finished(event)
+        exception = event.payload[:error]
+        return unless exception
 
-      if exception
         error do
           "ERROR: #{exception}\n #{exception.backtrace}"
         end
       end
-    end
 
-    def job_finished(event)
-      result = event.payload[:result]
-      exception = event.payload[:error]
+      def job_finished(event)
+        exception = event.payload[:error]
+        return unless exception
 
-      if exception
         error do
           "ERROR: #{exception}\n #{exception.backtrace}"
         end
       end
-    end
 
-    private
+      private
 
-    def logger
-      GoodJob.logger
-    end
+      def logger
+        GoodJob.logger
+      end
 
-    def thread_name
-      Thread.current.name || Thread.current.object_id
+      def thread_name
+        Thread.current.name || Thread.current.object_id
+      end
     end
   end
 end
 
 GoodJob::Logging::LogSubscriber.attach_to :good_job