lib/good_job/configuration.rb in good_job-4.1.1 vs lib/good_job/configuration.rb in good_job-4.2.0
- old
+ new
@@ -33,12 +33,10 @@
DEFAULT_DASHBOARD_DEFAULT_LOCALE = :en
# Default Dashboard Live Poll button enabled
DEFAULT_DASHBOARD_LIVE_POLL_ENABLED = true
# Default enqueue_after_transaction_commit
DEFAULT_ENQUEUE_AFTER_TRANSACTION_COMMIT = false
- # Default smaller_number_is_higher_priority
- DEFAULT_SMALLER_NUMBER_IS_HIGHER_PRIORITY = true
def self.validate_execution_mode(execution_mode)
raise ArgumentError, "GoodJob execution mode must be one of #{EXECUTION_MODES.join(', ')}. It was '#{execution_mode}' which is not valid." unless execution_mode.in?(EXECUTION_MODES)
end
@@ -345,16 +343,10 @@
return ActiveModel::Type::Boolean.new.cast(env['GOOD_JOB_ENABLE_LISTEN_NOTIFY']) unless env['GOOD_JOB_ENABLE_LISTEN_NOTIFY'].nil?
DEFAULT_ENABLE_LISTEN_NOTIFY
end
- def smaller_number_is_higher_priority
- return rails_config[:smaller_number_is_higher_priority] unless rails_config[:smaller_number_is_higher_priority].nil?
-
- DEFAULT_SMALLER_NUMBER_IS_HIGHER_PRIORITY
- end
-
def dashboard_default_locale
rails_config[:dashboard_default_locale] || DEFAULT_DASHBOARD_DEFAULT_LOCALE
end
def dashboard_live_poll_enabled
@@ -381,9 +373,19 @@
self_caller.grep(%r{config.ru}).any? || # EXAMPLE: config.ru:3:in `block in <main>' OR config.ru:3:in `new_from_string'
self_caller.grep(%r{puma/request}).any? || # EXAMPLE: puma-5.6.4/lib/puma/request.rb:76:in `handle_request'
self_caller.grep(%{/rack/handler/}).any? || # EXAMPLE: iodine-0.7.44/lib/rack/handler/iodine.rb:13:in `start'
(Concurrent.on_jruby? && self_caller.grep(%r{jruby/rack/rails_booter}).any?) # EXAMPLE: uri:classloader:/jruby/rack/rails_booter.rb:83:in `load_environment'
end || false
+ end
+
+ # Whether to take an advisory lock on the process record in the notifier reactor.
+ # @return [Boolean]
+ def advisory_lock_heartbeat
+ return options[:advisory_lock_heartbeat] unless options[:advisory_lock_heartbeat].nil?
+ return rails_config[:advisory_lock_heartbeat] unless rails_config[:advisory_lock_heartbeat].nil?
+ return ActiveModel::Type::Boolean.new.cast(env['GOOD_JOB_ADVISORY_LOCK_HEARTBEAT']) unless env['GOOD_JOB_ADVISORY_LOCK_HEARTBEAT'].nil?
+
+ Rails.env.development?
end
private
def rails_config