spec/gitlab/shell_spec.rb in gitlab-4.2.0 vs spec/gitlab/shell_spec.rb in gitlab-4.3.0

@@ -5,73 +5,73 @@
     Gitlab::Shell.setup
   end
 
   describe ".execute" do
     context "invalid command" do
-      it "should raise" do
+      it "raises RuntimeError" do
         expect { Gitlab::Shell.execute 'foobar', [] }.to raise_error(RuntimeError)
       end
     end
   end
 
   describe ".history" do
     before do
       @history = Gitlab::Shell.history
     end
 
-    it "should return a Gitlab::Shell::History instance" do
+    it "returns a Gitlab::Shell::History instance" do
       expect(@history).to be_a Gitlab::Shell::History
     end
-    it "should respond to :save" do
+    it "responds to :save" do
       expect(@history).to respond_to :save
     end
-    it "should respond to :load" do
+    it "responds to :load" do
       expect(@history).to respond_to :load
     end
-    it "should respond to :<<" do
+    it "responds to :<<" do
       expect(@history).to respond_to :<<
     end
   end
 
   describe ".setup" do
-    it "should set the Readline completion_proc" do
+    it "sets the Readline completion_proc" do
       completion = Readline.completion_proc
       expect(completion).to be_truthy
       expect(completion).to be_a Proc
     end
-    it "should set the Readline completion_append_character" do
+    it "sets the Readline completion_append_character" do
       completion_character = Readline.completion_append_character
       expect(completion_character).to eq(' ')
     end
   end
 
   describe ".completion" do
     before do
       @comp = Gitlab::Shell.completion
     end
-    it "should return a Proc object" do
+    it "returns a Proc object" do
       expect(@comp).to be_a Proc
     end
     context "called with an argument" do
-      it "should return an Array of matching commands" do
+      it "returns an Array of matching commands" do
         completed_cmds = @comp.call 'group'
         expect(completed_cmds).to be_a Array
-        expect(completed_cmds.sort).to eq(%w(group group_members group_projects group_search groups))
+        expect(completed_cmds.sort).to eq(%w(group group_member group_members group_projects group_search group_subgroups group_variable group_variables groups))
       end
     end
   end
 
   describe ".parse_input" do
     context "with arguments" do
-      it "should set command & arguments" do
+      it "sets command & arguments" do
         Gitlab::Shell.parse_input('create_branch 1 "api" "master"')
         expect(Gitlab::Shell.command).to eq('create_branch')
         expect(Gitlab::Shell.arguments).to eq(%w(1 api master))
       end
     end
 
     context "without arguments" do
-      it 'should set command & empty arguments' do
+      it 'sets command & empty arguments' do
         Gitlab::Shell.parse_input('exit')
         expect(Gitlab::Shell.command).to eq('exit')
         expect(Gitlab::Shell.arguments).to be_empty
       end
     end