help_spec.rb in gitlab-4.3.0

- old
+ new

@@ -1,18 +1,18 @@
 require 'spec_helper'
 
 describe Gitlab::Help do
   describe ".ri_cmd" do
     context "ri command found" do
-      it "should return the path to RI" do
+      it "returns the path to RI" do
         allow(Gitlab::Help).to receive(:`).with(/which ri/).and_return('/usr/bin/ri')
         expect(Gitlab::Help.ri_cmd).to eq('/usr/bin/ri')
       end
     end
 
     context "ri command NOT found" do
-      it "should raise" do
+      it "raises RuntimeError" do
         allow(Gitlab::Help).to receive(:`).with(/which ri/).and_return('')
         expect { Gitlab::Help.ri_cmd }.to raise_error RuntimeError
       end
     end
   end
@@ -21,25 +21,25 @@
     before do
       @cmd = "create_branch"
       @help_output = "Gitlab.#{@cmd}(4, 'new-branch', 'master')"
       @help_output_with_options = "Gitlab.groups({ per_page: 3 })"
     end
-    it "should return a String of modified output" do
+    it "returns a String of modified output" do
       Gitlab::Help.change_help_output! @cmd, @help_output
       expect(@help_output).to eq("Gitlab.create_branch 4 'new-branch' 'master'")
     end
-    it "should format options hash and return a String of modified output" do
+    it "formats options hash and return a String of modified output" do
       Gitlab::Help.change_help_output! 'groups', @help_output_with_options
       expect(@help_output_with_options).to eq("Gitlab.groups \"{ per_page: 3 }\"")
     end
   end
 
   describe ".namespace" do
     before do
       @cmd = 'create_tag'
       @namespace = Gitlab::Help.namespace @cmd
     end
-    it "should return the full namespace for a command" do
+    it "returns the full namespace for a command" do
       expect(@namespace).to be_a String
       expect(@namespace).to eq("Gitlab::Client::Tags.#{@cmd}")
     end
   end
 end