system_hooks_spec.rb in gitlab-4.3.0

- old
+ new

@@ -1,24 +1,24 @@
 require 'spec_helper'
 
 describe Gitlab::Client do
-  it { should respond_to :system_hooks }
-  it { should respond_to :add_system_hook }
-  it { should respond_to :system_hook }
-  it { should respond_to :delete_system_hook }
+  it { is_expected.to respond_to :system_hooks }
+  it { is_expected.to respond_to :add_system_hook }
+  it { is_expected.to respond_to :system_hook }
+  it { is_expected.to respond_to :delete_system_hook }
 
   describe ".hooks" do
     before do
       stub_get("/hooks", "system_hooks")
       @hooks = Gitlab.hooks
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/hooks")).to have_been_made
     end
 
-    it "should return a paginated response of system hooks" do
+    it "returns a paginated response of system hooks" do
       expect(@hooks).to be_a Gitlab::PaginatedResponse
       expect(@hooks.first.url).to eq("http://example.com/hook")
     end
   end
 
@@ -26,44 +26,44 @@
     before do
       stub_post("/hooks", "system_hook")
       @hook = Gitlab.add_hook("http://example.com/hook", token: 'secret-token')
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_post("/hooks").with(body: hash_including(token: 'secret-token'))).to have_been_made
     end
 
-    it "should return information about a added system hook" do
+    it "returns information about a added system hook" do
       expect(@hook.url).to eq("http://example.com/hook")
     end
   end
 
   describe ".hook" do
     before do
       stub_get("/hooks/3", "system_hook")
       @hook = Gitlab.hook(3)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/hooks/3")).to have_been_made
     end
 
-    it "should return information about a added system hook" do
+    it "returns information about a added system hook" do
       expect(@hook.url).to eq("http://example.com/hook")
     end
   end
 
   describe ".delete_hook" do
     before do
       stub_delete("/hooks/3", "system_hook")
       @hook = Gitlab.delete_hook(3)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_delete("/hooks/3")).to have_been_made
     end
 
-    it "should return information about a deleted system hook" do
+    it "returns information about a deleted system hook" do
       expect(@hook.url).to eq("http://example.com/hook")
     end
   end
 end