rubocop-security.yml in gitlab-styles-9.2.0 vs rubocop-security.yml in gitlab-styles-10.0.0

- old
+ new

@@ -1,9 +1,14 @@ --- require: - - rubocop-gitlab-security + - ./lib/gitlab/styles/rubocop +# Checks for implementations of the hash method which combine values using +# custom logic instead of delegating to Array#hash. +Security/CompoundHash: + Enabled: true + # This cop checks for the use of JSON class methods which have potential # security issues. Security/JSONLoad: Enabled: true @@ -14,41 +19,54 @@ # Checks for the first argument to IO.read, IO.binread, IO.write, IO.binwrite, IO.foreach, and IO.readlines Security/IoMethods: Enabled: true GitlabSecurity/DeepMunge: + Description: Checks for disabling the deep munge security control. Enabled: true + StyleGuide: https://www.rubydoc.info/gems/gitlab-styles/RuboCop/Cop/GitlabSecurity/DeepMunge Exclude: - 'lib/**/*.rake' - 'spec/**/*' # To be enabled by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13610 GitlabSecurity/JsonSerialization: + Description: Checks for `to_json` / `as_json` without allowing via `only`. Enabled: false + StyleGuide: https://www.rubydoc.info/gems/gitlab-styles/RuboCop/Cop/GitlabSecurity/JsonSerialization GitlabSecurity/PublicSend: + Description: Checks for the use of `public_send`, `send`, and `__send__` methods. Enabled: true + StyleGuide: https://www.rubydoc.info/gems/gitlab-styles/RuboCop/Cop/GitlabSecurity/PublicSend Exclude: - 'config/**/*' - 'db/**/*' - 'features/**/*' - 'lib/**/*.rake' - 'qa/**/*' - 'spec/**/*' +GitlabSecurity/SendFileParams: + Description: Check for passing of params hash to send_file() + Enabled: true + GitlabSecurity/RedirectToParamsUpdate: + Description: Check for use of redirect_to(params.update()) Enabled: true Exclude: - 'lib/**/*.rake' - 'spec/**/*' GitlabSecurity/SqlInjection: + Description: Check for SQL Injection in where() Enabled: true Exclude: - 'lib/**/*.rake' - 'spec/**/*' GitlabSecurity/SystemCommandInjection: + Description: Check for Command Injection in System() Enabled: true Exclude: - 'lib/**/*.rake' - 'spec/**/*'