rubocop-rspec.yml in gitlab-styles-9.0.0 vs rubocop-rspec.yml in gitlab-styles-9.1.0
- old
+ new
@@ -12,10 +12,20 @@
# We don't enforce this as we use this technique in a few places.
RSpec/BeforeAfterAll:
Enabled: false
+# Checks if there is a more specific finder offered by Capybara.
+# https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/merge_requests/131#note_1141024624
+RSpec/Capybara/SpecificFinders:
+ Enabled: false
+
+# Enforces consistent use of be_a or be_kind_of.
+# https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/merge_requests/131#note_1141022718
+RSpec/ClassCheck:
+ Enabled: false
+
# Check that the first argument to the top level describe is the tested class or
# module.
RSpec/DescribeClass:
Enabled: false
@@ -59,10 +69,16 @@
# Checks for `expect(...)` calls containing literal values.
RSpec/ExpectActual:
Enabled: true
+# Checks for `expect {...}.to change {...}` using a block.
+# See https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/merge_requests/122#note_1089192391
+RSpec/ExpectChange:
+ Enabled: true
+ EnforcedStyle: block
+
# Checks for opportunities to use `expect { … }.to output`.
RSpec/ExpectOutput:
Enabled: true
# Checks the file and folder naming of the spec file.
@@ -129,10 +145,14 @@
# Enforces the usage of the same method on all negative message expectations.
RSpec/NotToNot:
EnforcedStyle: not_to
Enabled: true
+# See https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/merge_requests/122#note_1089202045
+RSpec/PredicateMatcher:
+ Enabled: false
+
# Check for repeated description strings in example groups.
RSpec/RepeatedDescription:
Enabled: false
# Ensure RSpec hook blocks are always multi-line.
@@ -159,11 +179,5 @@
Language:
Helpers:
- let_it_be
- let_it_be_with_refind
- let_it_be_with_reload
- Includes:
- Examples:
- - run_permission_checks
- - run_group_permission_checks
- - it_should_email!
- - it_should_not_email!