rubocop-lint.yml in gitlab-styles-4.3.0 vs rubocop-lint.yml in gitlab-styles-5.0.0

@@ -1,5 +1,6 @@
+---
 # Checks for ambiguous block association with method when param passed without
 # parentheses.
 Lint/AmbiguousBlockAssociation:
   Enabled: false
 
@@ -16,10 +17,14 @@
 # This cop checks for assignments in the conditions of
 # if/while/until.
 Lint/AssignmentInCondition:
   Enabled: false
 
+# Checks for places where binary operator has identical operands
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: true
+
 # Default values in optional keyword arguments and optional ordinal arguments
 # should not refer back to the name of the argument.
 Lint/CircularArgumentReference:
   Enabled: true
 
@@ -29,18 +34,39 @@
 
 # Check for deprecated class method calls.
 Lint/DeprecatedClassMethods:
   Enabled: true
 
+# Algorithmic constants for OpenSSL::Cipher and OpenSSL::Digest deprecated since OpenSSL version 2.2.0.
+# Prefer passing a string instead.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintdeprecatedopensslconstant
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+# Checks that there are no repeated conditions used in if 'elsif'.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintduplicateelsifcondition
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
+# Checks that there are no repeated exceptions used in 'rescue' expressions.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintduplicaterescueexception
+Lint/DuplicateRescueException:
+  Enabled: true
+
 # Check for immutable argument given to each_with_object.
 Lint/EachWithObjectArgument:
   Enabled: true
 
 # Check for odd code arrangement in an else block.
 Lint/ElseLayout:
   Enabled: true
 
+# Checks for the presence of if, elsif and unless branches without a body.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintemptyconditionalbody
+Lint/EmptyConditionalBody:
+  Enabled: true
+
 # Checks for empty ensure block.
 Lint/EmptyEnsure:
   Enabled: true
 
 # Checks for the presence of `when` branches without a body.
@@ -53,10 +79,15 @@
 
 # Checks for flip flops.
 Lint/FlipFlop:
   Enabled: true
 
+# Checks for the presence of precise comparison of floating point numbers.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintfloatcomparison
+Lint/FloatComparison:
+  Enabled: true
+
 # Catches floating-point literals too large or small for Ruby to represent.
 Lint/FloatOutOfRange:
   Enabled: true
 
 # The number of parameters to format/sprint must match the fields.
@@ -79,22 +110,38 @@
 
 # Checks for literals used in interpolation.
 Lint/LiteralInInterpolation:
   Enabled: true
 
-# This cop checks for uses of *begin...end while/until something*.
+# Checks for uses of *begin...end while/until something*.
 Lint/Loop:
   Enabled: false
 
+# Checks for the presence of constructors and lifecycle callbacks without calls to super.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintmissingsuper
+Lint/MissingSuper:
+  Enabled: false
+
+# Do not mix named captures and numbered captures in a Regexp literal
+# because numbered capture is ignored if they’re mixed.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintmixedregexpcapturetypes
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+
 # Do not use nested method definitions.
 Lint/NestedMethodDefinition:
   Enabled: true
 
 # Do not omit the accumulator when calling `next` in a `reduce`/`inject` block.
 Lint/NextWithoutAccumulator:
   Enabled: true
 
+# Looks for references of Regexp captures that are out of range and thus always returns nil.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintoutofrangeregexpref
+Lint/OutOfRangeRegexpRef:
+  Enabled: true
+
 # Checks for method calls with a space before the opening parenthesis.
 Lint/ParenthesesAsGroupedExpression:
   Enabled: true
 
 # Checks for raise or fail statements which are raising Exception class.
@@ -124,10 +171,15 @@
 
 # Ensures safe navigation isn't used with empty? in a conditional
 Lint/SafeNavigationWithEmpty:
   Enabled: true
 
+# Checks for self-assignments.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintselfassignment
+Lint/SelfAssignment:
+  Enabled: true
+
 # Checks for the order which exceptions are rescued to avoid rescueing a less specific exception before a more specific exception.
 Lint/ShadowedException:
   Enabled: false
 
 # This cop looks for use of the same name as outer local variables
@@ -141,10 +193,15 @@
 
 # This cop checks for *rescue* blocks with no body.
 Lint/SuppressedException:
   Enabled: false
 
+# Checks for top level return with arguments.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#linttoplevelreturnwithargument
+Lint/TopLevelReturnWithArgument:
+  Enabled: true
+
 # Do not use prefix `_` for a variable that is used.
 Lint/UnderscorePrefixedVariableName:
   Enabled: true
 
 # This cop checks for using Fixnum or Bignum constant
@@ -153,10 +210,15 @@
 
 # Unreachable code.
 Lint/UnreachableCode:
   Enabled: true
 
+# Checks for loops that will have at most one iteration.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintunreachableloop
+Lint/UnreachableLoop:
+  Enabled: true
+
 # This cop checks for unused block arguments.
 Lint/UnusedBlockArgument:
   Enabled: false
 
 # This cop checks for unused method arguments.
@@ -168,13 +230,9 @@
   ContextCreatingMethods:
     - class_methods
 
 # Checks for useless assignment to a local variable.
 Lint/UselessAssignment:
-  Enabled: true
-
-# Checks for comparison of something with itself.
-Lint/UselessComparison:
   Enabled: true
 
 # Checks for useless `else` in `begin..end` without `rescue`.
 Lint/UselessElseWithoutRescue:
   Enabled: true