lib/gitlab_exporter/git.rb in gitlab-exporter-11.1.0 vs lib/gitlab_exporter/git.rb in gitlab-exporter-11.2.0

@@ -62,14 +62,14 @@
     # Handles creating a Git object, probing for both pull and push, and finally writing to metrics
     #
     # Optionally takes a metrics object which by default is a PrometheusMetrics, useful to change the
     # metrics writer to something else.
     class GitProber
-      def initialize(opts, metrics: PrometheusMetrics.new, logger: nil) # rubocop:disable Lint/UnusedMethodArgument
+      def initialize(source:, metrics: PrometheusMetrics.new, labels: {}, **opts) # rubocop:disable Lint/UnusedMethodArgument
         @metrics = metrics
-        @labels = opts[:labels] || {}
-        @git = Git.new(opts[:source])
+        @labels = labels
+        @git = Git.new(source)
       end
 
       def probe_pull
         @metrics.add "git_pull_time_milliseconds", (@git.pull.time * 1000).to_i, **@labels
         self
@@ -85,13 +85,13 @@
       end
     end
 
     # A special prober for git processes
     class GitProcessProber
-      def initialize(opts, metrics: PrometheusMetrics.new, logger: nil) # rubocop:disable Lint/UnusedMethodArgument
-        @opts    = opts
+      def initialize(metrics: PrometheusMetrics.new, quantiles: nil, **opts) # rubocop:disable Lint/UnusedMethodArgument
         @metrics = metrics
+        @quantiles = quantiles
       end
 
       def probe_git # rubocop:disable Metrics/MethodLength
         puts "[DEPRECATED] probe_git and GitProcessProber are now considered obsolete"\
           " and will be removed in future major versions,"\
@@ -113,10 +113,10 @@
 
           prober = ProcessProber.new(
             {
               name: name,
               pid_or_pattern: pid,
-              quantiles: @opts[:quantiles]
+              quantiles: @quantiles
             },
             metrics: @metrics
           )
 
           prober