lib/geonames_api/country.rb in geonames_api-0.1.1 vs lib/geonames_api/country.rb in geonames_api-0.1.2

@@ -1,27 +1,69 @@
+require 'fileutils'
+
 module GeoNamesAPI
   class Country < ListEndpoint
 
     METHOD = "countryInfoJSON"
     FIND_PARAMS = %w(country)
 
     EXPORT_BASE_URL = "http://download.geonames.org/export/zip/"
     EXPORT_HEADERS = %W(country_code postal_code place_name admin_name1 admin_code1 admin_name2 admin_code2 admin_name3 admin_code3 latitude longitude accuracy)
 
     def postal_code_export
-      zip_data = open(postal_code_export_url) { |f| f.binmode; f.read }
-      stream = lambda { return zip_data.slice!(0, 256) }
-      csv = EXPORT_HEADERS.join("\t") + "\n"
-      Zip::Archive.open_buffer(stream) do |archive|
-        archive.each do |f|
-          csv << f.read if f.name =~ /\A#{country_code}/
-        end
-      end
-      csv
+      download_archive
+      extract_file
+      create_csv
     end
 
     def postal_code_csv
       CSV.parse(postal_code_export, headers: true, col_sep: "\t", header_converters: :symbol, encoding: "ISO8859-1")
+    end
+
+  private
+
+    def download_archive
+      File.open(export_directory.to_s + "/export.zip", "wb") do |f|
+        open(postal_code_export_url, "rb") do |export|
+          f.write export.read
+        end
+      end
+    end
+
+    def extract_file
+      Zip::File.foreach(export_directory.to_s + "/export.zip") do |f|  
+        File.delete(extract_file_name) if File.exist?(extract_file_name)
+        f.extract(extract_file_name) if f.name =~ /\A#{country_code}/
+      end
+    end
+
+    def create_csv
+      File.open(csv_file_name, "wb") do |f|
+        f.write EXPORT_HEADERS.join("\t") + "\n"
+        f.write File.open(extract_file_name, "r").read
+      end
+      File.open(csv_file_name, "r").read
+    end
+
+    def extract_file_name
+      export_directory + "/tmp.txt"
+    end
+
+    def csv_file_name
+      export_directory + "/#{country_code}.txt"
+    end
+
+    # if rails is defined use the rails tmp directory to ensure
+    # compatability with heroku
+    def export_directory
+      directory = if defined?(Rails)
+        Rails.root.join("tmp","geonames_api").to_s
+      else
+        File.expand_path("../../../tmp", __FILE__)
+      end
+      FileUtils.mkdir(directory) unless File.directory?(directory)
+      FileUtils.chmod_R(0777, directory)
+      directory
     end
 
     def postal_code_export_url
       EXPORT_BASE_URL + country_code + ".zip"
     end