lib/geocoder/lookups/maxmind_geoip2.rb in geocoder-1.5.0 vs lib/geocoder/lookups/maxmind_geoip2.rb in geocoder-1.5.1
- old
+ new
@@ -30,15 +30,11 @@
def configured_service!
if s = configuration[:service] and services.include?(s) and configuration[:basic_auth][:user] and configuration[:basic_auth][:password]
return s
else
raise(
- Geocoder::ConfigurationError,
- "When using MaxMind GeoIP2 you MUST specify a service name and basic_auth: " +
- "Geocoder.configure(:maxmind_geoip2 => {:service => ...}, " +
- ":basic_auth => {:user ..., :password => ...}), " +
- "where service is one of: #{services.inspect}"
+ Geocoder::ConfigurationError, "When using MaxMind GeoIP2 you must specify a service and credentials: Geocoder.configure(maxmind_geoip2: {service: ..., basic_auth: {user: ..., password: ...}}), where service is one of: #{services.inspect}"
)
end
end
def data_contains_error?(doc)
@@ -55,11 +51,12 @@
:insights,
]
end
def results(query)
- # don't look up a loopback address
- return [] if query.loopback_ip_address?
+ # don't look up a loopback or private address, just return the stored result
+ return [] if query.internal_ip_address?
+
doc = fetch_data(query)
if doc
if !data_contains_error?(doc)
return [doc]
else