lib/geocoder/lookups/bing.rb in geocoder-1.1.3 vs lib/geocoder/lookups/bing.rb in geocoder-1.1.4

- old
+ new

@@ -8,26 +8,30 @@ "http://www.bing.com/maps/default.aspx?cp=#{coordinates.join('~')}" end private # --------------------------------------------------------------- - def results(query, reverse = false) - return [] unless doc = fetch_data(query, reverse) + def results(query) + return [] unless doc = fetch_data(query) if doc['statusDescription'] == "OK" return doc['resourceSets'].first['estimatedTotal'] > 0 ? doc['resourceSets'].first['resources'] : [] else warn "Bing Geocoding API error: #{doc['statusCode']} (#{doc['statusDescription']})." return [] end end - def query_url(query, reverse = false) - params = {:key => Geocoder::Configuration.api_key} - params[:query] = query unless reverse + def query_url_params(query) + super.merge( + :key => Geocoder::Configuration.api_key, + :query => query.reverse_geocode? ? nil : query.sanitized_text + ) + end - base_url = "http://dev.virtualearth.net/REST/v1/Locations" - url_tail = reverse ? "/#{query}?" : "?" - base_url + url_tail + hash_to_query(params) + def query_url(query) + "http://dev.virtualearth.net/REST/v1/Locations" + + (query.reverse_geocode? ? "/#{query.sanitized_text}?" : "?") + + url_query_string(query) end end end