lib/gamma/importer/replace.rb in gamma-0.1.9 vs lib/gamma/importer/replace.rb in gamma-0.2.0

@@ -18,43 +18,47 @@
 
   private
 
   def batch_sync
     columns = @table.in_exist_columns & @table.out_exist_columns
-    primary_key = "id" # TODO: Fixme
+    primary_key = 'id' # TODO: Fixme
 
     current_in_pid = 0
-    while true do
-      select_columns = columns.map { |c| "`#{c}`" }.join(",")
+    while true
+      select_columns = columns.map { |c| "`#{c}`" }.join(',')
       break unless select_columns.present?
 
       in_query = "SELECT #{select_columns} FROM #{@table.table_name} WHERE #{primary_key} > #{current_in_pid} ORDER BY #{primary_key} ASC LIMIT #{BATCH_SIZE}"
-      logger.info(in_query) if ENV["DEBUG"]
+      logger.info(in_query) if ENV['DEBUG']
       in_records = @in_client.client.query(in_query).to_a
 
       break unless in_records.present?
 
       out_records = exist_records(select_columns, primary_key, in_records.map { |v| v[primary_key] })
 
-      in_records.map { |ir| [ir, out_records.find { |v| ir[primary_key] == v[primary_key] }] }.each do |in_record, out_record|
+      in_records.map do |ir|
+        [ir, out_records.find do |v|
+               ir[primary_key] == v[primary_key]
+             end]
+      end.each do |in_record, out_record|
         if out_record.present?
           update_out_record(in_record, out_record, primary_key)
         else
           insert_out_record(in_record)
         end
       end
 
       current_in_pid = in_records.last[primary_key]
     end
-  rescue => e
+  rescue StandardError => e
     logger.error("Sync Error #{@table.table_name} \n #{e}\n #{e.backtrace.join("\n")}".red)
   end
 
   def exist_records(select_columns, primary_key, in_pids)
     return [] unless in_pids.present?
 
-    query = "SELECT #{select_columns} FROM #{@table.table_name} WHERE #{primary_key} in (#{in_pids.join(",")})"
+    query = "SELECT #{select_columns} FROM #{@table.table_name} WHERE #{primary_key} in (#{in_pids.join(',')})"
     @out_client.client.query(query).to_a
   end
 
   def update_out_record(in_record, out_record, primary_key)
     need_update = @table.delta_column.blank?
@@ -66,11 +70,11 @@
 
       query = <<-EOS
         UPDATE `#{@table.table_name}` SET #{values} WHERE #{primary_key} = #{record[primary_key]}
       EOS
       query = query.strip_heredoc
-      logger.info(query) if ENV["DEBUG"]
+      logger.info(query) if ENV['DEBUG']
 
       if @apply
         exec_query(query)
       else
         logger.info("DRYRUN: #{query}")
@@ -79,18 +83,18 @@
   end
 
   def insert_out_record(in_record)
     record = @table.record_value(in_record)
     columns = (@table.in_exist_columns & @table.out_exist_columns).reject { |c| record[c].nil? }
-    select_columns = columns.map { |c| "`#{c}`" }.join(",")
+    select_columns = columns.map { |c| "`#{c}`" }.join(',')
     values = insert_record_values(record, columns)
 
     query = <<-EOS
       INSERT INTO #{@table.table_name}(#{select_columns}) VALUES (#{values})
     EOS
     query = query.strip_heredoc
-    logger.info(query) if ENV["DEBUG"]
+    logger.info(query) if ENV['DEBUG']
 
     if @apply
       exec_query(query)
     else
       logger.info("DRYRUN: #{query}")
@@ -99,34 +103,34 @@
 
   def insert_record_values(record, columns)
     r = record
     columns.map do |v|
       c = if r[v].is_a?(Time)
-            r[v].strftime("%Y-%m-%d %H:%M:%S")
+            r[v].strftime('%Y-%m-%d %H:%M:%S')
           else
             r[v]
           end
-     "\"#{@out_client.client.escape(c.to_s)}\""
-    end.join(",")
+      "\"#{@out_client.client.escape(c.to_s)}\""
+    end.join(',')
   end
 
   def update_record_values(record, columns)
     r = record
     columns.map do |v|
       c = if r[v].is_a?(Time)
-            r[v].strftime("%Y-%m-%d %H:%M:%S")
+            r[v].strftime('%Y-%m-%d %H:%M:%S')
           else
             r[v]
           end
       "`#{v}` = \"#{@out_client.client.escape(c.to_s)}\""
-    end.join(",")
+    end.join(',')
   end
 
   def exec_query(query)
     @out_client.client.query(query)
-  rescue => e
+  rescue StandardError => e
     if @ignore_error
-      logger.error("An ERROR has occurred and ignore it.")
+      logger.error('An ERROR has occurred and ignore it.')
       logger.error(e)
     else
       throw e
     end
   end