app/assets/javascripts/formstrap/controllers/media_controller.js in formstrap-0.3.1 vs app/assets/javascripts/formstrap/controllers/media_controller.js in formstrap-0.3.2
- old
+ new
@@ -112,15 +112,15 @@
this.validationInputTarget.setCustomValidity(this.validationInputTarget.dataset.maxMessage)
}
}
minActiveItems () {
- return parseInt(this.element.dataset.min, 10) || 0
+ return parseInt(this.validationInputTarget.dataset.min, 10) || 0
}
maxActiveItems () {
- return parseInt(this.element.dataset.max, 10) || Infinity
+ return parseInt(this.validationInputTarget.dataset.max, 10) || Infinity
}
resetPositions () {
this.activeItems().forEach((item, index) => {
const positionInput = item.querySelector('input[name*=\'position\']')
@@ -129,17 +129,11 @@
}
})
}
addNewItems (items) {
- const itemTargetIds = this.itemTargets.map((i) => { return parseInt(i.querySelectorAll('input')[1].value) })
items.forEach((item) => {
- if (itemTargetIds.includes(item.blobId)) {
- // Do not add this item (as it is already present)
- return
- }
-
this.addItem(item)
})
}
addItem (item) {
@@ -209,11 +203,11 @@
removeDeselectedItems (elements, items) {
const returnedBlobIds = elements.map((e) => { return e.blobId })
items.forEach((item) => {
- const blobId = parseInt(item.querySelectorAll('input')[1].value)
+ const blobId = parseInt(item.querySelectorAll('input')[1].value, 10)
if (returnedBlobIds.includes(blobId)) {
// Do not delete this one
return
}
@@ -235,11 +229,11 @@
this.togglePlaceholder()
}
itemByBlobId (blobId) {
return this.itemTargets.find((item) => {
- return item.querySelector('input[name*=\'blob_id\']').value === blobId
+ return parseInt(item.querySelector('input[name*=\'blob_id\']').value, 10) === blobId
})
}
activeItems () {
return this.itemTargets.filter((item) => {
@@ -247,9 +241,9 @@
})
}
activeIds () {
return this.activeItems().map((item) => {
- return item.querySelector('input[name$=\'[blob_id]\']').value
+ return parseInt(item.querySelector('input[name$=\'[blob_id]\']').value, 10)
})
}
}