.rubocop_todo.yml in foreman-tasks-2.0.3 vs .rubocop_todo.yml in foreman-tasks-3.0.0
- old
+ new
@@ -1,24 +1,37 @@
-# Offense count: 1
-Lint/EmptyWhen:
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-08-07 08:31:32 UTC using RuboCop version 0.89.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
Exclude:
- - 'app/lib/actions/proxy_action.rb'
+ - 'foreman-tasks-core.gemspec'
+ - 'foreman-tasks.gemspec'
# Offense count: 1
Lint/UselessAssignment:
Exclude:
- 'lib/foreman_tasks/tasks/export_tasks.rake'
-Minitest/AssertEmpty:
- Enabled: false
+# Offense count: 1
+# Configuration parameters: ExpectMatchingDefinition, CheckDefinitionPathHierarchy, Regex, IgnoreExecutableScripts, AllowedAcronyms.
+# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
+Naming/FileName:
+ Exclude:
+ - '*.gemspec'
+ - 'Gemfile'
+ - 'db/seeds.d/*'
+ - 'lib/foreman-tasks.rb'
+ - 'gemfile.d/foreman-tasks.rb'
-Minitest/AssertEqual:
- Enabled: false
-
-Minitest/GlobalExpectations:
- Enabled: false
-
# Offense count: 3
# Configuration parameters: EnforcedStyleForLeadingUnderscores.
# SupportedStylesForLeadingUnderscores: disallowed, required, optional
Naming/MemoizedInstanceVariableName:
Exclude:
@@ -26,11 +39,11 @@
- 'app/lib/actions/recurring_action.rb'
- 'lib/foreman_tasks_core/otp_manager.rb'
# Offense count: 11
# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
Naming/MethodParameterName:
Exclude:
- 'app/helpers/foreman_tasks/foreman_tasks_helper.rb'
# Offense count: 1
@@ -65,15 +78,17 @@
# Offense count: 5
Rails/OutputSafety:
Exclude:
- 'app/helpers/foreman_tasks/foreman_tasks_helper.rb'
-# Offense count: 1
+# Offense count: 2
# Configuration parameters: Include.
# Include: **/Rakefile, **/*.rake
Rails/RakeEnvironment:
Exclude:
+ - 'lib/capistrano/tasks/**/*.rake'
+ - 'lib/foreman_tasks/tasks/dynflow.rake'
- 'lib/foreman_tasks/tasks/test.rake'
# Offense count: 12
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, EnforcedStyle.
@@ -90,24 +105,16 @@
- 'lib/foreman_tasks/dynflow/console_authorizer.rb'
- 'lib/foreman_tasks/dynflow/persistence.rb'
- 'test/controllers/api/recurring_logics_controller_test.rb'
- 'test/controllers/api/tasks_controller_test.rb'
-# Offense count: 2
+# Offense count: 1
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: allowed_in_returns, forbidden
Style/DoubleNegation:
Exclude:
- - 'app/models/foreman_tasks/lock.rb'
- 'app/models/foreman_tasks/recurring_logic.rb'
-# Offense count: 36
+# Offense count: 35
# Configuration parameters: MinBodyLength.
Style/GuardClause:
- Enabled: false
-
-Style/HashEachMethods:
- Enabled: false
-
-Style/HashTransformKeys:
- Enabled: false
-
-Style/HashTransformValues:
Enabled: false