.rubocop_todo.yml in foreman-tasks-1.0.1 vs .rubocop_todo.yml in foreman-tasks-1.1.0

- old
+ new

@@ -1,115 +1,51 @@ -# This configuration was generated by -# `rubocop --auto-gen-config` -# on 2018-04-02 18:15:37 +0200 using RuboCop version 0.54.0. -# The point is for the user to remove these configuration records -# one by one as the offenses are removed from the code base. -# Note that changes in the inspected code, or installation of new -# versions of RuboCop, may require this file to be generated again. - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: Include, TreatCommentsAsGroupSeparators. -# Include: **/*.gemspec -Gemspec/OrderedDependencies: - Exclude: - - 'foreman-tasks.gemspec' - # Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: final_newline, final_blank_line -Layout/TrailingBlankLines: - Exclude: - - 'locale/action_names.rb' - -# Offense count: 1 Lint/EmptyWhen: Exclude: - 'app/lib/actions/proxy_action.rb' -# Offense count: 2 +# Offense count: 1 Lint/UselessAssignment: Exclude: - 'lib/foreman_tasks/tasks/export_tasks.rake' -# Offense count: 32 -Metrics/AbcSize: - Max: 41 +Minitest/AssertEmpty: + Enabled: false -# Offense count: 2 -# Configuration parameters: CountComments, ExcludedMethods. -Metrics/BlockLength: - Max: 32 +Minitest/AssertEqual: + Enabled: false -# Offense count: 13 -# Configuration parameters: CountComments. -Metrics/ClassLength: - Max: 230 +Minitest/GlobalExpectations: + Enabled: false -# Offense count: 9 -Metrics/CyclomaticComplexity: - Max: 9 - -# Offense count: 482 -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 211 - -# Offense count: 54 -# Configuration parameters: CountComments. -Metrics/MethodLength: - Max: 29 - -# Offense count: 2 -# Configuration parameters: CountComments. -Metrics/ModuleLength: - Max: 167 - -# Offense count: 1 -# Configuration parameters: CountKeywordArgs. -Metrics/ParameterLists: - Max: 6 - -# Offense count: 4 -Metrics/PerceivedComplexity: - Max: 9 - # Offense count: 3 +# Configuration parameters: EnforcedStyleForLeadingUnderscores. +# SupportedStylesForLeadingUnderscores: disallowed, required, optional Naming/MemoizedInstanceVariableName: Exclude: - 'app/controllers/foreman_tasks/recurring_logics_controller.rb' - 'app/lib/actions/recurring_action.rb' - 'lib/foreman_tasks_core/otp_manager.rb' +# Offense count: 11 +# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. +# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp +Naming/MethodParameterName: + Exclude: + - 'app/helpers/foreman_tasks/foreman_tasks_helper.rb' + # Offense count: 1 -# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros. +# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. # NamePrefix: is_, has_, have_ -# NamePrefixBlacklist: is_, has_, have_ -# NameWhitelist: is_a? +# ForbiddenPrefixes: is_, has_, have_ +# AllowedMethods: is_a? # MethodDefinitionMacros: define_method, define_singleton_method Naming/PredicateName: Exclude: - 'spec/**/*' - 'app/models/foreman_tasks/task/status_explicator.rb' -# Offense count: 12 -# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. -# AllowedNames: io, id, to -Naming/UncommunicativeMethodParamName: - Exclude: - - 'app/helpers/foreman_tasks/foreman_tasks_helper.rb' - - 'app/models/foreman_tasks/recurring_logic.rb' - -# Offense count: 3 -# Cop supports --auto-correct. -Rails/ActiveRecordAliases: - Exclude: - - 'app/models/foreman_tasks/task/dynflow_task.rb' - - 'test/factories/task_factory.rb' - # Offense count: 6 # Configuration parameters: Include. # Include: db/migrate/*.rb Rails/CreateTableWithTimestamps: Exclude: @@ -118,18 +54,10 @@ - 'db/migrate/20150907124936_create_recurring_logic.rb' - 'db/migrate/20150907131503_create_task_groups.rb' - 'db/migrate/20151112152108_create_triggerings.rb' # Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: numeric, symbolic -Rails/HttpStatus: - Exclude: - - 'app/controllers/foreman_tasks/concerns/hosts_controller_extension.rb' - -# Offense count: 1 # Configuration parameters: Include. # Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb Rails/Output: Exclude: - 'lib/foreman_tasks/cleaner.rb' @@ -137,11 +65,18 @@ # Offense count: 5 Rails/OutputSafety: Exclude: - 'app/helpers/foreman_tasks/foreman_tasks_helper.rb' -# Offense count: 11 +# Offense count: 1 +# Configuration parameters: Include. +# Include: **/Rakefile, **/*.rake +Rails/RakeEnvironment: + Exclude: + - 'lib/foreman_tasks/tasks/test.rake' + +# Offense count: 12 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, EnforcedStyle. # SupportedStyles: nested, compact Style/ClassAndModuleChildren: Exclude: @@ -161,35 +96,18 @@ Style/DoubleNegation: Exclude: - 'app/models/foreman_tasks/lock.rb' - 'app/models/foreman_tasks/recurring_logic.rb' -# Offense count: 2 -# Cop supports --auto-correct. -Style/Encoding: - Exclude: - - 'foreman-tasks-core.gemspec' - - 'foreman-tasks.gemspec' - -# Offense count: 6 -# Cop supports --auto-correct. -Style/ExpandPathArguments: - Exclude: - - 'foreman-tasks-core.gemspec' - - 'foreman-tasks.gemspec' - - 'lib/foreman_tasks/engine.rb' - - 'script/rails' - -# Offense count: 32 +# Offense count: 36 # Configuration parameters: MinBodyLength. Style/GuardClause: Enabled: false -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: AllowMultipleReturnValues. -Style/RedundantReturn: - Exclude: - - 'app/models/foreman_tasks/concerns/action_triggering.rb' +Style/HashEachMethods: + Enabled: false -Lint/SendWithMixinArgument: +Style/HashTransformKeys: + Enabled: false + +Style/HashTransformValues: Enabled: false