.rubocop_todo.yml in foreman-tasks-0.13.0 vs .rubocop_todo.yml in foreman-tasks-0.13.1

- old
+ new

@@ -1,76 +1,149 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2016-12-21 14:29:23 +0200 using RuboCop version 0.46.0. +# on 2018-04-02 18:15:37 +0200 using RuboCop version 0.54.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -Lint/EmptyWhen: +# Offense count: 3 +# Cop supports --auto-correct. +# Configuration parameters: Include, TreatCommentsAsGroupSeparators. +# Include: **/*.gemspec +Gemspec/OrderedDependencies: Exclude: - - 'app/lib/actions/proxy_action.rb' + - 'foreman-tasks.gemspec' -Lint/ShadowingOuterLocalVariable: +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: final_newline, final_blank_line +Layout/TrailingBlankLines: Exclude: - - 'bin/dynflow-executor' + - 'locale/action_names.rb' +# Offense count: 1 +Lint/EmptyWhen: + Exclude: + - 'app/lib/actions/proxy_action.rb' + +# Offense count: 2 Lint/UselessAssignment: Exclude: - 'lib/foreman_tasks/tasks/export_tasks.rake' +# Offense count: 32 Metrics/AbcSize: Max: 41 -# Configuration parameters: CountComments. +# Offense count: 2 +# Configuration parameters: CountComments, ExcludedMethods. Metrics/BlockLength: - Max: 105 + Max: 32 +# Offense count: 13 # Configuration parameters: CountComments. Metrics/ClassLength: Max: 230 +# Offense count: 9 Metrics/CyclomaticComplexity: - Max: 10 + Max: 9 +# Offense count: 482 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Metrics/LineLength: - Max: 244 + Max: 211 +# Offense count: 54 # Configuration parameters: CountComments. Metrics/MethodLength: - Max: 37 + Max: 29 +# Offense count: 2 # Configuration parameters: CountComments. Metrics/ModuleLength: - Max: 170 + Max: 167 +# Offense count: 1 # Configuration parameters: CountKeywordArgs. Metrics/ParameterLists: Max: 6 +# Offense count: 4 Metrics/PerceivedComplexity: - Max: 10 + Max: 9 +# Offense count: 3 +Naming/MemoizedInstanceVariableName: + Exclude: + - 'app/controllers/foreman_tasks/recurring_logics_controller.rb' + - 'app/lib/actions/recurring_action.rb' + - 'lib/foreman_tasks_core/otp_manager.rb' + +# Offense count: 1 +# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros. +# NamePrefix: is_, has_, have_ +# NamePrefixBlacklist: is_, has_, have_ +# NameWhitelist: is_a? +# MethodDefinitionMacros: define_method, define_singleton_method +Naming/PredicateName: + Exclude: + - 'spec/**/*' + - 'app/models/foreman_tasks/task/status_explicator.rb' + +# Offense count: 12 +# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. +# AllowedNames: io, id, to +Naming/UncommunicativeMethodParamName: + Exclude: + - 'app/helpers/foreman_tasks/foreman_tasks_helper.rb' + - 'app/models/foreman_tasks/recurring_logic.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +Rails/ActiveRecordAliases: + Exclude: + - 'app/models/foreman_tasks/task/dynflow_task.rb' + - 'test/factories/task_factory.rb' + +# Offense count: 6 # Configuration parameters: Include. -# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb -Rails/Exit: +# Include: db/migrate/*.rb +Rails/CreateTableWithTimestamps: Exclude: - - 'lib/**/*.rake' + - 'db/migrate/20131205204140_create_foreman_tasks.rb' + - 'db/migrate/20131209122644_create_foreman_tasks_locks.rb' + - 'db/migrate/20150907124936_create_recurring_logic.rb' + - 'db/migrate/20150907131503_create_task_groups.rb' + - 'db/migrate/20151112152108_create_triggerings.rb' +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: numeric, symbolic +Rails/HttpStatus: + Exclude: + - 'app/controllers/foreman_tasks/concerns/hosts_controller_extension.rb' + +# Offense count: 1 # Configuration parameters: Include. # Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb Rails/Output: Exclude: - 'lib/foreman_tasks/cleaner.rb' +# Offense count: 5 Rails/OutputSafety: Exclude: - 'app/helpers/foreman_tasks/foreman_tasks_helper.rb' -# Configuration parameters: EnforcedStyle, SupportedStyles. +# Offense count: 11 +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, EnforcedStyle. # SupportedStyles: nested, compact Style/ClassAndModuleChildren: Exclude: - 'app/lib/actions/action_with_sub_plans.rb' - 'app/models/foreman_tasks/task/dynflow_task.rb' @@ -81,53 +154,39 @@ - 'lib/foreman_tasks/dynflow/configuration.rb' - 'lib/foreman_tasks/dynflow/console_authorizer.rb' - 'lib/foreman_tasks/dynflow/persistence.rb' - 'test/controllers/api/recurring_logics_controller_test.rb' - 'test/controllers/api/tasks_controller_test.rb' - - 'test/unit/actions/action_with_sub_plans_test.rb' +# Offense count: 2 Style/DoubleNegation: Exclude: - 'app/models/foreman_tasks/lock.rb' - 'app/models/foreman_tasks/recurring_logic.rb' -# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts. -Naming/FileName: +# Offense count: 2 +# Cop supports --auto-correct. +Style/Encoding: Exclude: - - 'db/seeds.d/20-foreman_tasks_permissions.rb' - - 'db/seeds.d/60-dynflow_proxy_feature.rb' - - 'db/seeds.d/61-foreman_tasks_bookmarks.rb' - - 'lib/foreman-tasks.rb' + - 'foreman-tasks-core.gemspec' + - 'foreman-tasks.gemspec' -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: format, sprintf, percent -Style/FormatString: +# Offense count: 6 +# Cop supports --auto-correct. +Style/ExpandPathArguments: Exclude: - - 'app/models/foreman_tasks/task/dynflow_task.rb' - - 'lib/foreman_tasks/tasks/export_tasks.rake' + - 'foreman-tasks-core.gemspec' + - 'foreman-tasks.gemspec' + - 'lib/foreman_tasks/engine.rb' + - 'script/rails' +# Offense count: 32 # Configuration parameters: MinBodyLength. Style/GuardClause: Enabled: false -# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist. -# NamePrefix: is_, has_, have_ -# NamePrefixBlacklist: is_, has_, have_ -# NameWhitelist: is_a? -Naming/PredicateName: - Exclude: - - 'spec/**/*' - - 'app/models/foreman_tasks/task/status_explicator.rb' - +# Offense count: 1 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes. -# SupportedStyles: slashes, percent_r, mixed -Style/RegexpLiteral: +# Configuration parameters: AllowMultipleReturnValues. +Style/RedundantReturn: Exclude: - - 'lib/foreman_tasks/dynflow/console_authorizer.rb' - -# Configuration parameters: Methods. -# Methods: {"reduce"=>["acc", "elem"]}, {"inject"=>["acc", "elem"]} -Style/SingleLineBlockParams: - Exclude: - - 'app/models/foreman_tasks/concerns/action_subject.rb' - - 'app/models/foreman_tasks/lock.rb' + - 'app/models/foreman_tasks/concerns/action_triggering.rb'