.rubocop_todo.yml in fog-vsphere-2.4.0 vs .rubocop_todo.yml in fog-vsphere-2.5.0

@@ -1,8 +1,8 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-04-18 16:02:28 +0200 using RuboCop version 0.50.0.
+# on 2018-11-15 11:16:00 -0500 using RuboCop version 0.49.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
@@ -24,24 +24,10 @@
     - 'lib/fog/vsphere/models/compute/tickets.rb'
     - 'lib/fog/vsphere/models/compute/volumes.rb'
     - 'lib/fog/vsphere/requests/compute/create_vm.rb'
     - 'lib/fog/vsphere/requests/compute/host_start_maintenance.rb'
 
-# Offense count: 2
-Lint/InterpolationCheck:
-  Exclude:
-    - 'tests/requests/compute/vm_power_off_tests.rb'
-    - 'tests/requests/compute/vm_suspend_tests.rb'
-
-# Offense count: 13
-Lint/RescueWithoutErrorClass:
-  Exclude:
-    - 'lib/fog/vsphere/compute.rb'
-    - 'lib/fog/vsphere/requests/compute/list_hosts.rb'
-    - 'lib/fog/vsphere/requests/compute/list_vm_cdroms.rb'
-    - 'lib/fog/vsphere/requests/compute/list_vm_volumes.rb'
-
 # Offense count: 3
 Lint/ShadowingOuterLocalVariable:
   Exclude:
     - 'lib/fog/vsphere/requests/compute/create_vm.rb'
     - 'lib/fog/vsphere/requests/compute/destroy_rule.rb'
@@ -58,43 +44,43 @@
     - 'lib/fog/vsphere/requests/compute/get_interface_type.rb'
     - 'lib/fog/vsphere/requests/compute/vm_clone.rb'
     - 'lib/fog/vsphere/requests/compute/vm_migrate.rb'
     - 'tests/requests/compute/vm_clone_tests.rb'
 
-# Offense count: 57
+# Offense count: 64
 Metrics/AbcSize:
-  Max: 633
+  Max: 635
 
 # Offense count: 12
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
-  Max: 263
+  Max: 264
 
 # Offense count: 21
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5
 
 # Offense count: 6
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 452
+  Max: 284
 
-# Offense count: 15
+# Offense count: 19
 Metrics/CyclomaticComplexity:
-  Max: 150
+  Max: 151
 
-# Offense count: 16
+# Offense count: 819
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
   Max: 317
 
-# Offense count: 72
+# Offense count: 80
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
-  Max: 356
+  Max: 358
 
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
   Max: 109
@@ -102,36 +88,14 @@
 # Offense count: 2
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 6
 
-# Offense count: 16
+# Offense count: 20
 Metrics/PerceivedComplexity:
-  Max: 158
+  Max: 159
 
-# Offense count: 1
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
-# NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
-Naming/PredicateName:
-  Exclude:
-    - 'spec/**/*'
-    - 'lib/fog/vsphere/compute.rb'
-
-# Offense count: 15
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: snake_case, camelCase
-Naming/VariableName:
-  Exclude:
-    - 'lib/fog/vsphere/requests/compute/create_vm.rb'
-    - 'lib/fog/vsphere/requests/compute/list_datacenters.rb'
-    - 'lib/fog/vsphere/requests/compute/list_resource_pools.rb'
-    - 'lib/fog/vsphere/requests/compute/list_server_types.rb'
-    - 'lib/fog/vsphere/requests/compute/vm_clone.rb'
-    - 'tests/compute_tests.rb'
-
 # Offense count: 10
 Style/CaseEquality:
   Exclude:
     - 'lib/fog/vsphere/requests/compute/list_child_snapshots.rb'
     - 'lib/fog/vsphere/requests/compute/revert_to_snapshot.rb'
@@ -150,11 +114,11 @@
 # Offense count: 1
 Style/DoubleNegation:
   Exclude:
     - 'tests/helpers/succeeds_helper.rb'
 
-# Offense count: 12
+# Offense count: 14
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Exclude:
     - 'lib/fog/vsphere/compute.rb'
     - 'lib/fog/vsphere/models/compute/interfaces.rb'
@@ -163,10 +127,11 @@
     - 'lib/fog/vsphere/requests/compute/create_group.rb'
     - 'lib/fog/vsphere/requests/compute/create_rule.rb'
     - 'lib/fog/vsphere/requests/compute/create_vm.rb'
     - 'lib/fog/vsphere/requests/compute/list_resource_pools.rb'
     - 'lib/fog/vsphere/requests/compute/list_server_types.rb'
+    - 'lib/fog/vsphere/requests/compute/vm_relocate.rb'
 
 # Offense count: 2
 Style/IfInsideElse:
   Exclude:
     - 'lib/fog/vsphere/models/compute/cdrom.rb'
@@ -197,10 +162,26 @@
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
   Exclude:
     - 'Rakefile'
 
+# Offense count: 1
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+Style/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/fog/vsphere/compute.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/RedundantSelf:
+  Exclude:
+    - 'lib/fog/vsphere/models/compute/volume.rb'
+
 # Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
 # SupportedStyles: slashes, percent_r, mixed
 Style/RegexpLiteral:
@@ -213,5 +194,16 @@
 # Cop supports --auto-correct.
 # Configuration parameters: AllowAsExpressionSeparator.
 Style/Semicolon:
   Exclude:
     - 'tests/models/compute/rules_tests.rb'
+
+# Offense count: 14
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, camelCase
+Style/VariableName:
+  Exclude:
+    - 'lib/fog/vsphere/requests/compute/create_vm.rb'
+    - 'lib/fog/vsphere/requests/compute/list_datacenters.rb'
+    - 'lib/fog/vsphere/requests/compute/list_resource_pools.rb'
+    - 'lib/fog/vsphere/requests/compute/list_server_types.rb'
+    - 'lib/fog/vsphere/requests/compute/vm_clone.rb'