spec/flipper_integration_spec.rb in flipper-0.28.3 vs spec/flipper_integration_spec.rb in flipper-1.0.0.pre
- old
+ new
@@ -22,12 +22,12 @@
end
let(:pitt) { Flipper::Actor.new(1) }
let(:clooney) { Flipper::Actor.new(10) }
- let(:five_percent_of_actors) { flipper.actors(5) }
- let(:five_percent_of_time) { flipper.time(5) }
+ let(:five_percent_of_actors) { Flipper::Types::PercentageOfActors.new(5) }
+ let(:five_percent_of_time) { Flipper::Types::PercentageOfTime.new(5) }
before do
described_class.register(:admins, &:admin?)
described_class.register(:devs, &:dev?)
end
@@ -67,15 +67,15 @@
it 'does not enable feature for non flipper actor in other group' do
expect(feature.enabled?(dev_actor)).to eq(false)
end
it 'enables feature for flipper actor in group' do
- expect(feature.enabled?(flipper.actor(admin_actor))).to eq(true)
+ expect(feature.enabled?(Flipper::Types::Actor.new(admin_actor))).to eq(true)
end
it 'does not enable for flipper actor not in group' do
- expect(feature.enabled?(flipper.actor(dev_actor))).to eq(false)
+ expect(feature.enabled?(Flipper::Types::Actor.new(dev_actor))).to eq(false)
end
it 'does not enable feature for all' do
expect(feature.enabled?).to eq(false)
end
@@ -254,15 +254,15 @@
it 'does not disable feature for non flipper actor in other groups' do
expect(feature.enabled?(dev_actor)).to eq(true)
end
it 'disables feature for flipper actor in group' do
- expect(feature.enabled?(flipper.actor(admin_actor))).to eq(false)
+ expect(feature.enabled?(Flipper::Types::Actor.new(admin_actor))).to eq(false)
end
it 'does not disable feature for flipper actor in other groups' do
- expect(feature.enabled?(flipper.actor(dev_actor))).to eq(true)
+ expect(feature.enabled?(Flipper::Types::Actor.new(dev_actor))).to eq(true)
end
it 'adds feature to set of features' do
expect(flipper.features.map(&:name)).to include(:search)
end
@@ -292,11 +292,11 @@
end
end
context 'with a percentage of actors' do
before do
- @result = feature.disable(flipper.actors(0))
+ @result = feature.disable(Flipper::Types::PercentageOfActors.new(0))
end
it 'returns true' do
expect(@result).to eq(true)
end
@@ -316,11 +316,11 @@
end
context 'with a percentage of time' do
before do
@gate = feature.gate(:percentage_of_time)
- @result = feature.disable(flipper.time(0))
+ @result = feature.disable(Flipper::Types::PercentageOfTime.new(0))
end
it 'returns true' do
expect(@result).to eq(true)
end
@@ -371,30 +371,30 @@
before do
feature.enable admin_group
end
it 'returns true' do
- expect(feature.enabled?(flipper.actor(admin_actor))).to eq(true)
+ expect(feature.enabled?(Flipper::Types::Actor.new(admin_actor))).to eq(true)
expect(feature.enabled?(admin_actor)).to eq(true)
end
it 'returns true for truthy block values' do
- expect(feature.enabled?(flipper.actor(admin_truthy_actor))).to eq(true)
+ expect(feature.enabled?(Flipper::Types::Actor.new(admin_truthy_actor))).to eq(true)
end
it 'returns true if any actor is in enabled group' do
expect(feature.enabled?(dev_actor, admin_actor)).to be(true)
end
end
context 'for actor in disabled group' do
it 'returns false' do
- expect(feature.enabled?(flipper.actor(dev_actor))).to eq(false)
+ expect(feature.enabled?(Flipper::Types::Actor.new(dev_actor))).to eq(false)
expect(feature.enabled?(dev_actor)).to eq(false)
end
it 'returns false for falsey block values' do
- expect(feature.enabled?(flipper.actor(admin_falsey_actor))).to eq(false)
+ expect(feature.enabled?(Flipper::Types::Actor.new(admin_falsey_actor))).to eq(false)
end
end
context 'for enabled actor' do
before do