spec/flipper/instrumentation/statsd_subscriber_spec.rb in flipper-0.7.1 vs spec/flipper/instrumentation/statsd_subscriber_spec.rb in flipper-0.7.2

- old
+ new

@@ -1,10 +1,10 @@ require 'helper' require 'flipper/adapters/memory' require 'flipper/instrumentation/statsd' -describe Flipper::Instrumentation::StatsdSubscriber do +RSpec.describe Flipper::Instrumentation::StatsdSubscriber do let(:statsd_client) { Statsd.new } let(:socket) { FakeUDPSocket.new } let(:adapter) { Flipper::Adapters::Memory.new } let(:flipper) { Flipper.new(adapter, :instrumenter => ActiveSupport::Notifications) @@ -22,14 +22,16 @@ Thread.current[:statsd_socket] = nil end def assert_timer(metric) regex = /#{Regexp.escape metric}\:\d+\|ms/ - socket.buffer.detect { |op| op.first =~ regex }.should_not be_nil + result = socket.buffer.detect { |op| op.first =~ regex } + expect(result).not_to be_nil end def assert_counter(metric) - socket.buffer.detect { |op| op.first == "#{metric}:1|c" }.should_not be_nil + result = socket.buffer.detect { |op| op.first == "#{metric}:1|c" } + expect(result).not_to be_nil end context "for enabled feature" do it "updates feature metrics when calls happen" do flipper[:stats].enable(user)