spec/flipper/instrumentation/metriks_subscriber_spec.rb in flipper-0.7.1 vs spec/flipper/instrumentation/metriks_subscriber_spec.rb in flipper-0.7.2

- old
+ new

@@ -1,10 +1,10 @@ require 'helper' require 'flipper/adapters/memory' require 'flipper/instrumentation/metriks' -describe Flipper::Instrumentation::MetriksSubscriber do +RSpec.describe Flipper::Instrumentation::MetriksSubscriber do let(:adapter) { Flipper::Adapters::Memory.new } let(:flipper) { Flipper.new(adapter, :instrumenter => ActiveSupport::Notifications) } @@ -15,45 +15,45 @@ end context "for enabled feature" do it "updates feature metrics when calls happen" do flipper[:stats].enable(user) - Metriks.timer("flipper.feature_operation.enable").count.should be(1) + expect(Metriks.timer("flipper.feature_operation.enable").count).to be(1) flipper[:stats].enabled?(user) - Metriks.timer("flipper.feature_operation.enabled").count.should be(1) - Metriks.meter("flipper.feature.stats.enabled").count.should be(1) + expect(Metriks.timer("flipper.feature_operation.enabled").count).to be(1) + expect(Metriks.meter("flipper.feature.stats.enabled").count).to be(1) end end context "for disabled feature" do it "updates feature metrics when calls happen" do flipper[:stats].disable(user) - Metriks.timer("flipper.feature_operation.disable").count.should be(1) + expect(Metriks.timer("flipper.feature_operation.disable").count).to be(1) flipper[:stats].enabled?(user) - Metriks.timer("flipper.feature_operation.enabled").count.should be(1) - Metriks.meter("flipper.feature.stats.disabled").count.should be(1) + expect(Metriks.timer("flipper.feature_operation.enabled").count).to be(1) + expect(Metriks.meter("flipper.feature.stats.disabled").count).to be(1) end end it "updates adapter metrics when calls happen" do flipper[:stats].enable(user) - Metriks.timer("flipper.adapter.memory.enable").count.should be(1) + expect(Metriks.timer("flipper.adapter.memory.enable").count).to be(1) flipper[:stats].enabled?(user) - Metriks.timer("flipper.adapter.memory.get").count.should be(1) + expect(Metriks.timer("flipper.adapter.memory.get").count).to be(1) flipper[:stats].disable(user) - Metriks.timer("flipper.adapter.memory.disable").count.should be(1) + expect(Metriks.timer("flipper.adapter.memory.disable").count).to be(1) end it "updates gate metrics when calls happen" do flipper[:stats].enable(user) flipper[:stats].enabled?(user) - Metriks.timer("flipper.gate_operation.boolean.open").count.should be(1) - Metriks.timer("flipper.feature.stats.gate_operation.boolean.open").count.should be(1) - Metriks.meter("flipper.feature.stats.gate.actor.open").count.should be(1) - Metriks.meter("flipper.feature.stats.gate.boolean.closed").count.should be(1) + expect(Metriks.timer("flipper.gate_operation.boolean.open").count).to be(1) + expect(Metriks.timer("flipper.feature.stats.gate_operation.boolean.open").count).to be(1) + expect(Metriks.meter("flipper.feature.stats.gate.actor.open").count).to be(1) + expect(Metriks.meter("flipper.feature.stats.gate.boolean.closed").count).to be(1) end end