spec/flipper/api/v1/actions/feature_spec.rb in flipper-api-0.10.2 vs spec/flipper/api/v1/actions/feature_spec.rb in flipper-api-0.11.0.beta1

@@ -5,25 +5,24 @@
   let(:feature) { build_feature }
   let(:gate) { feature.gate(:boolean) }
 
   describe 'get' do
     context 'enabled feature' do
-
       before do
         flipper[:my_feature].enable
-        get 'api/v1/features/my_feature'
+        get '/features/my_feature'
       end
 
       it 'responds with correct attributes' do
         response_body = {
           'key' => 'my_feature',
           'state' => 'on',
           'gates' => [
             {
               'key' => 'boolean',
               'name' => 'boolean',
-              'value' => true,
+              'value' => 'true',
             },
             {
               'key' => 'groups',
               'name' => 'group',
               'value' => [],
@@ -34,105 +33,104 @@
               'value' => [],
             },
             {
               'key' => 'percentage_of_actors',
               'name' => 'percentage_of_actors',
-              'value' => 0,
+              'value' => nil,
             },
             {
               'key' => 'percentage_of_time',
               'name' => 'percentage_of_time',
-              'value' => 0,
-            }
-          ]
+              'value' => nil,
+            },
+          ],
         }
 
         expect(last_response.status).to eq(200)
         expect(json_response).to eq(response_body)
       end
     end
 
     context 'disabled feature' do
       before do
         flipper[:my_feature].disable
-        get 'api/v1/features/my_feature'
+        get '/features/my_feature'
       end
 
       it 'responds with correct attributes' do
         response_body = {
           'key' => 'my_feature',
           'state' => 'off',
           'gates' => [
             {
               'key' => 'boolean',
               'name' => 'boolean',
-              'value' => false,
+              'value' => nil,
             },
             {
-              'key'=> 'groups',
-              'name'=> 'group',
-              'value'=> [],
+              'key' => 'groups',
+              'name' => 'group',
+              'value' => [],
             },
             {
               'key' => 'actors',
               'name' => 'actor',
               'value' => [],
             },
             {
               'key' => 'percentage_of_actors',
               'name' => 'percentage_of_actors',
-              'value'=> 0,
+              'value' => nil,
             },
             {
               'key' => 'percentage_of_time',
               'name' => 'percentage_of_time',
-              'value' => 0,
-            }
-          ]
+              'value' => nil,
+            },
+          ],
         }
 
         expect(last_response.status).to eq(200)
         expect(json_response).to eq(response_body)
       end
     end
 
     context 'feature does not exist' do
       before do
-        get 'api/v1/features/not_a_feature'
+        get '/features/not_a_feature'
       end
 
-      it 'returns 404' do
+      it '404s' do
         expect(last_response.status).to eq(404)
+        expected = {
+          'code' => 1,
+          'message' => 'Feature not found.',
+          'more_info' => api_error_code_reference_url,
+        }
+        expect(json_response).to eq(expected)
       end
-
-      it 'returns formatted error response body' do
-        expect(json_response).to eq({ "code" => 1, "message" => "Feature not found.", "more_info" => "https://github.com/jnunemaker/flipper/tree/master/docs/api#error-code-reference" })
-      end
     end
   end
 
   describe 'delete' do
     context 'succesful request' do
       it 'deletes feature' do
         flipper[:my_feature].enable
         expect(flipper.features.map(&:key)).to include('my_feature')
-        delete 'api/v1/features/my_feature'
+        delete '/features/my_feature'
         expect(last_response.status).to eq(204)
         expect(flipper.features.map(&:key)).not_to include('my_feature')
       end
     end
 
     context 'feature not found' do
       before do
-        delete 'api/v1/features/my_feature'
+        delete '/features/my_feature'
       end
 
-      it 'returns 404' do
-        expect(last_response.status).to eq(404)
-      end
-
-      it 'returns formatted error response body' do
-        expect(json_response).to eq({ "code" => 1, "message" => "Feature not found.", "more_info" => "https://github.com/jnunemaker/flipper/tree/master/docs/api#error-code-reference" })
+      it 'responds with 204' do
+        expect(last_response.status).to eq(204)
+        expect(flipper.features.map(&:key)).not_to include('my_feature')
       end
     end
   end
 end