spec/lib/flapjack/gateways/api/entity_presenter_spec.rb in flapjack-0.7.35 vs spec/lib/flapjack/gateways/api/entity_presenter_spec.rb in flapjack-0.8.0

- old
+ new

@@ -15,94 +15,94 @@ let(:start_time) { time - (6 * 60 * 60) } let(:end_time) { time - (2 * 60 * 60) } def expect_check_presenters - entity.should_receive(:name).exactly(4).times.and_return('foo') - entity.should_receive(:check_list).and_return(['ping', 'ssh']) - Flapjack::Data::EntityCheck.should_receive(:for_entity). + expect(entity).to receive(:name).exactly(4).times.and_return('foo') + expect(entity).to receive(:check_list).and_return(['ping', 'ssh']) + expect(Flapjack::Data::EntityCheck).to receive(:for_entity). with(entity, 'ssh', anything).and_return(check_a) - Flapjack::Data::EntityCheck.should_receive(:for_entity). + expect(Flapjack::Data::EntityCheck).to receive(:for_entity). with(entity, 'ping', anything).and_return(check_b) - Flapjack::Gateways::API::EntityCheckPresenter.should_receive(:new). + expect(Flapjack::Gateways::API::EntityCheckPresenter).to receive(:new). with(check_a).and_return(checkpres_a) - Flapjack::Gateways::API::EntityCheckPresenter.should_receive(:new). + expect(Flapjack::Gateways::API::EntityCheckPresenter).to receive(:new). with(check_b).and_return(checkpres_b) end it 'returns a list of status hashes for each check on an entity' do expect_check_presenters status_a = double('status_a') status_b = double('status_b') - checkpres_a.should_receive(:status).and_return(status_a) - checkpres_b.should_receive(:status).and_return(status_b) + expect(checkpres_a).to receive(:status).and_return(status_a) + expect(checkpres_b).to receive(:status).and_return(status_b) ep = Flapjack::Gateways::API::EntityPresenter.new(entity) status = ep.status - status.should == [{:entity => entity.name, :check => 'ping', :status => status_b}, - {:entity => entity.name, :check => 'ssh', :status => status_a}] + expect(status).to eq([{:entity => entity.name, :check => 'ping', :status => status_b}, + {:entity => entity.name, :check => 'ssh', :status => status_a}]) end it "returns a list of outage hashes for each check on an entity" do expect_check_presenters outages_a = double('outages_a') outages_b = double('outages_b') - checkpres_a.should_receive(:outages).with(start_time, end_time). + expect(checkpres_a).to receive(:outages).with(start_time, end_time). and_return(outages_a) - checkpres_b.should_receive(:outages).with(start_time, end_time). + expect(checkpres_b).to receive(:outages).with(start_time, end_time). and_return(outages_b) ep = Flapjack::Gateways::API::EntityPresenter.new(entity) outages = ep.outages(start_time, end_time) - outages.should == [{:entity => entity.name, :check => 'ping', :outages => outages_b}, - {:entity => entity.name, :check => 'ssh', :outages => outages_a}] + expect(outages).to eq([{:entity => entity.name, :check => 'ping', :outages => outages_b}, + {:entity => entity.name, :check => 'ssh', :outages => outages_a}]) end it "returns a list of unscheduled maintenance periods for each check on an entity" do expect_check_presenters unsched_maint_a = double('unsched_maint_a') unsched_maint_b = double('unsched_maint_b') - checkpres_a.should_receive(:unscheduled_maintenances).with(start_time, end_time). + expect(checkpres_a).to receive(:unscheduled_maintenances).with(start_time, end_time). and_return(unsched_maint_a) - checkpres_b.should_receive(:unscheduled_maintenances).with(start_time, end_time). + expect(checkpres_b).to receive(:unscheduled_maintenances).with(start_time, end_time). and_return(unsched_maint_b) ep = Flapjack::Gateways::API::EntityPresenter.new(entity) unsched_maint = ep.unscheduled_maintenances(start_time, end_time) - unsched_maint.should == [{:entity => entity.name, :check => 'ping', :unscheduled_maintenances => unsched_maint_b}, - {:entity => entity.name, :check => 'ssh', :unscheduled_maintenances => unsched_maint_a}] + expect(unsched_maint).to eq([{:entity => entity.name, :check => 'ping', :unscheduled_maintenances => unsched_maint_b}, + {:entity => entity.name, :check => 'ssh', :unscheduled_maintenances => unsched_maint_a}]) end it "returns a list of scheduled maintenance periods for each check on an entity" do expect_check_presenters sched_maint_a = double('sched_maint_a') sched_maint_b = double('sched_maint_b') - checkpres_a.should_receive(:scheduled_maintenances).with(start_time, end_time). + expect(checkpres_a).to receive(:scheduled_maintenances).with(start_time, end_time). and_return(sched_maint_a) - checkpres_b.should_receive(:scheduled_maintenances).with(start_time, end_time). + expect(checkpres_b).to receive(:scheduled_maintenances).with(start_time, end_time). and_return(sched_maint_b) ep = Flapjack::Gateways::API::EntityPresenter.new(entity) sched_maint = ep.scheduled_maintenances(start_time, end_time) - sched_maint.should == [{:entity => entity.name, :check => 'ping', :scheduled_maintenances => sched_maint_b}, - {:entity => entity.name, :check => 'ssh', :scheduled_maintenances => sched_maint_a}] + expect(sched_maint).to eq([{:entity => entity.name, :check => 'ping', :scheduled_maintenances => sched_maint_b}, + {:entity => entity.name, :check => 'ssh', :scheduled_maintenances => sched_maint_a}]) end it "returns a list of downtime for each check on an entity" do expect_check_presenters downtime_a = double('downtime_a') downtime_b = double('downtime_b') - checkpres_a.should_receive(:downtime).with(start_time, end_time). + expect(checkpres_a).to receive(:downtime).with(start_time, end_time). and_return(downtime_a) - checkpres_b.should_receive(:downtime).with(start_time, end_time). + expect(checkpres_b).to receive(:downtime).with(start_time, end_time). and_return(downtime_b) ep = Flapjack::Gateways::API::EntityPresenter.new(entity) downtime = ep.downtime(start_time, end_time) - downtime.should == [{:entity => entity.name, :check => 'ping', :downtime => downtime_b}, - {:entity => entity.name, :check => 'ssh', :downtime => downtime_a}] + expect(downtime).to eq([{:entity => entity.name, :check => 'ping', :downtime => downtime_b}, + {:entity => entity.name, :check => 'ssh', :downtime => downtime_a}]) end end