spec/rest/locations_spec.rb in finapps-6.10.0 vs spec/rest/locations_spec.rb in finapps-6.10.1

@@ -3,17 +3,20 @@
 require 'digest'
 
 RSpec.describe FinApps::REST::Locations do
   include SpecHelpers::Client
 
+  let(:id) { :id }
+
   describe '#list' do
     subject(:list) { described_class.new(client).list filter }
 
     let(:filter) { nil }
 
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
+    it { expect(list[RESULTS]).to all(have_key(:id)) }
     it { expect(list[RESULTS]).to all(have_key(:name)) }
     it { expect(list[RESULTS]).to all(have_key(:state)) }
 
     context 'when the JMESPath filter is invalid' do
       let(:filter) { 'invalid' }
@@ -39,75 +42,50 @@
         .to(eq('the server responded with status 404'))
     end
   end
 
   describe '#show' do
-    subject(:show) { described_class.new(client).show(key) }
+    subject(:show) { described_class.new(client).show(id) }
 
-    let(:key) { Digest::SHA256.hexdigest('Quick Mart Urgent CareMD,MD') }
-
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
+    it { expect(show[RESULTS]).to have_key(:id) }
     it { expect(show[RESULTS]).to have_key(:name) }
     it { expect(show[RESULTS]).to have_key(:state) }
 
-    context 'when key is not a valid SHA256' do
-      let(:key) { 'invalid_SHA256' }
+    context 'when id does not match any location' do
+      let(:id) { 'not_found' }
 
-      it_behaves_like 'a failed request'
-    end
-
-    context 'when key does not match any location' do
-      let(:key) { 'not_found' }
-
-      it_behaves_like 'a failed request'
       it_behaves_like 'a request to a not found resource'
     end
   end
 
   describe '#update' do
-    subject(:update) { described_class.new(client).update(key, params) }
+    subject(:update) { described_class.new(client).update(id, params) }
 
-    let(:key) { Digest::SHA256.hexdigest('Quick Mart Urgent CareMD,MD') }
     let(:params) { {name: 'Quick Mart Non-Urgent Care', state: {code: 'MD'}} }
 
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
     it { expect(update[RESULTS]).to be_nil }
 
-    context 'when key is not a valid SHA256' do
-      let(:key) { 'invalid_SHA256' }
+    context 'when id does not match any location' do
+      let(:id) { 'not_found' }
 
-      it_behaves_like 'a failed request'
-    end
-
-    context 'when key does not match any location' do
-      let(:key) { 'not_found' }
-
-      it_behaves_like 'a failed request'
       it_behaves_like 'a request to a not found resource'
     end
   end
 
   describe '#destroy' do
-    subject(:destroy) { described_class.new(client).destroy(key) }
+    subject(:destroy) { described_class.new(client).destroy(id) }
 
-    let(:key) { Digest::SHA256.hexdigest('Quick Mart Urgent CareMD,MD') }
-
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
     it { expect(destroy[RESULTS]).to be_nil }
 
-    context 'when key is not a valid SHA256' do
-      let(:key) { 'invalid_SHA256' }
+    context 'when id does not match any location' do
+      let(:id) { 'not_found' }
 
-      it_behaves_like 'a failed request'
-    end
-
-    context 'when key does not match any location' do
-      let(:key) { 'not_found' }
-
-      it_behaves_like 'a failed request'
       it_behaves_like 'a request to a not found resource'
     end
   end
 end