spec/rest/consumers_spec.rb in finapps-5.0.3 vs spec/rest/consumers_spec.rb in finapps-5.0.4

@@ -1,69 +1,96 @@
 # frozen_string_literal: true
 
 require 'spec_helpers/client'
-RSpec.describe FinApps::REST::Consumers, 'initialized with valid FinApps::Client object' do
+RSpec.describe FinApps::REST::Consumers,
+               'initialized with valid FinApps::Client object' do
   include SpecHelpers::Client
   subject(:users) { FinApps::REST::Consumers.new(client) }
   missing_public_id = ': public_id'
 
   describe '#create' do
     let(:results) { create[0] }
     let(:error_messages) { create[1] }
 
     context 'when missing params' do
-      it { expect { subject.create(nil) }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { subject.create(nil) }.to raise_error(
+          FinAppsCore::MissingArgumentsError
+        )
+      end
     end
 
     context 'for valid params' do
       let(:create) { subject.create(email: 'email', password: 'password') }
 
       it { expect { create }.not_to raise_error }
-      it('results is a Hashie::Rash') { expect(results).to be_a(Hashie::Mash::Rash) }
-      it('performs a post and returns the response') { expect(results).to respond_to(:public_id) }
+      it('results is a Hash') do
+        expect(results).to be_a(Hash)
+      end
+      it('performs a post and returns the response') do
+        expect(results).to have_key(:public_id)
+      end
       it('error_messages array is empty') { expect(error_messages).to eq([]) }
     end
 
     context 'for invalid params' do
       let(:create) { subject.create(email: 'email') }
 
       it { expect { create }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
-      it('error messages array is populated') { expect(error_messages.first.downcase).to eq('invalid request body') }
+      it('error messages array is populated') do
+        expect(error_messages.first.downcase).to eq('invalid request body')
+      end
     end
   end
 
   describe '#show' do
     context 'when missing public_id' do
-      it { expect { subject.show(nil) }.to raise_error(FinAppsCore::MissingArgumentsError, missing_public_id) }
+      it do
+        expect { subject.show(nil) }.to raise_error(
+          FinAppsCore::MissingArgumentsError,
+          missing_public_id
+        )
+      end
     end
 
     context 'for valid public_id' do
       let(:show) { subject.show(:valid_public_id) }
       let(:results) { show[0] }
       let(:error_messages) { show[1] }
 
       it { expect { show }.not_to raise_error }
-      it('results is a Hashie::Rash') { expect(results).to be_a(Hashie::Mash::Rash) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:public_id) }
+      it('results is a Hash') do
+        expect(results).to be_a(Hash)
+      end
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:public_id)
+      end
       it('error_messages array is empty') { expect(error_messages).to eq([]) }
     end
 
     context 'for invalid token' do
       let(:show) { subject.show(:invalid_public_id) }
       let(:results) { show[0] }
       let(:error_messages) { show[1] }
 
       it { expect { show }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
-      it('error messages array is populated') { expect(error_messages.first.downcase).to eq('resource not found') }
+      it('error messages array is populated') do
+        expect(error_messages.first.downcase).to eq('resource not found')
+      end
     end
   end
 
   describe '#update' do
     context 'when missing public_id' do
-      it { expect { subject.update(nil, {}) }.to raise_error(FinAppsCore::MissingArgumentsError, missing_public_id) }
+      it do
+        expect { subject.update(nil, {}) }.to raise_error(
+          FinAppsCore::MissingArgumentsError,
+          missing_public_id
+        )
+      end
     end
 
     context 'when updating user details' do
       context 'for valid public_id' do
         let(:update) { subject.update(:valid_public_id, postal_code: '33021') }
@@ -74,49 +101,76 @@
         it('results is nil') { expect(results).to be_nil }
         it('error_messages array is empty') { expect(error_messages).to eq([]) }
       end
 
       context 'for invalid public_id' do
-        let(:update) { subject.update(:invalid_public_id, postal_code: '33021') }
+        let(:update) do
+          subject.update(:invalid_public_id, postal_code: '33021')
+        end
         let(:results) { update[0] }
         let(:error_messages) { update[1] }
 
         it { expect { update }.not_to raise_error }
         it('results is nil') { expect(results).to be_nil }
         it('error messages array is populated') do
-          expect(error_messages.first.downcase).to eq('invalid user id specified.')
+          expect(error_messages.first.downcase).to eq(
+            'invalid user id specified.'
+          )
         end
       end
     end
 
     context 'when updating password' do
       context 'for valid public_id' do
-        let(:update) { subject.update(:valid_public_id, password: 'Aa123456!', password_confirm: 'Aa123456!') }
+        let(:update) do
+          subject.update(
+            :valid_public_id,
+            password: 'Aa123456!', password_confirm: 'Aa123456!'
+          )
+        end
         let(:results) { update[0] }
         let(:error_messages) { update[1] }
 
         it { expect { update }.not_to raise_error }
-        it('results is a Hashie::Rash') { expect(results).to be_a(Hashie::Mash::Rash) }
-        it('the public_id is on the results') { expect(results).to respond_to(:public_id) }
-        it('the new token is on the results') { expect(results).to respond_to(:token) }
+        it('results is a Hash') do
+          expect(results).to be_a(Hash)
+        end
+        it('the public_id is on the results') do
+          expect(results).to have_key(:public_id)
+        end
+        it('the new token is on the results') do
+          expect(results).to have_key(:token)
+        end
         it('error_messages array is empty') { expect(error_messages).to eq([]) }
       end
 
       context 'for invalid public_id' do
-        let(:update) { subject.update(:invalid_public_id, password: 'Aa123456!', password_confirm: 'Aa123456!') }
+        let(:update) do
+          subject.update(
+            :invalid_public_id,
+            password: 'Aa123456!', password_confirm: 'Aa123456!'
+          )
+        end
         let(:results) { update[0] }
         let(:error_messages) { update[1] }
 
         it { expect { update }.not_to raise_error }
         it('results is nil') { expect(results).to be_nil }
-        it('error messages array is populated') { expect(error_messages.first.downcase).to eq('resource not found') }
+        it('error messages array is populated') do
+          expect(error_messages.first.downcase).to eq('resource not found')
+        end
       end
     end
 
     describe '#destroy' do
       context 'when missing public_id' do
-        it { expect { subject.destroy(nil) }.to raise_error(FinAppsCore::MissingArgumentsError, missing_public_id) }
+        it do
+          expect { subject.destroy(nil) }.to raise_error(
+            FinAppsCore::MissingArgumentsError,
+            missing_public_id
+          )
+        end
       end
 
       context 'for valid public_id' do
         let(:destroy) { subject.destroy(:valid_public_id) }
         let(:results) { destroy[0] }
@@ -132,10 +186,12 @@
         let(:results) { destroy[0] }
         let(:error_messages) { destroy[1] }
 
         it { expect { destroy }.not_to raise_error }
         it('results is nil') { expect(results).to be_nil }
-        it('error messages array is populated') { expect(error_messages.first.downcase).to eq('resource not found') }
+        it('error messages array is populated') do
+          expect(error_messages.first.downcase).to eq('resource not found')
+        end
       end
     end
   end
 end