rss_entry_spec.rb in feedjira-3.2.1

- old
+ new

@@ -1,66 +1,66 @@
 # frozen_string_literal: true
 
 require "spec_helper"
 
 describe Feedjira::Parser::RSSEntry do
-  before(:each) do
+  before do
     # I don't really like doing it this way because these unit test should only
     # rely on RSSEntry, but this is actually how it should work. You would
     # never just pass entry xml straight to the AtomEnry
     @entry = Feedjira::Parser::RSS.parse(sample_rss_feed).entries.first
     tag = "wfw:commentRss"
     Feedjira::Feed.add_common_feed_entry_element tag, as: :comment_rss
   end
 
-  after(:each) do
+  after do
     # We change the title in one or more specs to test []=
     if @entry.title != "Nokogiri’s Slop Feature"
       feed = Feedjira::Parser::RSS.parse sample_rss_feed
       @entry.title = feed.entries.first.title
     end
   end
 
-  it "should parse the title" do
+  it "parses the title" do
     expect(@entry.title).to eq "Nokogiri’s Slop Feature"
   end
 
-  it "should parse the url" do
+  it "parses the url" do
     expect(@entry.url).to eq "http://tenderlovemaking.com/2008/12/04/nokogiris-slop-feature/"
   end
 
-  it "should parse the author" do
+  it "parses the author" do
     expect(@entry.author).to eq "Aaron Patterson"
   end
 
-  it "should parse the content" do
+  it "parses the content" do
     expect(@entry.content).to eq sample_rss_entry_content
   end
 
-  it "should provide a summary" do
+  it "provides a summary" do
     summary = "Oops!  When I released nokogiri version 1.0.7, I totally forgot to talk about Nokogiri::Slop() feature that was added.  Why is it called \"slop\"?  It lets you sloppily explore documents.  Basically, it decorates your document with method_missing() that allows you to search your document via method calls.\nGiven this document:\n\ndoc = Nokogiri::Slop&#40;&#60;&#60;-eohtml&#41;\n&#60;html&#62;\n&#160; &#60;body&#62;\n&#160; [...]"
     expect(@entry.summary).to eq summary
   end
 
-  it "should parse the published date" do
+  it "parses the published date" do
     published = Time.parse_safely "Thu Dec 04 17:17:49 UTC 2008"
     expect(@entry.published).to eq published
   end
 
-  it "should parse the categories" do
+  it "parses the categories" do
     expect(@entry.categories).to eq %w[computadora nokogiri rails]
   end
 
-  it "should parse the guid as id" do
+  it "parses the guid as id" do
     expect(@entry.id).to eq "http://tenderlovemaking.com/?p=198"
   end
 
-  it "should support each" do
+  it "supports each" do
     expect(@entry).to respond_to :each
   end
 
-  it "should be able to list out all fields with each" do
+  it "is able to list out all fields with each" do
     all_fields = []
     title_value = ""
     @entry.each do |field, value|
       all_fields << field
       title_value = value if field == "title"
@@ -80,40 +80,40 @@
       url
     ]
     expect(all_fields.sort).to eq expected_fields
   end
 
-  it "should support checking if a field exists in the entry" do
+  it "supports checking if a field exists in the entry" do
     expect(@entry).to include "title"
     expect(@entry).to include "author"
   end
 
-  it "should allow access to fields with hash syntax" do
+  it "allows access to fields with hash syntax" do
     expect(@entry["title"]).to eq "Nokogiri’s Slop Feature"
     expect(@entry["author"]).to eq "Aaron Patterson"
   end
 
-  it "should allow setting field values with hash syntax" do
+  it "allows setting field values with hash syntax" do
     @entry["title"] = "Foobar"
     expect(@entry.title).to eq "Foobar"
   end
 
-  it "should ignore urls from guids with isPermaLink='false'" do
+  it "ignores urls from guids with isPermaLink='false'" do
     feed = Feedjira.parse(sample_rss_feed_permalinks)
     expect(feed.entries[0].url).to eq nil
   end
 
-  it "should get urls from guids with isPermaLink='true'" do
+  it "gets urls from guids with isPermaLink='true'" do
     feed = Feedjira.parse(sample_rss_feed_permalinks)
     expect(feed.entries[1].url).to eq "http://example.com/2"
   end
 
-  it "should get urls from guid where isPermaLink is unspecified" do
+  it "gets urls from guid where isPermaLink is unspecified" do
     feed = Feedjira.parse(sample_rss_feed_permalinks)
     expect(feed.entries[2].url).to eq "http://example.com/3"
   end
 
-  it "should prefer urls from <link> when both guid and link are specified" do
+  it "prefers urls from <link> when both guid and link are specified" do
     feed = Feedjira.parse(sample_rss_feed_permalinks)
     expect(feed.entries[3].url).to eq "http://example.com/4"
   end
 end