spec/feedjira/feed_spec.rb in feedjira-3.2.0 vs spec/feedjira/feed_spec.rb in feedjira-3.2.1

@@ -3,49 +3,50 @@
 require "spec_helper"
 
 class Hell < StandardError; end
 
 class FailParser
-  def self.parse(_xml, &on_failure)
-    on_failure.call "this parser always fails."
+  def self.parse(_xml)
+    yield "this parser always fails."
+    # on_failure.call
   end
 end
 
 describe Feedjira::Feed do
   describe "#add_common_feed_element" do
     before(:all) do
-      Feedjira::Feed.add_common_feed_element("generator")
+      described_class.add_common_feed_element("generator")
     end
 
-    it "should parse the added element out of Atom feeds" do
+    it "parses the added element out of Atom feeds" do
       expect(Feedjira.parse(sample_wfw_feed).generator).to eq "TypePad"
     end
 
-    it "should parse the added element out of Atom Feedburner feeds" do
+    it "parses the added element out of Atom Feedburner feeds" do
       expect(Feedjira::Parser::Atom.new).to respond_to(:generator)
     end
 
-    it "should parse the added element out of RSS feeds" do
+    it "parses the added element out of RSS feeds" do
       expect(Feedjira::Parser::RSS.new).to respond_to(:generator)
     end
   end
 
   describe "#add_common_feed_entry_element" do
     before(:all) do
       tag = "wfw:commentRss"
-      Feedjira::Feed.add_common_feed_entry_element tag, as: :comment_rss
+      described_class.add_common_feed_entry_element tag, as: :comment_rss
     end
 
-    it "should parse the added element out of Atom feeds entries" do
+    it "parses the added element out of Atom feeds entries" do
       entry = Feedjira.parse(sample_wfw_feed).entries.first
       expect(entry.comment_rss).to eq "this is the new val"
     end
 
-    it "should parse the added element out of Atom Feedburner feeds entries" do
+    it "parses the added element out of Atom Feedburner feeds entries" do
       expect(Feedjira::Parser::AtomEntry.new).to respond_to(:comment_rss)
     end
 
-    it "should parse the added element out of RSS feeds entries" do
+    it "parses the added element out of RSS feeds entries" do
       expect(Feedjira::Parser::RSSEntry.new).to respond_to(:comment_rss)
     end
   end
 end