spaceship/lib/spaceship/tunes/tunes_client.rb in fastlane-2.28.9 vs spaceship/lib/spaceship/tunes/tunes_client.rb in fastlane-2.29.0.beta.20170421010107

- old
+ new

@@ -263,11 +263,11 @@ # (String): The version number is shown on the App Store and should match the one you used in Xcode. # @param sku (String): A unique ID for your app that is not visible on the App Store. # @param bundle_id (String): The bundle ID must match the one you used in Xcode. It # can't be changed after you submit your first build. def create_application!(name: nil, primary_language: nil, version: nil, sku: nil, bundle_id: nil, bundle_id_suffix: nil, company_name: nil, platform: nil) - puts "The `version` parameter is deprecated. Use `Spaceship::Tunes::Application.ensure_version!` method instead" if version + UI.deprecated("The `version` parameter is deprecated. Use `Spaceship::Tunes::Application.ensure_version!` method instead") if version # First, we need to fetch the data from Apple, which we then modify with the user's values primary_language ||= "English" platform ||= "ios" r = request(:get, "ra/apps/create/v2/?platformString=#{platform}") @@ -322,22 +322,11 @@ r = request(:get, "ra/apps/#{app_id}/reviews/summary?platform=#{platform}&versionId=#{versionId}") parse_response(r, 'data') end def get_reviews(app_id, platform, storefront, versionId = '') - index = 0 - per_page = 100 # apple default - all_reviews = [] - loop do - r = request(:get, "ra/apps/#{app_id}/platforms/#{platform}/reviews?storefront=#{storefront}&versionId=#{versionId}&index=#{index}") - all_reviews.concat(parse_response(r, 'data')['reviews']) - if all_reviews.count < parse_response(r, 'data')['reviewCount'] - index += per_page - else - break - end - end - all_reviews + r = request(:get, "ra/apps/#{app_id}/reviews?platform=#{platform}&storefront=#{storefront}&versionId=#{versionId}") + parse_response(r, 'data')['reviews'] end ##################################################### # @!group AppVersions #####################################################